Commit graph

4328 commits

Author SHA1 Message Date
Josh Holmer
fbc93c0166 Lint against needless uses of collect()
Handles cases of `.collect().len()`, `.collect().is_empty()`, and
`.collect().contains()`. This lint is intended to be generic enough to
be added to at a later time with other similar patterns that could be
optimized.

Closes #3034
2018-09-03 23:29:44 -04:00
Philipp Hansch
c0513097ab
Merge pull request #3092 from illicitonion/issue-2879
default_trait_access skips <F as Default>::default()
2018-09-03 17:24:33 +02:00
Manish Goregaokar
78ec6e38b4
Merge pull request #3120 from rust-lang-nursery/ci_integration
Update travis integration tests to tool_lints
2018-09-03 09:37:18 +00:00
Philipp Krones
f5376a30a8
Merge pull request #3119 from joshtriplett/a-message-from-the-save-the-iters-foundation
iter conservation efforts: save the endangered .iter() and .into_iter()
2018-09-03 10:55:43 +02:00
Philipp Krones
4139207956
Update travis integration tests to tool_lints
`clippy_pedantic` -> `clippy::pedantic`
`clippy_nursery` -> `clippy::nursery`
2018-09-03 10:52:42 +02:00
Josh Triplett
779988303a iter conservation efforts: save the endangered .iter() and .into_iter()
Make explicit_iter_loop and explicit_into_iter_loop allow-by-default, so
that people can turn them on if they want to enforce that style; avoid
presenting them as *the* idiomatic Rust style, rather than just *a* style.
2018-09-03 01:24:46 -07:00
Philipp Hansch
2b7a5304f6
Merge pull request #3116 from phansch/fix_warning
Fix clippy -> clippy::all warning in CI
2018-09-03 07:35:24 +01:00
Philipp Hansch
f3839f0c1a
Fix clippy -> clippy::all warning in CI 2018-09-03 08:03:05 +02:00
Manish Goregaokar
2d0b7db980
Merge pull request #3115 from rust-lang-nursery/rm-token
Remove dependence of ci on github token
2018-09-03 05:48:46 +00:00
Manish Goregaokar
79d81ac3e7 Remove dependence of ci on github token 2018-09-03 09:20:15 +05:30
Manish Goregaokar
1d13c1f998
Merge pull request #2941 from rust-lang-nursery/prs
Run travis on rustc-master instead of nightly
2018-09-03 08:14:45 +05:30
Manish Goregaokar
6141339f88
Merge pull request #3114 from nrc/pub-conf
Make `Conf::default` available
2018-09-03 07:36:58 +05:30
Nick Cameron
d6f01f3a6c Make Conf::default available
Fixes RLS
2018-09-03 13:57:50 +12:00
Daniel Wagner-Hall
9f0216d520 Merge branch 'master' into issue-2879 2018-09-03 00:01:57 +01:00
Daniel Wagner-Hall
939d842ea1 Simplify 2018-09-02 23:42:07 +01:00
Daniel Wagner-Hall
368223a341 Use types rather than strings 2018-09-02 23:37:28 +01:00
Philipp Hansch
273e11fcaf
Trigger rebuild for AppVeyor (and fix grammar) 2018-09-02 11:31:39 +02:00
Philipp Hansch
8e0de3d120
Merge remote-tracking branch 'upstream/master' into prs 2018-09-02 11:05:49 +02:00
Manish Goregaokar
131c8f86b2
Merge pull request #3113 from mikerite/fix-3112
Fix #3112
2018-09-02 13:29:06 +05:30
Michael Wright
19157c02cb Fix #3112 2018-09-02 09:38:25 +02:00
Manish Goregaokar
c81d70e6bd
Merge pull request #2977 from flip1995/tool_lints
Implement tool_lints
2018-09-01 11:22:23 +05:30
Manish Goregaokar
9abf6fca9c Fix ptr offset tests 2018-08-31 00:38:27 -07:00
Manish Goregaokar
20dfaf7842 declare_lint -> declare_tool_lint 2018-08-31 00:34:48 -07:00
Oliver Schneider
73e8416df3
Merge pull request #3081 from mikerite/fix-3078
Fix #3078
2018-08-31 09:05:39 +02:00
Michael Wright
c6074a94b9 Merge branch 'master' into fix-3078 2018-08-31 06:17:11 +02:00
Michael Wright
daacac6b97 Revert "fix-3078: verify test case"
This reverts commit 6256ad05ba.
2018-08-31 06:15:55 +02:00
Oliver Schneider
d3f78d64bd
Merge pull request #2962 from phansch/further_automate_pre_publish
Further automate pre_publish.sh
2018-08-30 10:16:36 +02:00
Philipp Hansch
559b2f871f
Remove git diffing part
Because we no bump versions
2018-08-30 07:33:53 +02:00
Philipp Hansch
b87ab5ccf2
Merge pull request #3076 from mbrubeck/patch-1
Remove incorrect note from string_add_assign docs
2018-08-29 20:09:38 +01:00
Manish Goregaokar
e0ad732226
Merge pull request #3105 from frewsxcv/frewsxcv-private
Make clippy_lints::{utils,consts} modules private, remove unused items.
2018-08-29 11:24:00 -07:00
flip1995
daa4f0ad34 Implement backwards compatibility changes introduced by rust-lang/rust#53762 2018-08-29 11:08:29 -07:00
flip1995
d1f2f0c34c Fix some rebase fallout 2018-08-29 11:08:29 -07:00
flip1995
f3bb161f0e Adapt codebase to the tool_lints 2018-08-29 11:08:29 -07:00
flip1995
cfd4c538d4 Adapt ui-toml-tests to the tool_lints 2018-08-29 11:08:29 -07:00
flip1995
ea43fedf9e Adapt run-pass tests to the tool_lints 2018-08-29 11:08:29 -07:00
flip1995
e9af09c274 Adapt the *.stderr files of the ui-tests to the tool_lints 2018-08-29 11:08:29 -07:00
flip1995
1b6f6051a8 Adapt ui-tests to the tool_lints 2018-08-29 11:08:29 -07:00
flip1995
bb49b31254 Adapt scripts to the tool_lints 2018-08-29 11:08:29 -07:00
flip1995
83baf8f5fe Adapt documentation to the tool_lints 2018-08-29 11:08:29 -07:00
flip1995
8c07772dbb Switch to declare_tool_lint macro 2018-08-29 11:08:29 -07:00
flip1995
392235d6e1 Switch to tool_lints 2018-08-29 11:08:29 -07:00
Oliver Schneider
0f2eab6337
Merge pull request #3104 from frewsxcv/frewsxcv-ptr-offset-with-cast
New lint: Suggest `ptr.add([usize])` over `ptr.offset([usize] as isize)`.
2018-08-29 16:32:11 +02:00
Corey Farwell
f42442b6e0 dont deref 2018-08-29 09:07:09 -05:00
Corey Farwell
53928d5367 clippy suggestion 2018-08-29 08:27:32 -05:00
Corey Farwell
6445a5d79d derive copy/clone 2018-08-29 08:01:05 -05:00
Corey Farwell
d5534ca9db bring back sugg::range 2018-08-29 07:46:03 -05:00
Corey Farwell
9a8f206662 eof newline 2018-08-29 07:43:40 -05:00
Corey Farwell
2a486528ee utilize carrier 2018-08-29 07:42:43 -05:00
Corey Farwell
2fa7351c1e suggest wrapping_offset as well 2018-08-29 07:40:00 -05:00
Corey Farwell
61c20c148e if no suggestion, dont add suggestion 2018-08-29 07:12:22 -05:00