Commit graph

7624 commits

Author SHA1 Message Date
Veetaha
64112b0b61 docs: update debugging.md with the freshest VSCode debugging information 2020-02-16 23:00:10 +02:00
Veetaha
43a41819cb docs: remove obsolescence notice in debugging.md 2020-02-16 21:03:24 +02:00
bors[bot]
32fc890de8
Merge #3175
3175: vscode: skip node internals while debugging r=matklad a=Veetaha

Before:
![without-skip-files](https://user-images.githubusercontent.com/36276403/74610221-de9aff00-50f9-11ea-81bb-73dce8ca7acc.gif)
After:
![with-skip-files](https://user-images.githubusercontent.com/36276403/74610222-e22e8600-50f9-11ea-980b-e8d098ee82b4.gif)


Co-authored-by: Veetaha <gerzoh1@gmail.com>
2020-02-16 18:51:51 +00:00
Veetaha
54432c3ae8 vscode: apply lnicolas amendments to comments in launch.json 2020-02-16 20:38:04 +02:00
Veetaha
cc280aba0f vscode: remove extra comment lone 2020-02-16 20:22:27 +02:00
Veetaha
29c7cbb46f vscode: skip node internals while debugging 2020-02-16 20:20:30 +02:00
bors[bot]
3a1c7808a4
Merge #3174
3174:  Added description and disable-extensions r=matklad a=Fihtangolz



Co-authored-by: Dmitry <mamhigtt@gmail.com>
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-16 17:55:04 +00:00
Aleksey Kladov
5b781de56c
Apply suggestions from code review
Co-Authored-By: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-02-16 18:54:32 +01:00
bors[bot]
a90f5b0787
Merge #3173
3173: vscode: fix stupid mistake of mine r=matklad a=Veetaha

Shame on me...
Fixes #3056

Co-authored-by: Veetaha <gerzoh1@gmail.com>
2020-02-16 17:40:23 +00:00
Dmitry
58e15d12e4 Merge remote-tracking branch 'origin/master' 2020-02-17 00:36:48 +07:00
bors[bot]
10f910df4b
Merge #3172
3172: 1-based columns r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-16 17:31:16 +00:00
Aleksey Kladov
ca7e9ab0da 1-based columns 2020-02-16 18:30:48 +01:00
Veetaha
6e22e33d7d vscode: fix stupid mistake 2020-02-16 19:30:13 +02:00
Dmitry
b446384956 Added short description and disable-extensions 2020-02-17 00:28:14 +07:00
Aleksey Kladov
0f79ec76d6 Support goto def in bences 2020-02-16 18:24:06 +01:00
Aleksey Kladov
6a3ec2dfa5 Refactor arg parsing 2020-02-16 18:20:22 +01:00
Aleksey Kladov
2ba918775c Refactor position parsing 2020-02-16 18:17:35 +01:00
bors[bot]
742b3b5744
Merge #3171
3171: Enable profiling for bench r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-16 17:04:39 +00:00
Aleksey Kladov
98cc51580d Enable profiling for bench 2020-02-16 18:04:08 +01:00
bors[bot]
b98967d765
Merge #3170
3170: Add module colors to css r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-16 16:08:36 +00:00
Aleksey Kladov
28fa5edbce Add module colors to css 2020-02-16 17:06:01 +01:00
bors[bot]
004b74d554
Merge #3168
3168: vscode: update exclusiveMinimum validation according to JSONSchemaV4 r=Veetaha a=Veetaha

It seems that vscode uses 4+ version of json schema where `exclusiveMinimum` [was changed to be a boolean](http://json-schema.org/understanding-json-schema/reference/numeric.html#7f93d6925e80_Draft%204)

Co-authored-by: Veetaha <gerzoh1@gmail.com>
2020-02-16 16:01:29 +00:00
Veetaha
56b64cac9c vscode: added minimum bound for lruCapacity option 2020-02-16 18:00:49 +02:00
Veetaha
0565657ed1 vscode: fix all integer -> number and add nullablitiy to maxInlayHintLength 2020-02-16 17:55:15 +02:00
Veetaha
53b5f4ba98 vscode: update exclusiveMinimum validation according to JSONSchemaV4 specs 2020-02-16 16:48:17 +02:00
bors[bot]
77d27c67c1
Merge #3165
3165: Fix coercion of &T to itself r=matklad a=flodiebold

The autoderef coercion logic did not handle matching placeholders. This led to
some type mismatches.

Co-authored-by: Florian Diebold <flodiebold@gmail.com>
2020-02-16 12:03:42 +00:00
Florian Diebold
e14e7ffa34 Fix coercion of &T to itself
The autoderef coercion logic did not handle matching placeholders. This led to
some type mismatches.
2020-02-16 12:58:20 +01:00
bors[bot]
a15c8739b9
Merge #3162
3162: Feature: vscode always downloads only the matching ra_lsp_server version r=matklad a=Veetaha

I tried to separate logically connected changes into separate commits, so enjoy!

Now TypeScript extension saves installed binary version in global state and always checks that the installed binary version equals the version of the TypeScript extension itself (to prevent version drifts).
Also, changed `fetchLatestArtifactReleaseInfo()` to `fetchArtifactReleaseInfo()` that takes an optional release tag (when not specified fetches the latest release). The version without a release tag will be useful in the future when adding auto-checking for updates.

I decided not to do `Download latest language server` command (I have stated the rationale for this in #3073) and let the extension itself decide which version of the binary it wants. This way the users will be able to get the latest `ra_lsp_server` binary after the approaching 2020-02-17 release, without having to manually delete the outdated one from `~/.config/Code/User/globalStorage/matklad.rust-analyzer`!

Closes #3073

Co-authored-by: Veetaha <gerzoh1@gmail.com>
2020-02-16 11:54:38 +00:00
Aleksey Kladov
617b5b3b31
Merge pull request #3161 from Veetaha/feature/cicd-simplify-vsce-call
cicd: simplify vsce call
2020-02-16 11:51:37 +01:00
bors[bot]
35dd04555d
Merge #3163
3163: vscode: fix the default value for withSysroot r=matklad a=Veetaha

See [zulip](https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/withSysroot.20is.20false.20.3F)
cc @edwin0cheng 

Co-authored-by: Veetaha <gerzoh1@gmail.com>
2020-02-16 10:40:56 +00:00
Veetaha
3068aab82d vscode: fix the default value for withSysroot 2020-02-16 11:15:19 +02:00
Veetaha
325eba58a2 vscode: updated user docs vscode updates section 2020-02-16 03:56:54 +02:00
Veetaha
467b925b53 vscode: save binary version when downloading and download only version that matches TypeScript extension version 2020-02-16 03:41:40 +02:00
Veetaha
b9188226fa vscode: extract downloadArtifact() function 2020-02-16 03:41:40 +02:00
Veetaha
0f7abeb035 vscode: add release tag option to fetchArtifactReleaseInfo() 2020-02-16 03:41:40 +02:00
Veetaha
8533fc437b vscode: add version and storage parameters to github binary source 2020-02-16 03:41:39 +02:00
Veetaha
7ff274470e cicd: simplify vsce call 2020-02-16 01:40:07 +02:00
bors[bot]
d976772716
Merge #3157
3157: Extend analysis-stats a bit r=matklad a=flodiebold

This adds some tools helpful when debugging nondeterminism in analysis-stats:
 - a `--randomize` option that analyses everything in random order
 - a `-vv` option that prints even more detail

Also add a debug log if Chalk fuel is exhausted (which would be a source of
nondeterminism, but didn't happen in my tests).

I found one source of nondeterminism (rust-lang/chalk#331), but there are still
other cases remaining.

Co-authored-by: Florian Diebold <flodiebold@gmail.com>
2020-02-15 22:35:44 +00:00
bors[bot]
ff7110f761
Merge #3160
3160: Remove extra dep r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-15 22:25:07 +00:00
Aleksey Kladov
11dda31941 Remove extra dep 2020-02-15 23:23:44 +01:00
bors[bot]
e4054f7e35
Merge #3158
3158: Disable rollup warning r=matklad a=edwin0cheng

In https://rollupjs.org/guide/en/#output-exports

```
As with regular entry points, files that mix default and named exports will produce warnings. You can avoid the warnings by forcing all files to use named export mode via output.exports: "named".
```

This PR try added `output.exports: "named"` and disabe this warning. It is because vscode consume our plugins only by named functions such that it should be saved to disable it.

cc @Veetaha 

Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
2020-02-15 22:14:42 +00:00
Edwin Cheng
cc43f07e11 Disable rollup warning 2020-02-16 05:04:51 +08:00
Florian Diebold
3484d727c3 Extend analysis-stats a bit
This adds some tools helpful when debugging nondeterminism in analysis-stats:
 - a `--randomize` option that analyses everything in random order
 - a `-vv` option that prints even more detail

Also add a debug log if Chalk fuel is exhausted (which would be a source of
nondeterminism, but didn't happen in my tests).

I found one source of nondeterminism (rust-lang/chalk#331), but there are still
other cases remaining.
2020-02-15 18:04:01 +01:00
bors[bot]
58f4dcf79e
Merge #3152
3152: vscode: a couple of more intuitive names and shortening languageServer to langServer r=matklad a=Veetaha

God, naming is so hard. I'd like to extract this change from upcomming "Download latest language server" command PR.

Co-authored-by: Veetaha <gerzoh1@gmail.com>
2020-02-14 23:05:12 +00:00
Veetaha
80d5ba68da vscode: renamed langServer to server 2020-02-15 00:42:32 +02:00
Veetaha
f61134e198 vscode: renmed ArtifactMetadata -> ArtifactReleaseInfo, languageServer -> langServer 2020-02-15 00:15:06 +02:00
bors[bot]
9ba801befd
Merge #3151
3151: xtask: bump nodejs requirement r=matklad a=Veetaha



Co-authored-by: Veetaha <gerzoh1@gmail.com>
2020-02-14 21:25:05 +00:00
Veetaha
c9d83bcacc xtask: bump nodejs requirement while we can! 2020-02-14 23:20:49 +02:00
bors[bot]
3615975001
Merge #3150
3150: Bump crate resolution limit for large projects r=matklad a=benbrittain



Co-authored-by: Benjamin Brittain <bwb@google.com>
2020-02-14 21:17:46 +00:00
Benjamin Brittain
843f03a3d2 Bump crate resolution limit for large projects
Change-Id: Ie0221e5bcfd1779cd5e241f96b4489e5bd3854c1
2020-02-14 16:15:59 -05:00