Commit graph

9724 commits

Author SHA1 Message Date
Aleksey Kladov 27c7ef6d65 Use more natural signature for Edit::apply 2020-05-05 23:23:29 +02:00
Aleksey Kladov 4a6fa8f0df Rename AtomTextEdit -> Indel 2020-05-05 23:15:49 +02:00
Aleksey Kladov 381cbc6088 Minor cleanups 2020-05-05 22:14:01 +02:00
bors[bot] d38741f681
Merge #4327
4327: Refactor assists r=matklad a=matklad



bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-05 19:36:53 +00:00
Aleksey Kladov 3908fad1fe Normalize naming of diagnostics 2020-05-05 21:35:30 +02:00
Aleksey Kladov df00da15c4 Fix compilation 2020-05-05 20:45:44 +02:00
Aleksey Kladov aee22c73c3 Move group_label where it belongs 2020-05-05 20:42:52 +02:00
Aleksey Kladov 6c2414430a use GroupLabel for type safety 2020-05-05 20:34:45 +02:00
Aleksey Kladov d5b9282ede Minor rename 2020-05-05 20:33:10 +02:00
Aleksey Kladov 13c078db9c Flip Assist::new arguments 2020-05-05 20:30:33 +02:00
bors[bot] a4778ddb7a
Merge #4325
4325: Fix column conversion for supplementary plane characters r=matklad a=lnicola

Fixes https://github.com/rust-analyzer/rust-analyzer/pull/4276#issuecomment-623079855.

Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2020-05-05 18:10:39 +00:00
Laurențiu Nicola 1d794e8590 Fix column conversion for supplementary plane characters 2020-05-05 20:30:52 +03:00
bors[bot] 8803e748a6
Merge #4166
4166: Defining a default target to support cross-compilation targets  r=matklad a=FuriouZz

Related to #4163 

Co-authored-by: Christophe MASSOLIN <christophe.massolin@gmail.com>
2020-05-05 17:25:52 +00:00
bors[bot] df7b59081f
Merge #4323
4323: Add tests for #4306 r=kjeremy a=lnicola

CC @kjeremy 

Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2020-05-05 17:01:46 +00:00
Laurențiu Nicola 7ec1b63f81 Add tests for #4306 2020-05-05 19:39:45 +03:00
Christophe MASSOLIN 04e32fbffc Remove code duplicates 2020-05-05 18:23:47 +02:00
bors[bot] f0411ff9e0
Merge #4320
4320: add doctest support r=matklad a=bnjjj

close #4317

preview:

<img width="253" alt="Capture d’écran 2020-05-05 à 17 39 58" src="https://user-images.githubusercontent.com/5719034/81086040-45110b80-8ef8-11ea-9c05-79c6fe400fc3.png">


Co-authored-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2020-05-05 16:22:31 +00:00
Christophe MASSOLIN 14dde99627 Pass cargo.target to rustc 2020-05-05 18:15:13 +02:00
bors[bot] 58f64313fd
Merge #4321
4321: Rename ImplItem to AssocItem r=matklad a=edwin0cheng

Related discussion: https://github.com/rust-analyzer/rust-analyzer/pull/4283#discussion_r419352265

Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
2020-05-05 16:13:57 +00:00
Christophe MASSOLIN 0ab4340cdb Rename defaultTarget to target 2020-05-05 18:01:54 +02:00
Edwin Cheng 92665358cd Rename ImplItem to AssocItem 2020-05-05 23:56:10 +08:00
Benjamin Coenen fe52f8f028 add doctest support #4317
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2020-05-05 17:44:27 +02:00
bors[bot] 756e91732b
Merge #4305
4305: Favor types for record type struct in name resolution r=matklad a=edwin0cheng

Fixed #4235

Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
2020-05-05 15:06:41 +00:00
Edwin Cheng 07de8ea165 invert if 2020-05-05 23:01:07 +08:00
bors[bot] f68e099777
Merge #4265
4265: Make `change_visibility` assist work for tuple struct fields r=matklad a=Jesse-Bakker

Fixes #4206 

Co-authored-by: Jesse Bakker <git@jessebakker.com>
2020-05-05 14:42:33 +00:00
bors[bot] d1c1c01309
Merge #4306 #4308
4306: Make incremental sync opt-out and fix line index rebuild r=matklad a=lnicola



4308: Update server binary paths in docs r=matklad a=Coder-256

Fixed incorrect macOS path and converted to a list. Also, should the Windows path include `matklad.rust-analyzer`? (I can't check)

Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Co-authored-by: Jacob Greenfield <jacob@jacobgreenfield.me>
2020-05-05 10:02:56 +00:00
bors[bot] a76d392fe9
Merge #4307
4307: [manual] Improve requirements and editor wording r=matklad a=oblitum



Co-authored-by: Francisco Lopes <francisco+github@nosubstance.me>
2020-05-05 09:55:27 +00:00
bors[bot] 87af7c9bd7
Merge #4313
4313: refactor: use attrsOwner directly in is_cfg_enabled r=edwin0cheng a=bnjjj

As promised @edwin0cheng here is the PR to resolve the comment [here](https://github.com/rust-analyzer/rust-analyzer/pull/4285#discussion_r419200375).

Co-authored-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2020-05-05 08:24:27 +00:00
Benjamin Coenen 831bb1cf91 refactor: use attrsOwner directly in is_cfg_enabled
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2020-05-05 09:34:07 +02:00
Edwin Cheng cf821cc332 Change union resolve types only 2020-05-05 01:19:54 +08:00
Jacob Greenfield bcc1717378
Update server binary paths
Fixed macOS path and converted to a list
2020-05-04 13:16:29 -04:00
Edwin Cheng e921195d93 Change favor_types to has_constructor 2020-05-05 01:15:27 +08:00
Francisco Lopes 18ba86b1c5
[manual] Improve requirements and editor wording 2020-05-04 14:12:32 -03:00
Laurențiu Nicola 7c1d5f286a Fix line index rebuild during incremental changes 2020-05-04 20:04:30 +03:00
Laurențiu Nicola 191abf3685 Make incremental sync opt-out 2020-05-04 19:54:39 +03:00
Edwin Cheng 5ae18f4f81 Remove unused import 2020-05-05 00:34:54 +08:00
Edwin Cheng 204c8de3bf Add test for issue 2020-05-05 00:29:47 +08:00
Edwin Cheng af001677d1 Fix test 2020-05-05 00:17:30 +08:00
Edwin Cheng 8d96db3417 Favor types for Record in name resolution 2020-05-05 00:17:22 +08:00
bors[bot] 15de338703
Merge #4303
4303: Remove false positive attr compleitons r=matklad a=matklad



bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-04 14:52:35 +00:00
Aleksey Kladov b211c5814e Remove false positive attr compleitons 2020-05-04 16:48:50 +02:00
bors[bot] a1ccd09d4b
Merge #4301
4301: Fix typo in markdownDescription r=matklad a=szunami



Co-authored-by: szunami <sam.szuflita@gmail.com>
2020-05-04 14:44:41 +00:00
szunami 7330b8da63
Fix typo in markdownDescription 2020-05-04 10:27:59 -04:00
bors[bot] a559459fb0
Merge #4300
4300: Cleanup attribute completion r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-04 13:38:55 +00:00
Aleksey Kladov 8f4478390e Qualify ast types 2020-05-04 15:33:08 +02:00
Aleksey Kladov e9643ab74c Cleanup imports 2020-05-04 15:33:08 +02:00
Aleksey Kladov 71f6d58e31 Remove unnecessary condition
No tests fail, and quick manual testing shows that there are no
false-positives. In general, each completion contributor should be
independent from the others.
2020-05-04 15:32:23 +02:00
bors[bot] ea098fdbd2
Merge #4299
4299: Simplify r=matklad a=matklad



bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-05-04 12:55:48 +00:00
Aleksey Kladov d7450222a9 Simplify 2020-05-04 14:55:24 +02:00
bors[bot] 580c5a969d
Merge #4297
4297: refactor: use parent instead ancestors for use alias r=matklad a=bnjjj

Linked to this comment https://github.com/rust-analyzer/rust-analyzer/pull/4269/files#r419343670

Co-authored-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2020-05-04 12:37:41 +00:00