squiid/llvm
1
0
Fork 0
Code Issues Pull requests Activity

[Windows] Turn off text mode correctly in Rewriter to stop CRLF translation

Browse source 
I incorrectly changed the RewriteTestAction::ExecuteAction's file to binary instead of the proper RewriteIncludesAction::BeginSourceFileAction in https://reviews.llvm.org/rGbc5d4bcc2deb71ab647270c9754a83484b3d6f87. In the original commit, I actually changed RewriteIncludesAction::BeginSourceFileAction in https://reviews.llvm.org/rGfdb640ea30d416368b76b68b106deda580c6aced. This should fix the issue @aganea is facing.

Reviewed By: aganea

Differential Revision: https://reviews.llvm.org/D99837
This commit is contained in:
Abhina Sreeskantharajan 2021-04-06 10:48:40 -04:00
parent fb6a5237aa
commit 23929af383
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
clang/lib/Frontend/Rewrite/FrontendActions.cpp
View file

@ -194,7 +194,7 @@ void RewriteMacrosAction::ExecuteAction() {
void RewriteTestAction::ExecuteAction() {
CompilerInstance &CI = getCompilerInstance();
std::unique_ptr<raw_ostream> OS =
CI.createDefaultOutputFile(/*Binary=*/true, getCurrentFileOrBufferName());
CI.createDefaultOutputFile(/*Binary=*/false, getCurrentFileOrBufferName());
if (!OS) return;
DoRewriteTest(CI.getPreprocessor(), OS.get());
@ -270,7 +270,7 @@ public:
bool RewriteIncludesAction::BeginSourceFileAction(CompilerInstance &CI) {
if (!OutputStream) {
OutputStream =
CI.createDefaultOutputFile(/*Binary=*/false, getCurrentFileOrBufferName());
CI.createDefaultOutputFile(/*Binary=*/true, getCurrentFileOrBufferName());
if (!OutputStream)
return false;
}