From 23929af383f27a6ddf23704192a25591481152b3 Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Tue, 6 Apr 2021 10:48:40 -0400 Subject: [PATCH] [Windows] Turn off text mode correctly in Rewriter to stop CRLF translation I incorrectly changed the RewriteTestAction::ExecuteAction's file to binary instead of the proper RewriteIncludesAction::BeginSourceFileAction in https://reviews.llvm.org/rGbc5d4bcc2deb71ab647270c9754a83484b3d6f87. In the original commit, I actually changed RewriteIncludesAction::BeginSourceFileAction in https://reviews.llvm.org/rGfdb640ea30d416368b76b68b106deda580c6aced. This should fix the issue @aganea is facing. Reviewed By: aganea Differential Revision: https://reviews.llvm.org/D99837 --- clang/lib/Frontend/Rewrite/FrontendActions.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clang/lib/Frontend/Rewrite/FrontendActions.cpp b/clang/lib/Frontend/Rewrite/FrontendActions.cpp index 45960068220b..09ed07be923e 100644 --- a/clang/lib/Frontend/Rewrite/FrontendActions.cpp +++ b/clang/lib/Frontend/Rewrite/FrontendActions.cpp @@ -194,7 +194,7 @@ void RewriteMacrosAction::ExecuteAction() { void RewriteTestAction::ExecuteAction() { CompilerInstance &CI = getCompilerInstance(); std::unique_ptr OS = - CI.createDefaultOutputFile(/*Binary=*/true, getCurrentFileOrBufferName()); + CI.createDefaultOutputFile(/*Binary=*/false, getCurrentFileOrBufferName()); if (!OS) return; DoRewriteTest(CI.getPreprocessor(), OS.get()); @@ -270,7 +270,7 @@ public: bool RewriteIncludesAction::BeginSourceFileAction(CompilerInstance &CI) { if (!OutputStream) { OutputStream = - CI.createDefaultOutputFile(/*Binary=*/false, getCurrentFileOrBufferName()); + CI.createDefaultOutputFile(/*Binary=*/true, getCurrentFileOrBufferName()); if (!OutputStream) return false; }