rust/compiler
Preston From d0ea440dfe Improve position named arguments lint underline and formatting names
For named arguments used as implicit position arguments, underline both
the opening curly brace and either:
* if there is formatting, the next character (which will either be the
  closing curl brace or the `:` denoting the start of formatting args)
* if there is no formatting, the entire arg span (important if there is
  whitespace like `{  }`)

This should make it more obvious where the named argument should be.

Additionally, in the lint message, emit the formatting argument names
without a dollar sign to avoid potentially confusion.

Fixes #99907
2022-08-02 00:20:44 -06:00
..
rustc Don't rerun the build script for the compiler each time on linux 2022-07-10 23:57:25 -05:00
rustc_apfloat
rustc_arena Rollup merge of #97711 - Nilstrieb:rustc-arena-ub, r=wesleywiser 2022-07-07 18:06:49 +05:30
rustc_ast Auto merge of #100024 - matthiaskrgr:rollup-36ab4wx, r=matthiaskrgr 2022-08-01 15:40:43 +00:00
rustc_ast_lowering Store associated item defaultness in impl_defaultness. 2022-08-01 21:38:16 +02:00
rustc_ast_passes Remove visit_name from the AST visitor. 2022-07-29 15:28:32 +10:00
rustc_ast_pretty Remove TreeAndSpacing. 2022-07-29 15:52:15 +10:00
rustc_attr avoid embedding StabilityLevel::Unstable reason string into metadata multiple times 2022-07-21 22:53:02 +03:00
rustc_borrowck Improve cannot move out of error message 2022-07-31 21:06:43 +03:00
rustc_builtin_macros Improve position named arguments lint underline and formatting names 2022-08-02 00:20:44 -06:00
rustc_codegen_cranelift Introduce an ArchiveBuilderBuilder 2022-07-28 09:08:47 +00:00
rustc_codegen_gcc Introduce an ArchiveBuilderBuilder 2022-07-28 09:08:47 +00:00
rustc_codegen_llvm Rollup merge of #99844 - bjorn3:archive_builder_interface_refactor, r=nagisa 2022-07-31 17:36:42 +05:30
rustc_codegen_ssa Auto merge of #99944 - bjorn3:hide_proc_macro_symbols, r=eddyb 2022-08-01 03:58:52 +00:00
rustc_const_eval Remove trait_of_item query. 2022-08-01 21:39:26 +02:00
rustc_data_structures remove some manual hash stable impls 2022-07-29 12:48:28 +02:00
rustc_driver Rename local_did to def_id 2022-07-29 18:26:10 -04:00
rustc_error_codes region_outlives_predicate no snapshot 2022-07-21 13:09:01 +02:00
rustc_error_messages lint: add bad opt access internal lint 2022-07-27 11:24:27 +01:00
rustc_errors Auto merge of #99058 - michaelwoerister:remove-stable-set-and-map, r=nagisa 2022-07-20 22:19:30 +00:00
rustc_expand Auto merge of #99887 - nnethercote:rm-TreeAndSpacing, r=petrochenkov 2022-07-30 14:50:05 +00:00
rustc_feature lint: add bad opt access internal lint 2022-07-27 11:24:27 +01:00
rustc_fs_util
rustc_graphviz
rustc_hir Match on TraitItem exhaustively. 2022-08-01 21:39:59 +02:00
rustc_hir_pretty use rustc_hir_pretty::qpath_to_string to avoid span_to_snippet when rendering path 2022-07-17 04:58:38 +00:00
rustc_incremental Remove trait_of_item query. 2022-08-01 21:39:26 +02:00
rustc_index Auto merge of #99052 - tmiasko:bitset-clone-from, r=Mark-Simulacrum 2022-07-31 21:40:21 +00:00
rustc_infer Remove DefId from AssocItemContainer. 2022-08-01 21:38:45 +02:00
rustc_interface Rollup merge of #99519 - Urgau:check-cfg-implicit, r=petrochenkov 2022-07-31 23:39:38 +02:00
rustc_lexer Shrink Token. 2022-08-01 08:53:04 +10:00
rustc_lint Improve position named arguments lint underline and formatting names 2022-08-02 00:20:44 -06:00
rustc_lint_defs Improve position named arguments lint underline and formatting names 2022-08-02 00:20:44 -06:00
rustc_llvm Also gate AllocatedPointer and AllocAlign definitions by LLVM_VERSION_GE 2022-07-30 18:53:51 +02:00
rustc_log
rustc_macros clippy::perf fixes 2022-07-20 11:48:11 +02:00
rustc_metadata Auto merge of #95884 - cjgillot:assoc-item, r=lcnr 2022-08-01 21:43:35 +00:00
rustc_middle Remove trait_of_item query. 2022-08-01 21:39:26 +02:00
rustc_mir_build Remove trait_of_item query. 2022-08-01 21:39:26 +02:00
rustc_mir_dataflow Auto merge of #99667 - ouz-a:some_branch, r=oli-obk 2022-07-29 07:11:50 +00:00
rustc_mir_transform Rollup merge of #99186 - camsteffen:closure-localdefid, r=cjgillot 2022-07-31 17:36:40 +05:30
rustc_monomorphize Use LocalDefId for closures more 2022-07-30 15:59:17 -05:00
rustc_parse Shrink Token. 2022-08-01 08:53:04 +10:00
rustc_parse_format Generate correct suggestion with named arguments used positionally 2022-07-25 00:00:27 -06:00
rustc_passes Remove trait_of_item query. 2022-08-01 21:39:26 +02:00
rustc_plugin_impl
rustc_privacy Remove DefId from AssocItemContainer. 2022-08-01 21:38:45 +02:00
rustc_query_impl Use LocalDefId for closures more 2022-07-30 15:59:17 -05:00
rustc_query_system Remove useless closure. 2022-07-29 22:11:23 +02:00
rustc_resolve Remove guess_head_span. 2022-07-28 23:14:04 +02:00
rustc_save_analysis Remove DefId from AssocItemContainer. 2022-08-01 21:38:45 +02:00
rustc_serialize Upgrade indexmap and thorin-dwp to use hashbrown 0.12 2022-07-17 07:05:58 -07:00
rustc_session Rollup merge of #99620 - hudson-ayers:fix-location-detail, r=davidtwco 2022-07-31 23:39:40 +02:00
rustc_smir
rustc_span Use line numbers relative to function in mir opt tests 2022-07-28 11:59:54 +02:00
rustc_symbol_mangling Auto merge of #95548 - rcvalle:rust-cfi-2, r=nagisa 2022-07-24 01:22:36 +00:00
rustc_target Auto merge of #99476 - dpaoliello:rawdylibvectorcall, r=michaelwoerister 2022-08-01 18:43:57 +00:00
rustc_trait_selection Remove trait_of_item query. 2022-08-01 21:39:26 +02:00
rustc_traits Remove DefId from AssocItemContainer. 2022-08-01 21:38:45 +02:00
rustc_ty_utils Remove trait_of_item query. 2022-08-01 21:39:26 +02:00
rustc_type_ir Inline DebruijnIndex methods 2022-07-22 17:00:49 +02:00
rustc_typeck Remove DefId from AssocItemContainer. 2022-08-01 21:38:45 +02:00