rust/compiler/rustc_mir_build at b15cb29a4a0625afeac07fbf3ab02b63c51ad317 - squiid/rust

History

Aaron Hill cac431ba75 Store a `DefId` instead of an `AdtDef` in `AggregateKind::Adt` The `AggregateKind` enum ends up in the final mir `Body`. Currently, any changes to `AdtDef` (regardless of how significant they are) will legitimately cause the overall result of `optimized_mir` to change, invalidating any codegen re-use involving that mir. This will get worse once we start hashing the `Span` inside `FieldDef` (which is itself contained in `AdtDef`). To try to reduce these kinds of invalidations, this commit changes `AggregateKind::Adt` to store just the `DefId`, instead of the full `AdtDef`. This allows the result of `optimized_mir` to be unchanged if the `AdtDef` changes in a way that doesn't actually affect any of the MIR we build.	2021-12-22 14:36:34 -05:00
..
src	Store a `DefId` instead of an `AdtDef` in `AggregateKind::Adt`	2021-12-22 14:36:34 -05:00
Cargo.toml	Migrate to 2021	2021-09-20 22:21:42 -04:00

Store a DefId instead of an AdtDef in AggregateKind::Adt

The `AggregateKind` enum ends up in the final mir `Body`. Currently,
any changes to `AdtDef` (regardless of how significant they are)
will legitimately cause the overall result of `optimized_mir` to change,
invalidating any codegen re-use involving that mir.

This will get worse once we start hashing the `Span` inside `FieldDef`
(which is itself contained in `AdtDef`).

To try to reduce these kinds of invalidations, this commit changes
`AggregateKind::Adt` to store just the `DefId`, instead of the full
`AdtDef`. This allows the result of `optimized_mir` to be unchanged
if the `AdtDef` changes in a way that doesn't actually affect any
of the MIR we build.

2021-12-22 14:36:34 -05:00

src Store a DefId instead of an AdtDef in AggregateKind::Adt 2021-12-22 14:36:34 -05:00

Cargo.toml Migrate to 2021 2021-09-20 22:21:42 -04:00