rust/compiler
Manish Goregaokar 9593e61f64
Rollup merge of #88838 - FabianWolff:issue-88472, r=estebank
Do not suggest importing inaccessible items

Fixes #88472. For this example:
```rust
mod a {
    struct Foo;
}

mod b {
    type Bar = Foo;
}
```
rustc currently emits:
```
error[E0412]: cannot find type `Foo` in this scope
 --> test.rs:6:16
  |
6 |     type Bar = Foo;
  |                ^^^ not found in this scope
  |
help: consider importing this struct
  |
6 |     use a::Foo;
  |
```
this is incorrect, as applying this suggestion leads to
```
error[E0603]: struct `Foo` is private
 --> test.rs:6:12
  |
6 |     use a::Foo;
  |            ^^^ private struct
  |
note: the struct `Foo` is defined here
 --> test.rs:2:5
  |
2 |     struct Foo;
  |     ^^^^^^^^^^^
```
With my changes, I get:
```
error[E0412]: cannot find type `Foo` in this scope
 --> test.rs:6:16
  |
6 |     type Bar = Foo;
  |                ^^^ not found in this scope
  |
  = note: this struct exists but is inaccessible:
          a::Foo
```
As for the wildcard mentioned in #88472, I would argue that the warning is actually correct, since the import _is_ unused. I think the real issue is the wrong suggestion, which I have fixed here.
2021-09-30 23:41:05 -07:00
..
rustc
rustc_apfloat
rustc_arena
rustc_ast
rustc_ast_lowering
rustc_ast_passes
rustc_ast_pretty
rustc_attr
rustc_borrowck Auto merge of #87998 - nneonneo:master, r=oli-obk 2021-09-30 13:23:09 +00:00
rustc_builtin_macros derive: Do not configure or clone items unless necessary 2021-09-24 21:45:51 +03:00
rustc_codegen_cranelift Update compiler/rustc_codegen_cranelift/scripts/filter_profile.rs 2021-09-30 19:41:32 +02:00
rustc_codegen_gcc Rebase fallout. 2021-09-30 20:22:42 +02:00
rustc_codegen_llvm Move EncodedMetadata to rustc_metadata. 2021-09-30 19:41:32 +02:00
rustc_codegen_ssa Move EncodedMetadata to rustc_metadata. 2021-09-30 19:41:32 +02:00
rustc_const_eval CTFE: extra assertions for Aggregate rvalues; remove unnecessarily eager special case 2021-09-29 13:47:41 -04:00
rustc_data_structures More tracing instrumentation 2021-09-28 12:28:22 +00:00
rustc_driver
rustc_error_codes
rustc_errors
rustc_expand Improve help for recursion limit errors 2021-09-28 22:17:13 +02:00
rustc_feature Stabilize feature(macro_attributes_in_derive_output) 2021-09-24 21:48:30 +03:00
rustc_fs_util
rustc_graphviz
rustc_hir Rollup merge of #88782 - asquared31415:issue-79559, r=cjgillot 2021-09-30 18:05:20 -07:00
rustc_hir_pretty
rustc_incremental
rustc_index
rustc_infer More tracing instrumentation 2021-09-28 12:28:22 +00:00
rustc_interface Move EncodedMetadata to rustc_metadata. 2021-09-30 19:41:32 +02:00
rustc_lexer
rustc_lint rustc_session: Remove lint store from Session 2021-09-28 11:56:15 +03:00
rustc_lint_defs
rustc_llvm PassWrapper: handle function rename from upstream D36850 2021-09-27 18:11:21 -04:00
rustc_macros
rustc_metadata Move EncodedMetadata to rustc_metadata. 2021-09-30 19:41:32 +02:00
rustc_middle Move EncodedMetadata to rustc_metadata. 2021-09-30 19:41:32 +02:00
rustc_mir_build Rollup merge of #89314 - notriddle:notriddle/lint-fix-enum-variant-match, r=davidtwco 2021-09-30 18:05:25 -07:00
rustc_mir_dataflow More tracing instrumentation 2021-09-28 12:28:22 +00:00
rustc_mir_transform Auto merge of #89030 - nbdd0121:box2, r=jonas-schievink 2021-09-25 11:01:13 +00:00
rustc_monomorphize
rustc_parse Check for macros in built-in attributes that don't support them. 2021-09-25 09:03:15 -07:00
rustc_parse_format
rustc_passes
rustc_plugin_impl
rustc_privacy
rustc_query_impl Auto merge of #89120 - In-line:remove_unneded_visible_parents_map, r=estebank 2021-09-24 05:29:49 +00:00
rustc_query_system
rustc_resolve Rollup merge of #88838 - FabianWolff:issue-88472, r=estebank 2021-09-30 23:41:05 -07:00
rustc_save_analysis
rustc_serialize
rustc_session rustc_session: Remove lint store from Session 2021-09-28 11:56:15 +03:00
rustc_span Rollup merge of #89072 - bjorn3:less_symbol_as_str, r=michaelwoerister 2021-09-24 11:40:12 -07:00
rustc_symbol_mangling
rustc_target Add SOLID targets 2021-09-28 11:31:47 +09:00
rustc_trait_selection Improve help for recursion limit errors 2021-09-28 22:17:13 +02:00
rustc_traits Improve cause information for NLL higher-ranked errors 2021-09-27 10:23:45 -05:00
rustc_ty_utils Auto merge of #89144 - sexxi-goose:insig_stdlib, r=nikomatsakis 2021-09-26 19:36:00 +00:00
rustc_type_ir
rustc_typeck Rollup merge of #89202 - estebank:infer-call-type, r=oli-obk 2021-09-30 18:05:21 -07:00