Commit graph

2539 commits

Author SHA1 Message Date
Mrmaxmeier 89f0f323bb Rustup to 1.18.0-nightly (d5cf1cb64 2017-04-15) 2017-04-16 18:38:17 +02:00
Yati Sagade cac15d24f9 needless_continue: Remove indentation of suggestion code.
As per a suggestion by Oliver on the PR thread, maintaining indentation
in the suggested code is futile because of the changes in the compiler
and the messiness of real-world code. rustfmt will do the indentation if
required, so we don't need to do it.
2017-04-13 21:48:52 +02:00
Oliver Schneider 5842463562 Run rustfmt 2017-04-12 11:06:32 +02:00
Oliver Schneider 81401ddc8c
Bump the version 2017-04-12 10:57:02 +02:00
Oliver Schneider 7ee0d4f9c2 Dogfood tests 2017-04-12 10:55:34 +02:00
Oliver Schneider 7f89fb7a20 Merge pull request #1672 from Manishearth/lifetime_sugg
Fix various false positives around needless_lifetime
2017-04-12 10:37:57 +02:00
Oliver Schneider 3534149035 Update ui tests 2017-04-11 16:19:27 +02:00
Oliver Schneider 679e98530a
Merge remote-tracking branch 'origin/master' into yati 2017-04-11 16:16:10 +02:00
Oliver Schneider 5f85ea8ef4 Add newline at end of file 2017-04-11 15:54:48 +02:00
Oliver Schneider 21d8fbd082 Don't lint for lifetime bounds required by traits 2017-04-11 15:44:13 +02:00
Oliver Schneider 856b1f1242 Remove now useless allow(unused_lifetimes) from clippy 2017-04-11 14:46:54 +02:00
Oliver Schneider fae1e646ee Remove useless warning 2017-04-11 14:34:39 +02:00
Oliver Schneider 2eae102cd1 Don't lint lifetimes after trait objects 2017-04-11 14:29:58 +02:00
Oliver Schneider 8bb0a4d667 Fix more doc issues 2017-04-11 14:10:11 +02:00
Oliver Schneider 9a4c0a1c72 Don't lint about unused lifetimes if the lifetimes are used in the body of the function 2017-04-11 14:09:58 +02:00
Oliver Schneider 5ae57c55fd Merge pull request #1671 from Manishearth/eq_op
Fix op_ref false positives
2017-04-10 16:45:32 +02:00
Oliver Schneider 7b6111677a Latest nightly produces more ellipses in output 2017-04-10 15:36:07 +02:00
Oliver Schneider 38b2215060 Dogfood 2017-04-10 15:14:54 +02:00
Oliver Schneider 03a0b18a85 Fix some doc errors 2017-04-10 15:10:29 +02:00
Oliver Schneider b76ce176bb Fix op_ref in case of nonexisting operations 2017-04-10 15:10:19 +02:00
Yati Sagade 62548f447c needless_continue: Add ui test
The test program contains both conditions tested by the lint, i.e.,
a redundant continue in the `if` and `else` blocks within a loop. Maybe
splitting them out and also having a program that should *not* trigger
the lint warning is better.
2017-04-09 14:20:14 +02:00
Yati Sagade 69928906f4 needless_continue: Add tests for helper functions to the needless_continue lint.
Creating a test file per function sounds a bit excessive, so just
clubbing all needless_continue specific function tests into this module.
2017-04-09 14:12:01 +02:00
Yati Sagade a099748113 utils: Add tests for the align_blocks helper in utils. 2017-04-09 14:09:54 +02:00
Yati Sagade 8ea6d6a8d2 needless_continue: Refactor to use stuff from utils, and move some stuff to utils.
I had my own implementation of what `trim_multiline()` seems to be doing, so
I just started using `trim_multiline()`. Some other functions, like
those block alignment, are general enough to be used elsewhere, so moved
them to utils.
2017-04-09 14:07:11 +02:00
Yati Sagade 1ee34e7851 Run update_lints.py 2017-04-08 23:31:23 +02:00
Yati Sagade 38238f576d [needless_continue] Add comments explaining terminology used thoughout in the code. 2017-04-08 23:30:34 +02:00
Yati Sagade 9396120008 More dogfood test fixes. 2017-04-08 23:30:34 +02:00
Yati Sagade 7b4a12fd21 Fix lint warnings from dogfooding tests. 2017-04-08 23:30:34 +02:00
Yati Sagade 240471f926 Needless continue: This is a complete rewrite of this lint as an early-pass lint.
The previous version had troubles computing suggestions without macro expansions
creeping in. This fixes it by using original_sp, which works on AST nodes.
2017-04-08 23:30:34 +02:00
Oliver Schneider 0432f1efd3 Add wiki updating to publish steps 2017-04-07 16:42:08 +02:00
Oliver Schneider c657d603ba
Bump the version 2017-04-07 11:25:00 +02:00
Oliver Schneider f1e905f620 Reintroduce #768 so we can publish 2017-04-07 11:21:39 +02:00
Oliver Schneider 3052000c73 Merge pull request #1649 from ensch/master
Fix for rustc 1.18.0-nightly (5c94997b6 2017-03-30)
2017-04-07 11:13:44 +02:00
Oliver Schneider 13408e2ac8 Enable rls on this repo 2017-04-06 16:49:25 +02:00
Oliver Schneider a679f41fa3 Fix fallout 2017-04-06 16:49:13 +02:00
Oliver Schneider f32fab1c8f panic!("{}") lint is broken 2017-04-06 16:49:03 +02:00
Oliver Schneider 6d921b4734 fix various rustup failures 2017-04-06 16:48:48 +02:00
Martin Carton 60f4863cbe Merge pull request #1652 from pgerber/with
correct message for `option_map_unwrap_or_else` lint
2017-04-02 00:54:40 +02:00
Peter Gerber 71a788cbd7 correct error message for option_map_unwrap_or_else lint
Remove erroneous "with " in suggested alternative call.
2017-04-01 15:54:27 +02:00
Enrico Schmitz 7c94a62048 Reenable mut_mut_macro.rs test 2017-04-01 00:25:23 +02:00
Enrico Schmitz 7a4f7c335b Remove unused cs parameter for is_macro and friends 2017-04-01 00:14:04 +02:00
Enrico Schmitz 8aef64dfe8 Fix src/needless_bool.rs by using ExprBlock(block) = then 2017-03-31 23:46:08 +02:00
Enrico Schmitz 8297c19fcc Fixing src/copies.rs and src/entries.rs by using ExprBlock(block) = then.node 2017-03-31 23:36:45 +02:00
Enrico Schmitz 8f9fb97eb6 First try for a fix for rustc 1.18.0-nightly (5c94997b6 2017-03-30 2017-03-31 19:23:35 +02:00
Oliver Schneider 9c3c938761 Merge pull request #1613 from Manishearth/dont_ref_operator_args
Dont ref operator args
2017-03-30 11:16:20 +02:00
Oliver Schneider 0ae1a77a2e Do some additional cleanup around InternedString and Symbol 2017-03-30 10:21:13 +02:00
Oliver Schneider d9e69a70df
Fix fallout 2017-03-30 09:46:04 +02:00
Oliver Schneider 5de367f793
Don't create additional references when invoking binary operators 2017-03-30 09:46:00 +02:00
Martin Carton 813daf236f Merge pull request #1640 from Manishearth/multiple_matching_crates
Remove some legacy code
2017-03-27 19:47:45 +02:00
Oliver Schneider 8f88ead7d6 Remove some legacy code 2017-03-27 14:51:37 +02:00