squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity
3630 commits 1 branch 0 tags 1.1 GiB
Commit graph

525 commits

Author SHA1 Message Date
Oliver Schneider
eafb9fe8df
Update test suite 2018-03-28 23:49:32 +02:00
Oliver Schneider
d6344c47e3
Categorize all the lints! 2018-03-28 15:24:26 +02:00
Oliver Schneider
b6e2c47df0
Merge pull request #2572 from flip1995/immut_while 
Fix check of immutable condition in closure
 2018-03-27 07:07:27 +02:00
Michael Wright
546d2fec29 Fix enum_glob_use false positives 
Closes #2397.

This checks the def of the `ItemUse` path instead of checking the
capitalization of the path segements. It was noted that this def would
sometimes be `Def::Mod` instead of `Def::Enum` but it seems correct now.
 2018-03-27 06:34:11 +02:00
flip1995
7d29075132
Skip the mutation in while body case for closures 2018-03-27 02:13:06 +02:00
flip1995
d458f22d89
Fix check of immutable condition in closure 2018-03-27 01:21:25 +02:00
Oliver Schneider
b01b0083ba
Merge pull request #2576 from kimsnj/infinite_loop 
while_immutable_condition: fix handling of self
 2018-03-27 00:06:16 +02:00
Karim Snj
737247e50e while_immutable_condition: limit suggestion span to condition 2018-03-26 23:24:57 +02:00
Karim Snj
85bcaad412 while_immutable_condition: fix handling of self 2018-03-26 23:16:54 +02:00
Philipp Hansch
034c81b761
Fix false positive in empty_line_after_outer_attribute 
`empty_line_after_outer_attribute` produced a false positive warning when
deriving `Copy` and/or `Clone` for an item.

It looks like the second point in [this comment][that_comment] is related,
as the attribute that causes the false positive has a path of
`rustc_copy_clone_marker`.

Fixes #2475

[that_comment]: https://github.com/rust-lang/rust/issues/35900#issuecomment-245978831
 2018-03-26 21:57:42 +02:00
Oliver Schneider
9fb63d5fc4
Merge pull request #2574 from mark-i-m/i128 
i128 is stabilizing
 2018-03-26 07:04:42 +02:00
Mark Mansi
e9f6a7c72f whitespace 2018-03-25 21:26:10 -05:00
Mark Mansi
e2d7ef9972 attempt fix stderr 2018-03-25 21:17:38 -05:00
Mark Mansi
f25d4fd253 make it pass for now 2018-03-25 21:04:05 -05:00
Mark Mansi
748ad9fb4b i128 is stable 2018-03-25 20:34:44 -05:00
Michael Wright
2b68f00722 Add tests to ensure that issue #2420 is resolved 
The issue was probably fixed by ff32d5f7. Closes #2420.
 2018-03-23 20:26:52 +02:00
Oliver Schneider
2d01f42dde
Merge pull request #2539 from Baelyk/master 
Add suggestion to useless_format
 2018-03-20 08:22:04 +01:00
Baelyk
48027105dc Add suggestion to useless_format 
Resolves #2505

Suggests that you use `"foo".to_string()` instead of `format!("foo")`.
 2018-03-19 09:27:15 -05:00
flip1995
ad459184a3 Don't lint comparison operators in arithmetic impls 2018-03-17 22:02:34 +01:00
Oliver Schneider
8749927973
Rustup 2018-03-16 09:44:20 +01:00
Mateusz Mikuła
3662ee76ab Merge branch 'miri' 2018-03-15 10:49:13 +01:00
Mateusz Mikuła
ca785afc31 Update tests 
Signed-off-by: Mateusz Mikuła <mati865@gmail.com>
 2018-03-15 10:25:57 +01:00
Oliver Schneider
21f387d278
Update dependencies 2018-03-13 16:54:13 +01:00
Oliver Schneider
f7b2578aea
Update to rustc master 2018-03-13 11:38:21 +01:00
Hidehito Yabuuchi
ed769a3bc4 Ignore all macros in redundant_field_names 2018-03-11 13:57:28 +09:00
Karim Snj
ae5354e6ef lint: while immutable condition: do not lint constants 2018-03-07 18:25:09 +01:00
Oliver Schneider
4cf02c7e1a
Merge pull request #2483 from kimsnj/infinite_loop 
immutable while condition
 2018-03-07 08:09:48 +01:00
Karim Snj
814827113e lint: immutable condition: add internally mutable test 2018-03-06 18:27:11 +01:00
Oliver Schneider
7d5ecd5ad5
Merge pull request #2511 from flip1995/sus_impl 
UnNeg and UnNot count as additional operations now
 2018-03-06 14:35:54 +01:00
Niklas Fiekas
d55890a2b1 Increase unreadable_literal digits (fixes #1958) 2018-03-06 14:24:01 +01:00
flip1995
ed4535641b
UnNeg and UnNot count as additional operations now 2018-03-06 13:58:03 +01:00
Oliver Schneider
05f92b84c9
Merge pull request #2507 from ordovicia/redundant_field_names_range 
Don't lint range syntax with var name `start` and/or `end`
 2018-03-05 09:41:00 +01:00
Oliver Schneider
40ebff8c7a
Merge pull request #2493 from bootandy/fix_cow 
Lint passing Cow by reference
 2018-03-05 09:35:11 +01:00
Hidehito Yabuuchi
cdb60c6547 Make redundant_field_name not care range expressions 
Hand-written `Range` struct family are treated normally.
 2018-03-05 17:30:07 +09:00
Oliver Schneider
598acba7d5
Merge pull request #2497 from waywardmonkeys/single-char-pattern 
Fix single_char_pattern for \n, \t, etc.
 2018-03-05 08:43:17 +01:00
Oliver Schneider
6662aa41f9
Merge branch 'master' into fix_cow 2018-03-05 08:42:19 +01:00
Oliver Schneider
f071d1994f
Merge pull request #2504 from flip1995/lit_float_repr 
Fix unreadable_literal lint for scientific float notation
 2018-03-05 08:38:32 +01:00
Oliver Schneider
5b48b03375
Typo 2018-03-05 08:33:37 +01:00
Hidehito Yabuuchi
7b59557dcd Don't lint range syntax with var name start and end 2018-03-05 14:31:37 +09:00
HMPerson1
3045f432c7
Fix #2496 2018-03-04 22:56:03 -05:00
flip1995
86ce897084
Fix unreadable_literal lint for scientific float notation 2018-03-04 16:28:34 +01:00
bootandy
e3c13da830 Change recomendation to: &[type] from Cow<type> 2018-03-03 12:25:20 -05:00
Alex Butler
fc5b377cec Fix #2494 add suggestion for unreadable_literal 
Add `rustc --explain E0308` line to relevant tests
 2018-03-03 12:25:20 -05:00
Bruce Mitchener
769a1d9b6c Fix single_char_pattern for \n, \t, etc. 
Single characters that are escaped weren't being searched / replaced
correctly in the hint string, so it was saying to replace, say,
`"\n"` with `"\n"` rather than `'\n'`.
 2018-03-02 22:00:01 +07:00
Karim Snj
7d35fab304 lint: while loop: detect if no var from the condition is mutated 2018-03-02 00:01:08 +01:00
Karim Snj
37eca59438 lint: while immutable condition: refactor to use hir::Visitor 2018-03-01 22:00:43 +01:00
Alex Butler
42000c6cf9
Fix #2494 add suggestion for unreadable_literal 
Add `rustc --explain E0308` line to relevant tests
 2018-03-01 15:26:39 +00:00
bootandy
9a002e52e5 Lint passing Cow by reference 
Add lint for reference to Cow to the same place in the code where
lint for reference to String lives.

https://github.com/rust-lang-nursery/rust-clippy/issues/2405
 2018-02-28 10:24:10 -05:00
Karim Snj
5c1be4a4ba lint: immutable only vars in while condition 2018-02-25 18:25:31 +01:00
Guillem Nieto
8494f57c82 Fix author lint 
The author lint was generating invalid code as shown on issue:
https://github.com/rust-lang-nursery/rust-clippy/issues/2442

I've changed the generated code to properly track cast
expressions.

Unfortunatelly, I've had to rewrite the `visit_decl` method, to
avoid that last if of the chain will be added. After looking at the code,
this last line was being added because of the `let x: char` part, but not
because of the `0x45df as char` expression.

It seems that let statements should not generate code on the author
lint, but I'm not sure that this is true or if I'm breaking
something on other code generation parts.

Finally, I've added a test for the author lint, but I'm not sure that
this needs to be added to the testsuite.
 2018-02-24 02:19:47 +01:00