sinkuu
cb86c57c5f
Integrate suggestion spans
2017-02-21 19:03:50 +09:00
sinkuu
3516d45d7c
Use multispan_sugg
2017-02-21 18:44:31 +09:00
sinkuu
627d24c80f
Fix suggestion for let <pat>
2017-02-21 00:27:12 +09:00
sinkuu
f1b0b774e7
Support non-moving usages at match
...
This `match` is not moving the `String`:
```rust
fn foo(x: Option<String>) -> i32 {
match x {
Some(_) => 1,
None => 2,
}
}
```
With this change, it will be linted and suggested to add `*` to deref it.
```rust
fn foo(x: &Option<String>) -> i32 {
match *x {
Some(_) => 1,
None => 2,
}
}
```
2017-02-20 16:45:37 +09:00
sinkuu
0a6bc6031a
Rename lint to needless_take_by_value
...
And fixes false-positives for generics and `match`
2017-02-20 16:02:48 +09:00
sinkuu
d2f73e7818
Add explanation
2017-02-19 18:07:37 +09:00
sinkuu
d81d961ba7
Lint needless take-by-value
2017-02-19 07:59:44 +09:00
sinkuu
d2b9b7ece2
Fix language & if_let_chain usage
2017-02-18 10:14:25 +09:00
sinkuu
8cb2ec804d
Support generic type
2017-02-18 10:14:25 +09:00
sinkuu
16e53c9868
Run update_lints.py
2017-02-18 10:14:20 +09:00
sinkuu
6bb426b0e3
Add should_assert_eq lint ( fixes #641 )
2017-02-18 10:13:56 +09:00
Andre Bogus
6c8a6c18ab
deal with binary op short-circuit
2017-02-17 08:49:34 +01:00
Andre Bogus
505eb53d29
New never loop lint
...
This lint detects loops that unconditionally break or return.
Closes #257
2017-02-17 04:53:14 +01:00
Ben Boeckel
84509ca48a
typos: coma -> comma
2017-02-16 11:23:28 -05:00
Oliver Schneider
40ea5e8c5d
run util/update_lint
2017-02-13 11:40:27 +01:00
Oliver Schneider
2265babe6a
Merge remote-tracking branch 'origin/master' into clonedCollect
2017-02-13 11:40:02 +01:00
Oliver Schneider
b13d206a22
run rustfmt
2017-02-13 11:18:03 +01:00
Oliver Schneider
637a4590f6
Merge remote-tracking branch 'origin/master'
2017-02-13 11:15:12 +01:00
Martin Carton
9a7597d5af
Merge pull request #1528 from Manishearth/mut-from-ref
...
New `mut_from_ref` lint
2017-02-12 16:01:15 +01:00
Andre Bogus
2a0bfdcd72
rustfmt
2017-02-12 14:11:18 +01:00
Andre Bogus
36b8554cf1
add notes for immutable inputs
2017-02-12 13:53:30 +01:00
f001
b3570db094
update via comments
2017-02-12 20:40:38 +08:00
f001
5a039f68f7
format adjust
2017-02-12 17:24:59 +08:00
f001
98aa0db0ac
Add a lint for slice.iter().cloned().collect()
...
If one uses `slice.iter().cloned().collect()` to create a new `Vec`,
it should be `slice.to_owned()`.
Fix #1292
2017-02-12 17:03:09 +08:00
Bood Qian
9824c997fe
Remove unnecessary ref
2017-02-12 09:16:37 +08:00
Bood Qian
1c381ec642
Move more into if_let_chain
2017-02-11 22:11:19 +08:00
Bood Qian
12c53752b8
Apply rustfmt
2017-02-11 21:47:26 +08:00
Bood Qian
64d2f8af8e
Lint on panic! only
2017-02-11 21:42:42 +08:00
Bood Qian
a2d752807a
Lint on Err(_) arm of a match
2017-02-11 14:57:50 +08:00
Owen Sanchez
8fb582ea1c
rustfmt
2017-02-10 21:08:50 -07:00
Owen Sanchez
45a7012fd9
Search directly for the largest and smallest variants instead of sorting
2017-02-10 18:12:32 -07:00
Owen Sanchez
1938904fcd
Change large_enum_variant to lint against size differences rather than size
2017-02-10 18:12:32 -07:00
Owen Sanchez
7e4b633417
Add some writes to a log file for debugging
2017-02-10 18:11:10 -07:00
Andre Bogus
bff4c30ac7
added test, fixed message & description, rustfmt
2017-02-11 00:32:12 +01:00
Andre Bogus
5650a599a8
New mut_from_ref lint
...
This fixes #1507 .
2017-02-10 19:39:03 +01:00
Martin Carton
37a0e52a1e
Merge pull request #1520 from Manishearth/rustup
...
rustup and compile-fail -> ui test move
2017-02-08 21:07:19 +01:00
Nathan Musoke
f2603ba2b2
doc-markdown: Allow LaTeX-related words
...
Add "TeX", "LaTeX", "BibTeX" and "BibLaTeX" to the default list of allowed
words.
2017-02-08 09:14:18 +13:00
Oliver Schneider
fd1351f6e3
rustup and compile-fail -> ui test move
2017-02-07 21:05:30 +01:00
Martin Carton
4ee839857b
Merge pull request #1506 from bood/master
...
Lint for possible missing comma in an array #1177
2017-02-07 18:56:38 +01:00
Owen Sanchez
59e0ae75d0
Make rustfmt happy
2017-02-05 09:51:31 -07:00
Owen Sanchez
31919aff3b
Revert changes from accidentally running rustfmt
2017-02-04 22:22:33 -07:00
Owen Sanchez
c922eb9db5
Suggest to use a wrapper in the wiki for the empty_enum lint
2017-02-04 22:09:54 -07:00
Owen Sanchez
1193f4fb68
Run update_lints.py
2017-02-04 21:54:21 -07:00
Owen Sanchez
49238ad1d2
Implement empty_enum lint and add a test
2017-02-04 21:52:44 -07:00
Owen Sanchez
e88e637b67
Add empty_enum lint (just a copy of large_enum_variant for now)
2017-02-04 21:07:54 -07:00
Bood Qian
4b4dc0a4d3
Fix lint name in comment too
2017-02-05 11:06:19 +08:00
Oliver Schneider
d198b99472
fix false negatives introduced in the rustup
2017-02-04 16:59:06 +01:00
Bood Qian
9ace6c7ffc
Consider expression with macro for possible missing comma lint
2017-02-04 21:13:36 +08:00
Oliver Schneider
7fbc7c0bb2
version bump
2017-02-04 13:42:13 +01:00
Oliver Schneider
384eb82526
don't record elided lifetimes on trait objects
2017-02-04 13:18:51 +01:00
