squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity
16779 commits 1 branch 0 tags 1.1 GiB
Commit graph

16779 commits

This branch
This branch
All branches
Author SHA1 Message Date
Brandon 1713f4c7cd Remove unnecessary braces for extracted block expression 2021-04-21 23:39:35 -07:00
bors[bot] 1f1a1ce4f5
Merge #8595 
8595: Diagnostic paths support specifying `remapPrefix` r=rickvanprim a=rickvanprim

Currently VSCode Problem Matchers will resolve a path like `//foo_crate/src/main.rs` if `${workspaceFolder}/foo_crate/src/main.rs` exists.  Presumably their behavior is functionally a string concatenation that would produce `${workspaceFolder///foo_crate/src/main.rs` and repeated path separators get ignored.

This PR attempts to mimic this behavior by stripping any `Component::RootDir` from `file_name` before joining it to `workspace_root`, and then checking if the file exists.  If it does, this path is used, and if not, the behavior falls through to the existing Rust path join behavior.

Co-authored-by: James Leitch <rickvanprim@gmail.com>
 2021-04-21 23:54:47 +00:00
Lukas Wirth d5c9de65c5 Don't filter equal nodes in reorder assists 2021-04-22 00:54:31 +02:00
James Leitch 72718bc2d7 Code review feedback. 2021-04-21 15:10:53 -07:00
James Leitch 9fcad82980 Diagnostic Remap Path Prefixes added. 2021-04-21 15:10:53 -07:00
James Leitch 60841f4276 Diagnostic paths attempt to use VSCode's path join behavior before defaulting to Rust's path join behavior. 2021-04-21 15:10:53 -07:00
bors[bot] 32491c0978
Merge #8570 
8570: Flycheck tries to parse both Cargo and Rustc messages. r=rickvanprim a=rickvanprim

This change allows non-Cargo build systems to be used for Flycheck provided they call `rustc` with `--error-format=json` and emit those JSON messages to `stdout`.

Co-authored-by: James Leitch <rickvanprim@gmail.com>
 2021-04-21 21:56:54 +00:00
bors[bot] b21701c5ee
Merge #8616 
8616: minor: Bump deps r=lnicola a=lnicola

bors r+

Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
 2021-04-21 16:20:56 +00:00
Laurențiu Nicola 81054a2581 Bump other deps 2021-04-21 19:20:18 +03:00
Laurențiu Nicola 27c5e2da48 Bump chalk 2021-04-21 19:20:01 +03:00
Laurențiu Nicola e50ca6b067 Bump rustc_lexer 2021-04-21 19:19:27 +03:00
bors[bot] 163d9d31a4
Merge #8615 
8615: skip: Remove `ItemTree::all_inner_items` r=jonas-schievink a=jonas-schievink

It's unused.

bors r+

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
 2021-04-21 16:10:55 +00:00
Jonas Schievink 0414b65319 Remove ItemTree::all_inner_items 2021-04-21 18:10:25 +02:00
bors[bot] e9fea823a0
Merge #8613 
8613: skip: Add failing local items test r=jonas-schievink a=jonas-schievink

This is currently broken due to the way ItemTree stores inner items. This test serves as a reminder until this gets fixed.

bors r+

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
 2021-04-21 15:58:57 +00:00
Jonas Schievink 7b7d051e81 Add failing local items test 2021-04-21 17:57:45 +02:00
bors[bot] c7ae16e872
Merge #8611 
8611: Add support for fill match arms of boolean values r=flodiebold a=komonad

- Add support for boolean inside tuple

closes #8593

Co-authored-by: Comonad <comonad@foxmail.com>
 2021-04-21 14:48:03 +00:00
unexge 322cd1fa7f Use multiple loops instead of Iterator::chain in FindUsages 2021-04-21 16:42:47 +03:00
unexge 6630266ce1 Add multi file test for "Convert to named struct" assist 2021-04-21 16:20:08 +03:00
unexge 96d694062b Remove unwraps in "Convert to named struct" assist 2021-04-21 16:01:13 +03:00
Comonad 09147c3303 Add support for fill match arms of boolean values 
- Add support for boolean inside tuple
 2021-04-21 19:33:45 +08:00
bors[bot] 7ae0bc1bd4
Merge #8609 
8609: Parse outer atttributes for RecordPatField r=Veykril a=Veykril

Fixes #8608
bors r+

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
 2021-04-21 09:12:08 +00:00
Lukas Wirth 3f7a086b4f Parse outer atttributes for RecordPatField 2021-04-21 11:08:15 +02:00
unexge e0a60e71d7 Add larger example for "Convert to named struct" assist 2021-04-21 10:57:36 +03:00
unexge 53599d11f6 Fix incorrectly replacing method calls in "Convert to named struct" assist 2021-04-21 10:27:26 +03:00
bors[bot] 70fe7a4515
Merge #8606 
8606: fix: no more  Registering progress handler for token rustAnalyzer/Ind… r=jonas-schievink a=matklad

…exing failed.

closes #8509

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
 2021-04-20 21:25:27 +00:00
Aleksey Kladov cdfe5a8be0 fix: no more Registering progress handler for token rustAnalyzer/Indexing failed. 2021-04-20 22:54:05 +03:00
Lukas Wirth b290cd5782 Add cov_marks to insert_use tests 2021-04-20 19:34:43 +02:00
Laurențiu Nicola 39ce393a9e Automatically categorize the changelog entries 2021-04-20 19:54:58 +03:00
Lukas Wirth 2c8f1b5c30 Rewrite extract_struct_from_enum_variant assist 2021-04-20 17:36:42 +02:00
bors[bot] ad131049c4
Merge #8600 
8600:  fix: no longer get stuck on windows r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
 2021-04-20 15:05:33 +00:00
Aleksey Kladov 1772eb0f1a fix: no longer get stuck on windows 
reading both stdout & stderr is a common gotcha, you need to drain them
concurrently to avoid deadlocks. Not sure why I didn't do the right
thing from the start. Seems like I assumed the stderr is short? That's
not the case when cargo spams `compiling xyz` messages
 2021-04-20 18:02:54 +03:00
bors[bot] 86c2bb3c5b
Merge #8602 
8602: Fix panic in `replace_derive_with_manual_impl` r=jonas-schievink a=jonas-schievink

bors r+

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
 2021-04-20 14:27:08 +00:00
Jonas Schievink c0ad9b3581 Follow testing style guide 2021-04-20 16:26:07 +02:00
Jonas Schievink 6624158969 Fix panic in replace_derive_with_manual_impl 2021-04-20 16:25:24 +02:00
bors[bot] da6902d159
Merge #8601 
8601: Trigger "Inline variable" assist when on a use of the variable r=jonas-schievink a=jonas-schievink

Fixes https://github.com/rust-analyzer/rust-analyzer/issues/8530

bors r+

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
 2021-04-20 14:18:51 +00:00
Jonas Schievink d699371f5f "Inline variable" when on a use of the variable 2021-04-20 16:16:23 +02:00
bors[bot] 1834938d6f
Merge #8598 
8598: minor: fix ugly line wrapping in the rendered manual r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
 2021-04-20 07:45:04 +00:00
Aleksey Kladov 0ce591d33d minor: fix ugly line wrapping in the rendered manual 2021-04-20 10:44:06 +03:00
Lukas Wirth fa20a5064b Remove SyntaxRewriter usage in insert_use in favor of ted 2021-04-20 02:09:12 +02:00
Lukas Wirth e8744ed9bb Replace SyntaxRewriter usage with ted in reorder_impl assist 2021-04-20 02:08:21 +02:00
James Leitch b3a7953cae Code review feedback. 2021-04-19 12:26:04 -07:00
bors[bot] 15b34667c5
Merge #8588 
8588: internal: Add guidelines for release notes PR descriptions r=matklad a=lnicola



Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
 2021-04-19 18:38:34 +00:00
Laurențiu Nicola bb4952da04 internal: Add guidelines for release notes PR descriptions 2021-04-19 21:30:44 +03:00
bors[bot] b6a7276c54
Merge #8586 
8586: Replace SyntaxRewriter usage with ted in eager::eager_macro_recur r=Veykril a=Veykril



Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
 2021-04-19 18:03:56 +00:00
bors[bot] 9cfbb56afa
Merge #8587 
8587: Fix some find_path bugs around inner items r=jonas-schievink a=jonas-schievink

Fixes https://github.com/rust-analyzer/rust-analyzer/issues/8519

bors r+

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
 2021-04-19 17:54:34 +00:00
Jonas Schievink ec05186378 Add autoimport test with inner items 2021-04-19 19:53:29 +02:00
Jonas Schievink 59630977a5 Fix some find_path bugs around inner items 2021-04-19 19:50:11 +02:00
Lukas Wirth 952fc23694 Replace SyntaxRewriter with ted in exppand_macro::expand_macro_recur 2021-04-19 19:43:26 +02:00
Lukas Wirth 617cd7231c Remove SyntaxRewriter usage in eager::eager_macro_recur 2021-04-19 19:28:41 +02:00
bors[bot] 0741de87e7
Merge #8584 
8584: internal: fix slightly broken test r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
 2021-04-19 16:04:44 +00:00