squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity
6031 commits 1 branch 0 tags 1.1 GiB
Commit graph

1295 commits

Author SHA1 Message Date
Oliver Schneider 7757c893ef
Fix len_zero ICE 2017-09-04 17:05:47 +02:00
Manish Goregaokar 35eda0531a
Fix unit_expr expectations and changelog entry 2017-09-03 14:14:20 -07:00
Zaki Manian 44f694d0a1 Rustfmt tests 2017-09-03 13:46:49 -07:00
Zaki Manian 8b53f2238b Fix all the clippy lints 
Add false positive tests
 2017-09-03 13:39:49 -07:00
Zaki Manian e0caf26586 RustFmt file and tests 2017-09-03 11:19:59 -07:00
Zaki Manian eb7955b265 More relevant tests 2017-09-03 10:39:28 -07:00
Zaki Manian 436d838ad7 Update unit tests 2017-09-03 09:12:55 -07:00
Zaki Manian 33e86407fd early tests 2017-09-03 08:56:34 -07:00
Oliver Schneider c64073b2f5
Deprecate the wiki and remove the lint list from the README (fixes #1933) 2017-09-01 12:34:05 +02:00
Dan Gohman 1ea70116d3 Enable the cast_lossless warning by default. 2017-08-29 05:48:56 -07:00
Oliver Schneider 6bc7893b70 Merge pull request #1956 from sunfishcode/master 
Add a lint for lossless casts.
 2017-08-29 08:50:36 +02:00
Tim Nielens ec79970771 len_without_is_empty false positive #1740 2017-08-28 23:18:12 +02:00
Oliver Schneider 73d87d966d
Update tests to current rustc 2017-08-28 18:16:16 +02:00
Dan Gohman 7714203c72 Add a lint for lossless casts. 2017-08-28 08:42:33 -07:00
Oliver Schneider 23bc6508bb Merge pull request #1861 from CBenoit/master 
Add example for needless borrowed ref lint and register it
 2017-08-28 14:34:30 +02:00
Andre Bogus df903edddd New lint: (maybe_)infinite_iter 
This fixes #1870 (mostly, does not account for loops yet)
 2017-08-25 22:20:52 +02:00
Alexey Zabelin 695bedbe27
Rename match_path_old to match_path 
The old `match_path` was renamed to `match_qpath`.

As per #1983.
 2017-08-24 20:42:50 -04:00
Oliver Schneider ab362031ed Merge pull request #1959 from DarkEld3r/1884-borrowed-box-any 
Fix borrowed_box lint for Box<Any>
 2017-08-24 23:59:15 +02:00
Oliver Schneider 36e417cce5 Merge pull request #1982 from rust-lang-nursery/bytecount 
new lint: naive_bytecount
 2017-08-24 09:09:56 +02:00
Andre Bogus 6d989c729d add closure arg check, also catch non-consts 2017-08-23 17:54:35 +02:00
Stanislav Tkach 45ff467c31 Fix borrowed_box lint for Box<Any> 2017-08-23 17:00:39 +03:00
Andre Bogus 70e34077d5 new lint: naive_bytecount 2017-08-22 23:45:08 +02:00
Tim Nielens 572b3388ac lint #1674: lifetimed types exclusion 
add expect() message and update test results
 2017-08-22 19:22:47 +02:00
Tim Nielens 3f575d874b lint #1674: lifetimed types exclusion 2017-08-22 19:08:49 +02:00
Oliver Schneider 992d88ab58 Merge pull request #1977 from rust-lang-nursery/panic 
Fix a panic and a false positive
 2017-08-22 10:20:02 +02:00
Andre Bogus 2362177aaf fix #768 by checking for message macro expansion 2017-08-21 23:23:54 +02:00
Oliver Schneider c3ef220bba
Rebase and update ui test 2017-08-21 14:22:41 +02:00
Oliver Schneider 66346b22ff Merge pull request #1973 from rust-lang-nursery/fix-1920 
remove stars at the beginning of multiline comments
 2017-08-21 13:52:26 +02:00
Oliver Schneider 3eab44acb1
Don't trigger Self suggestion inside derives 2017-08-21 12:58:06 +02:00
Oliver Schneider f1847f7a98
Test changes 2017-08-21 10:26:46 +02:00
Oliver Schneider 5e5478a3c3 Merge pull request #1931 from rust-lang-nursery/move_links 
Change all links to reflect the move to rust-lang-nursery
 2017-08-21 09:35:19 +02:00
Andre Bogus 93c48a0977 remove stars at the beginning of multiline comments 2017-08-19 22:52:49 +02:00
Oliver Schneider d1eecbaa2f Merge pull request #1965 from montrivo/use_self 
lint #1674: replace struct name with `Self` when applicable
 2017-08-18 20:54:18 +02:00
Tim Nielens 7aebe3a690 lint #1674: replace struct name with Self when applicable 
SelfType const and suggestion
 2017-08-18 19:46:50 +02:00
Joonas Koivunen 171f7b4eb7 tests/ui/let_unit: fix comment and example code 
The previous version would had deadlocked as the Sender remained alive
and iterator would had never became complete. Just in case someone
decided to run it.
 2017-08-18 17:29:05 +03:00
Joonas Koivunen cf8e95eb22 is_from_for_desugar: add match for for _ in x 
This will avoid `let_unit_value` in the examples in the ui-test.
It might match too widely.
 2017-08-18 17:07:39 +03:00
Tim Nielens 7759bd6111 lint #1674: replace struct name with Self when applicable 2017-08-18 01:11:39 +02:00
Mateusz Mikula 0d244d3f39
Fix verbose_bit_mask off by one error 
Fixes #1940
 2017-08-14 16:22:20 +02:00
Oliver Schneider 4470d7a8ca Merge branch 'master' into move_links 2017-08-14 10:07:26 +02:00
Oliver Schneider d6fc34fd08 Update for rustc output changes 2017-08-14 09:54:47 +02:00
Oliver Schneider 459cf467c5 Rustup 2017-08-14 09:54:47 +02:00
Andre Bogus f515d7bb67 Change all links to reflect the move to rust-lang-nursery 2017-08-06 23:10:55 +02:00
Andre Bogus 76ca4dca85 unify checks into single visitor, fix block walk 2017-08-04 07:48:43 +02:00
Andre Bogus 3b7f3dc8e7 WIP: Find binding or assignment within outer loop 2017-08-03 22:11:58 +02:00
Oliver Schneider 74c776585c Move all our tests back to ui tests 2017-08-01 17:54:21 +02:00
Oliver Schneider f889ba95d3 Fix ui tests 2017-07-21 10:40:23 +02:00
messense 95f04f80fb
Update ui tests 2017-07-03 12:37:14 +08:00
Georg Brandl 6b6253016f Update stderr files for change in error reporting 
rustc now (https://github.com/rust-lang/rust/issues/33525) does not
report an error count anymore, because it was not correct in many cases.
 2017-05-26 16:54:07 +02:00
Oliver Schneider 4465bc3e3f Make most tests an example so we can run them one by one 2017-05-17 14:19:44 +02:00
Andre Bogus e75d7ffd2d distinguish debug_assert 2017-05-15 22:49:20 +02:00
mcarton b6326121ab Fix span in blacklisted_name 2017-05-14 14:58:16 +02:00
Oliver Schneider 4d5e25f31d Update to rustc 1.19.0-nightly (826d8f385 2017-05-13) 
fixes #1759, #1758
 2017-05-14 09:56:10 +02:00
Oliver Schneider 29cb2f7eba Fix various wrong uses of NestedVisitorMap::All 2017-05-12 12:02:42 +02:00
Oliver Schneider 672045689e Fix #1730 2017-05-11 19:02:19 +02:00
Oliver Schneider 8300f0c080 Merge pull request #1747 from Manishearth/mut_fp 
Fixes #1735
 2017-05-11 18:18:58 +02:00
Luis de Bethencourt 6f3679b8e4 clean tests/ui/zero_div_zero.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt b5a124bc27 clean tests/ui/while_loop.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 45949c0da9 clean tests/ui/vec.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 300a82c295 clean tests/ui/used_underscore_binding.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt fd3c001ec9 clean tests/ui/unused_io_amount.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt d0b932fb53 clean tests/ui/unsafe_removed_from_name.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt cf7303d217 clean tests/ui/unicode.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 81ee7f752e clean tests/ui/transmute.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 24324f84d8 clean tests/ui/toplevel_ref_arg.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 80ca0484c7 clean tests/ui/swap.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt a7635aa1c8 clean tests/ui/strings.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt c79a350c55 clean tests/ui/short_circuit_statement.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt ffb768cf8d clean tests/ui/serde.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt bf6d4b7129 clean tests/ui/regex.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 36ba4885ab clean tests/ui/reference.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 7d2e0cb435 clean tests/ui/redundant_closure_call.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 169f35712c clean tests/ui/print.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt ec343e1524 clean tests/ui/precedence.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 69139facb2 clean tests/ui/ok_if_let.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt c9190f681d clean tests/ui/non_expressive.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt efbaf09308 clean tests/ui/no_effect.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 47c17e63e7 clean tests/ui/new_without_default.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 747a20153c clean tests/ui/neg_multiply.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt cd55b87874 clean tests/ui/needless_return.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt b4a20aedf9 clean tests/ui/needless_bool.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt ac00b1d70b clean tests/ui/mut_mut.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 9ece185c45 clean tests/ui/methods.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 409eea2b51 clean tests/ui/mem_forget.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 86d5ffae8a clean tests/ui/matches.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt a5e66fa34b clean tests/ui/literals.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt cf9370f670 clean tests/ui/lifetimes.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 2df0161973 clean tests/ui/let_if_seq.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 7b2766af4a clean tests/ui/len_zero.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 3ca67910a8 clean tests/ui/if_let_redundant_pattern_matching.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 2389f9e94c clean tests/ui/functions.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt df5d12a3ec clean tests/ui/formatting.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 6d2329f2cb clean tests/ui/for_loop.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt faca269488 clean tests/ui/float.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt bc9cdf1d64 clean tests/ui/eval_order_dependence.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt fbc6b26592 clean tests/ui/eta.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 8fc00c57b6 clean tests/ui/eq_op.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 5013f49195 clean tests/ui/entry.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 856d64d43e clean tests/ui/doc.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt e3aa074033 clean tests/ui/derive.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt e2cce4809b clean tests/ui/copies.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 5e45d09c4f clean tests/ui/conf_french_blacklisted_name.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt aa3d361bec clean tests/ui/collapsible_if.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt ed713d67d6 clean tests/ui/cmp_owned.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 17284bacee clean tests/ui/cast.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 34e4c0f9e3 clean tests/ui/booleans.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 5865c2aacd clean tests/ui/bool_comparison.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt cc923b5d0e clean tests/ui/block_in_if_condition.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt 0c9d9d9f6c clean tests/ui/blacklisted_name.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt ac4ce0b2fe clean tests/ui/assign_ops2 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt e18a250139 clean tests/ui/absurd-extreme-comparisons.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Oliver Schneider 81b35d197b Fixes #1735 2017-05-11 16:32:06 +02:00
Oliver Schneider fb6895836f Address PR comments 2017-05-11 15:36:27 +02:00
Oliver Schneider 2cd3366817 Fixes #443 2017-05-10 13:42:19 +02:00
Oliver Schneider 3b3e47f451 Merge pull request #1738 from Manishearth/serde 
Update serde to 1.0
 2017-05-10 08:55:36 +02:00
Oliver Schneider dee53fa1e2 Merge pull request #1728 from Manishearth/inspector 
Print type adjustments in the inspector
 2017-05-09 15:26:01 +02:00
Oliver Schneider 31b2bf4ab9 Update our config reading to serde 1.0 2017-05-09 15:23:38 +02:00
Oliver Schneider 8225c23a33 Update to serde 1.0 2017-05-09 15:23:10 +02:00
Luis de Bethencourt f1434d2023 clean tests/ui/assign_ops.rs 
When all //~ were removed from tests, these were replaced with empty
lines to leave the numbers in the expected stderr untouched.

Cleaning the empty lines for clarity.
 2017-05-08 14:05:02 +01:00
Oliver Schneider 866239b1a8 Add a test showing a false positive on needless_borrow 2017-05-05 14:26:14 +02:00
Oliver Schneider a6c8464dde Update to rustc 1.19.0-nightly (6a5fc9eec 2017-05-02) 2017-05-03 12:51:47 +02:00
Oliver Schneider 96b25cdaf2 Add regression tests for op_ref 2017-04-28 17:07:39 +02:00
Oliver Schneider 7aa42073f2 Fix op_ref false positives 2017-04-28 17:03:47 +02:00
Oliver Schneider 5381c4fcf6 Update ui tests to new rustc range printing 2017-04-25 10:57:44 +02:00
Oliver Schneider 68369e5d37
Merge remote-tracking branch 'origin/master' into yati_master 2017-04-25 10:31:40 +02:00
mcarton b20a6a773c
Update tests to new format of multiline errors 2017-04-23 15:39:41 +02:00
Yati Sagade cac15d24f9 needless_continue: Remove indentation of suggestion code. 
As per a suggestion by Oliver on the PR thread, maintaining indentation
in the suggested code is futile because of the changes in the compiler
and the messiness of real-world code. rustfmt will do the indentation if
required, so we don't need to do it.
 2017-04-13 21:48:52 +02:00
Oliver Schneider 3534149035 Update ui tests 2017-04-11 16:19:27 +02:00
Oliver Schneider 679e98530a
Merge remote-tracking branch 'origin/master' into yati 2017-04-11 16:16:10 +02:00
Oliver Schneider 21d8fbd082 Don't lint for lifetime bounds required by traits 2017-04-11 15:44:13 +02:00
Oliver Schneider fae1e646ee Remove useless warning 2017-04-11 14:34:39 +02:00
Oliver Schneider 2eae102cd1 Don't lint lifetimes after trait objects 2017-04-11 14:29:58 +02:00
Oliver Schneider 9a4c0a1c72 Don't lint about unused lifetimes if the lifetimes are used in the body of the function 2017-04-11 14:09:58 +02:00
Oliver Schneider 7b6111677a Latest nightly produces more ellipses in output 2017-04-10 15:36:07 +02:00
Oliver Schneider b76ce176bb Fix op_ref in case of nonexisting operations 2017-04-10 15:10:19 +02:00
Yati Sagade 62548f447c needless_continue: Add ui test 
The test program contains both conditions tested by the lint, i.e.,
a redundant continue in the `if` and `else` blocks within a loop. Maybe
splitting them out and also having a program that should *not* trigger
the lint warning is better.
 2017-04-09 14:20:14 +02:00
Oliver Schneider f1e905f620 Reintroduce #768 so we can publish 2017-04-07 11:21:39 +02:00
Oliver Schneider 3052000c73 Merge pull request #1649 from ensch/master 
Fix for rustc 1.18.0-nightly (5c94997b6 2017-03-30)
 2017-04-07 11:13:44 +02:00
Oliver Schneider f32fab1c8f panic!("{}") lint is broken 2017-04-06 16:49:03 +02:00
Peter Gerber 71a788cbd7 correct error message for option_map_unwrap_or_else lint 
Remove erroneous "with " in suggested alternative call.
 2017-04-01 15:54:27 +02:00
Oliver Schneider 5547fbb770 Fix accidental newline in diagnostic and missing entries in lint_array! 2017-03-24 10:21:12 +01:00
Oliver Schneider 8ae82eb4ab
Merge remote-tracking branch 'origin/master' into 1537-drop_copy 2017-03-24 10:11:46 +01:00
sinkuu a712271df6 Filter out proc_macro_derive functions (fixes #1615) 2017-03-21 17:09:21 +09:00
Oliver Schneider 2d145b2ef5 don't lint macro_rules! in items_after_statements 2017-03-13 11:09:56 +01:00
Oliver Schneider 51295960bf Fix invalid_upcast_comparisons lint for same size sign casts 2017-03-02 10:41:20 +01:00
Tristian Celestin 75e28610a7 Merged drop_forget_ref.rs with drop_forget_copy.rs. 
Moved constant message strings out of declare_lint! macros.
 2017-02-26 21:57:47 -05:00
Tristian Celestin aa037d1ef0 Merge branch 'master' into 1537-drop_copy 2017-02-25 23:11:21 -05:00
Tristian Celestin b8defc6cc4 Warn on calls to std::mem::drop or std::mem::forget with a Copy type 2017-02-25 23:05:37 -05:00
sinkuu 5906639af5 Enable len_zero for slices 2017-02-25 12:26:33 +09:00
Oliver Schneider 19929790aa Merge pull request #1561 from Manishearth/zero_ptr 
New zero_ptr lint.
 2017-02-22 13:34:28 +01:00
sinkuu 1e26c44010 Suggest assert_ne for assert!(x != y) 2017-02-22 16:47:18 +09:00
Oliver Schneider a7c049df28 Merge pull request #1564 from Manishearth/cleanup 
Cleanup test suite
 2017-02-21 15:30:39 +01:00
Oliver Schneider d032b8967c Merge pull request #1491 from Manishearth/into_iter_on_ref 
fix explicit_into_iter_loop on references
 2017-02-21 14:55:52 +01:00
Oliver Schneider 27aa309b3d Merge pull request #1556 from sinkuu/take_by_value 
Lint needless take-by-value
 2017-02-21 13:07:25 +01:00
Oliver Schneider 25e230419c Merge system independent ui-tests back into tests/ui 2017-02-21 12:19:55 +01:00
Oliver Schneider f2ff5e2133 Update ui test output 2017-02-21 12:13:44 +01:00
Oliver Schneider 21a0b16aee
adjust messages in tests 2017-02-21 12:04:29 +01:00
Oliver Schneider 0bea3e76d4
fix explicit_into_iter_loop on references 
fixes #1398
 2017-02-21 12:01:41 +01:00
Oliver Schneider 89d98a8732 Simplify calling update-all-references.sh 2017-02-21 11:18:05 +01:00
sinkuu cb86c57c5f Integrate suggestion spans 2017-02-21 19:03:50 +09:00
sinkuu 3516d45d7c Use multispan_sugg 2017-02-21 18:44:31 +09:00
Oliver Schneider 55ea08102a Merge pull request #1543 from Manishearth/fix-windows-tests 
fix windows tests
 2017-02-21 10:34:49 +01:00
Oliver Schneider f07f793fa8 Merge pull request #1544 from bood/master 
Add lint for unnecessary casts (cast to same type)
 2017-02-21 09:16:07 +01:00
Andre Bogus 2f7babba82 New zero_ptr lint. 
This fixes #1047. I did not bother to add a full suggestion,
because replacing with `std::ptr::null()` may still lead to
inference failures.
 2017-02-21 04:36:59 +01:00
sinkuu 627d24c80f Fix suggestion for let <pat> 2017-02-21 00:27:12 +09:00
sinkuu f1b0b774e7 Support non-moving usages at match 
This `match` is not moving the `String`:

```rust
fn foo(x: Option<String>) -> i32 {
    match x {
        Some(_) => 1,
        None => 2,
    }
}
```

With this change, it will be linted and suggested to add `*` to deref it.

```rust
fn foo(x: &Option<String>) -> i32 {
    match *x {
        Some(_) => 1,
        None => 2,
    }
}
```
 2017-02-20 16:45:37 +09:00
sinkuu 0a6bc6031a Rename lint to needless_take_by_value 
And fixes false-positives for generics and `match`
 2017-02-20 16:02:48 +09:00
Phil Ellison d6a4d2cb18 Fix typo 2017-02-19 15:39:40 +00:00
Phil Ellison 0396756098 Add test that adding allow attribute on impl block containing len silences len_without_is_empty. Add extra impl block to PubOne to check that this doesn't get flagged@ 2017-02-19 15:36:17 +00:00
Phil Ellison 2dd45b7317 Use span of impl/trait in len_without_is_empty error message, rather than the span of the len method 2017-02-19 15:14:30 +00:00
sinkuu d81d961ba7 Lint needless take-by-value 2017-02-19 07:59:44 +09:00
Bood Qian 97d46232b4 Merge branch 'master' of github.com:Manishearth/rust-clippy 2017-02-18 11:12:13 +08:00
sinkuu 8cb2ec804d Support generic type 2017-02-18 10:14:25 +09:00
sinkuu 6bb426b0e3 Add should_assert_eq lint (fixes #641) 2017-02-18 10:13:56 +09:00
Andre Bogus 505eb53d29 New never loop lint 
This lint detects loops that unconditionally break or return.

Closes #257
 2017-02-17 04:53:14 +01:00
Ben Boeckel 84509ca48a typos: coma -> comma 2017-02-16 11:23:28 -05:00
Bood Qian 2f00ea3a07 Suppress lint for unsuffixed number casts 2017-02-16 22:55:41 +08:00
Bood Qian afce85e96d Add lint for unnecessary casts (cast to same type) 2017-02-15 22:20:20 +08:00
Andre Bogus d904a01140 fix windows tests 
Windows has a different error message than POSIX, so the ui tests fail for the clippy-config-fail tests.
This commit splits those tests up in target-os specific subdirectories and extends compile-test.rs to
run either of them based on the target os. Here's hope we'll get a green appveyor build.
 2017-02-14 17:30:55 +01:00
Oliver Schneider 8b3ad61dd3 update ui tests 2017-02-13 11:57:14 +01:00
Oliver Schneider 2265babe6a
Merge remote-tracking branch 'origin/master' into clonedCollect 2017-02-13 11:40:02 +01:00
Oliver Schneider 637a4590f6
Merge remote-tracking branch 'origin/master' 2017-02-13 11:15:12 +01:00
Martin Carton 9a7597d5af Merge pull request #1528 from Manishearth/mut-from-ref 
New `mut_from_ref` lint
 2017-02-12 16:01:15 +01:00
Andre Bogus 21d226e7d2 fixed multi-span test 2017-02-12 15:10:25 +01:00
Andre Bogus 36b8554cf1 add notes for immutable inputs 2017-02-12 13:53:30 +01:00
f001 b3570db094 update via comments 2017-02-12 20:40:38 +08:00
f001 98aa0db0ac Add a lint for slice.iter().cloned().collect() 
If one uses `slice.iter().cloned().collect()` to create a new `Vec`,
it should be `slice.to_owned()`.

Fix #1292
 2017-02-12 17:03:09 +08:00
Bood Qian 64d2f8af8e Lint on panic! only 2017-02-11 21:42:42 +08:00
Bood Qian a2d752807a Lint on Err(_) arm of a match 2017-02-11 14:57:50 +08:00
Owen Sanchez 2a8ce7c458 Update large_enum_variant test 2017-02-10 21:04:19 -07:00
Owen Sanchez 1938904fcd Change large_enum_variant to lint against size differences rather than size 2017-02-10 18:12:32 -07:00
Andre Bogus 673ee4800d fix test 2017-02-11 01:41:49 +01:00
Andre Bogus bff4c30ac7 added test, fixed message & description, rustfmt 2017-02-11 00:32:12 +01:00
Andre Bogus 5650a599a8 New mut_from_ref lint 
This fixes #1507.
 2017-02-10 19:39:03 +01:00
Oliver Schneider 1f2c97a291 remove all //~ from tests 2017-02-08 14:58:07 +01:00
Oliver Schneider fd1351f6e3 rustup and compile-fail -> ui test move 2017-02-07 21:05:30 +01:00