Oliver Schneider
a3cdcf142a
Merge pull request #2622 from flip1995/imm_while_fields
...
Don't trigger while_immutable_condition for mutable fields
2018-04-03 22:30:14 +02:00
flip1995
cecfdeab19
Don't trigger while_immutable_condition for mutable fields of tuples/structs
2018-04-03 16:41:30 +02:00
Oliver Schneider
b7f5871aa0
Merge pull request #2616 from mikerite/reenable_win_dogfood
...
Re-enable dogfood test on Windows
2018-04-03 08:49:29 +02:00
Oliver Schneider
c012fecce6
Merge pull request #2618 from rcoh/patch-1
...
Move `set -e` to before the deploy
2018-04-03 08:49:19 +02:00
Russell Cohen
35125d370f
Move set -e to before the deploy
...
I _think_ this might be why the deploy script crashing isn't causing the release to fail (see #2600 )
2018-04-02 23:11:47 -07:00
Michael Wright
6fc9d90b60
Re-enable dogfood test on Windows
...
This should work now that dogfood uses a separate output directory.
2018-04-03 06:22:42 +02:00
Oliver Schneider
90fcdafb79
Merge pull request #2608 from mrecachinas/feature/print-string-literal
...
Check for literals as println! args
2018-04-02 23:34:17 +02:00
Michael Recachinas
fa8161ba2e
Revert adding env! to tests
2018-04-02 21:34:04 +01:00
Michael Recachinas
d504290839
Add edge case with env! arg to test and known problems
2018-04-02 21:14:29 +01:00
Oliver Schneider
76d1e26fe2
Merge pull request #2612 from phansch/document_how_to_use_the_author_lint
...
Document the author lint
2018-04-02 17:05:11 +02:00
Philipp Hansch
b1b0b36cc0
Document the author lint
2018-04-02 14:55:00 +02:00
Oliver Schneider
fef7fb3473
Merge pull request #2611 from phansch/improve_readme
...
Readme: Explain nightly install and clippy update
2018-04-02 12:12:02 +02:00
Oliver Schneider
c5559c1648
Merge pull request #2605 from mikerite/dogfood_target_dir
...
Make dogfood test output to seperate directory
2018-04-02 12:10:43 +02:00
Philipp Hansch
fe8ba21962
Readme: Explain nightly install and clippy update
2018-04-02 11:25:04 +02:00
Michael Wright
add4434ee3
Support non-unicode paths for dogfood test
2018-04-02 09:28:08 +02:00
Michael Wright
e91404bcc3
Fix clippy warning
2018-04-02 07:35:13 +02:00
Michael Wright
0fbcb30303
Merge branch 'master' into dogfood_target_dir
2018-04-02 07:28:10 +02:00
Michael Wright
fcabbeb251
Fix clippy warning
...
Fix too_many_arguments on `check_general_case` by allowing it. I can't
see a sensible way of grouping the parameters.
2018-04-02 07:04:43 +02:00
Michael Wright
89cb053146
Fix clippy warning
...
Fix cyclomatic_complexity warning on `check_expr` by allowing it. This
is preferable to increasing the threshold every time the method changes.
2018-04-02 07:04:39 +02:00
Michael Wright
57af95b6f5
Fix clippy warning
...
Fix `option_option` warning on `to_const_range` by taking the entire range
as an parameter instead of the start and end.
2018-04-02 07:04:25 +02:00
Michael Wright
6397131f8a
Fix clippy warning
...
Allow `many_single_char_names` on `SpanlessHash::hash_expr`. Each
variable has a small scope and the method is readable.
2018-04-02 07:04:06 +02:00
Michael Recachinas
511aa654d7
Change declare_lint! to declare_clippy_lint!
2018-04-02 00:25:57 +01:00
Michael Recachinas
ddd75fbfec
Add #![allow(print_literal)] to other test/ui/print_*.rs tests
2018-04-02 00:24:40 +01:00
Michael Recachinas
62220abfa6
Add implementation and tests for literal checking in print/println format args
2018-04-01 23:19:53 +01:00
Martin Carton
83e210935d
Merge pull request #2606 from phansch/improve_contributing_instructions
...
Improve CONTRIBUTING.md
2018-04-01 16:32:44 +02:00
Philipp Hansch
872db029cf
Improve CONTRIBUTING.md
...
* Incremental compilation is on by default
* Restructured the label overview to go from easy to more difficult labels.
2018-04-01 15:31:25 +02:00
Michael Wright
609dd47410
Fix clippy warnings from last commit
2018-04-01 10:18:05 +02:00
Michael Wright
1ab96db791
Make dogfood test output to seperate directory
...
This commit makes `cargo clippy` output the build artifacts to a
separate directory if the `CLIPPY_DOGFOOD` env var is set. This should
prevent dogfood builds from interfering with regular builds.
This should help with issue #2595 .
2018-04-01 09:44:30 +02:00
Oliver Schneider
4ef7238b3e
Merge pull request #2601 from flip1995/export
...
Fix lintlib script
2018-03-31 20:55:33 +02:00
flip1995
2a52527a46
Fix lintlib script
2018-03-31 17:53:24 +02:00
Oliver Schneider
b7a0b97e97
Merge pull request #2590 from phansch/fix_another_false_positive
...
Fix false positive in empty_line_after_outer_attr
2018-03-30 13:13:45 +02:00
Philipp Hansch
db1ec44616
Handle nested block comments
2018-03-30 12:36:50 +02:00
Philipp Hansch
bb4af196be
Move empty_line_after_outer_attribute to nursery
...
From the clippy side it's difficult to detect empty lines between
an attributes and the following item because empty lines and comments
are not part of the AST. The parsing currently works for basic cases
but is not perfect and can cause false positives.
Maybe libsyntax 2.0 will fix some of the problems around attributes but
comments will probably be never part of the AST so we would still have
to do some manual parsing.
2018-03-30 12:36:50 +02:00
Philipp Hansch
b7929cafe1
Fix false positive in empty_line_after_outer_attr
...
Before, when you had a block comment between an attribute and the
following item like this:
```rust
\#[crate_type = "lib"]
/*
*/
pub struct Rust;
```
It would cause a false positive on the lint, because there is an empty
line inside the block comment.
This makes sure that basic block comments are detected and removed from
the snippet that was created before.
2018-03-30 12:36:50 +02:00
Manish Goregaokar
b45801ff19
Merge pull request #2593 from rust-lang-nursery/rustup
...
Rustup to rustc 1.26.0-nightly (ae544ee1c
2018-03-30 10:46:20 +02:00
Manish Goregaokar
b09e115404
Bump to 0.191
2018-03-30 10:38:42 +02:00
Manish Goregaokar
1d5dc3d180
Update changelog for 0.191
2018-03-30 10:38:35 +02:00
Manish Goregaokar
83748f5e48
Rustup to rustc 1.26.0-nightly ( ae544ee1c 2018-03-29)
2018-03-30 10:35:51 +02:00
Manish Goregaokar
9887b972d4
Merge pull request #2589 from rust-lang-nursery/rangearg
...
Move RangeArgument
2018-03-29 16:21:45 +02:00
Oliver Schneider
a47734c41d
Merge pull request #2579 from rust-lang-nursery/lint_audit_mcve
...
lint audit: Implementation + move one lint
2018-03-29 14:34:21 +02:00
Oliver Schneider
c1bbc173da
Address review comments
2018-03-29 13:41:53 +02:00
Manish Goregaokar
b75618206c
Move RangeArgument
2018-03-29 13:13:27 +02:00
Oliver Schneider
82e771d7dc
Document lint groups
2018-03-29 13:04:52 +02:00
Oliver Schneider
411d9c7651
Merge pull request #2585 from bjgill/use-check-manifest-handling
...
Use cargo check's manifest handling
2018-03-29 07:19:00 +02:00
Benjamin Gill
8db845c189
Delete all code for handling manifest path
...
Now that we're using cargo check, we can stop needing to find out the
manifest path ourselves. Instead, we can delegate to cargo check, which
is perfectly capable of working out for itself what needs to be built.
This fixes #1707 and #2518 .
Note that this PR will change the output. We will no longer output `bin:
foo` before each crate. This a bit unfortunate. However, given that
we're now going to be building in parallel (which is *much* faster), I
think this is acceptable - we'll be no worse than cargo itself.
2018-03-28 23:27:49 +01:00
Oliver Schneider
eafb9fe8df
Update test suite
2018-03-28 23:49:32 +02:00
Oliver Schneider
d6344c47e3
Categorize all the lints!
2018-03-28 15:24:26 +02:00
Oliver Schneider
e34a8553b0
Merge pull request #2582 from rust-lang-nursery/clippy_aint_no_compiler
...
Use cargo check instead of cargo rustc
2018-03-28 12:04:18 +02:00
Oliver Schneider
66a98d2658
Use cargo check instead of cargo rustc
2018-03-28 11:50:17 +02:00
Oliver Schneider
ef9fdbb8a9
Implementation + move one lint
2018-03-27 17:13:55 +02:00
