Commit graph

118 commits

Author SHA1 Message Date
Cameron Steffen 3a8e759d8a Update MSRV contribution docs 2021-04-26 16:07:48 -05:00
Jason Newcomb f6c5d8d599
Remove all usages of match_path, match_qpath and match_path_ast except the author lint.
Add note to fix `MATCH_TYPE_ON_DIAG_ITEM`
Add false negative test for `uninit_assumed_init`
2021-04-15 19:27:25 -04:00
Takayuki Nakata 23508a1ae2 Use uppercase for MSRV 2021-03-30 08:42:59 +09:00
flip1995 5279b5948c
Fix trailing whitespaces in doc/adding_lints.md 2021-03-26 14:36:09 +01:00
flip1995 9ce9989f59
Improve doc on how to add MSRV to a lint 2021-03-26 14:36:09 +01:00
Matthias Krüger a62e4263d5 rename cargo dev ra_setup to cargo dev ide_setup 2021-03-17 10:12:45 +01:00
Matthias Krüger 3d7a84c8bb CONTRIBUTING: update section explaining how to get ra to work inside the clippy repo 2021-03-17 10:08:44 +01:00
Matthias Krüger 0af90fd15a doc line length fixes 2021-03-11 15:47:51 +01:00
Matthias Krüger ac935781f5 docs: basics.md: mention lintcheck 2021-03-11 15:37:10 +01:00
Takayuki Nakata 06fe44e721 Add msrv to contents in adding lints md 2021-03-08 09:27:59 +09:00
Samuel E. Moelius III c7869b82a2 Update references in doc directory 2021-02-23 18:50:30 -05:00
Philipp Hansch 7226291025
Upgrade compiletest-rs to 0.6 and tester to 0.9
These updates allow us to specify multiple testnames for `TESTNAME`.

The new version of compiletest-rs also includes `bless` support, but is
not enabled with this PR.
2021-02-15 20:13:44 +01:00
xFrednet 69f2b8f0f8 Updated some NITs in the documentation from #6630 2021-01-25 19:46:19 +01:00
xFrednet 0373dc3ade Added documentation for adding a configuration to lints
* Fixed some spelling
2021-01-24 21:16:41 +01:00
xFrednet a905cf6737 Added documentation for common abbreviations
This list was created as a collaborative effort on Zulip and the [thread] is definitely worth a read as we had quite some fun. A big **THANK YOU** goes out to everyone who participated you make this project fun to work on!!!

The Zulip [thread]: https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/Common.20abbreviations.20in.20basics.2Emd/near/223548065
2021-01-22 00:25:24 +01:00
bors 13ca5c88f1 Auto merge of #6462 - flip1995:roadmap, r=flip1995,llogiq,killercup,Manishearth,oli-obk,matthiaskrgr,phansch,mikerite,mcarton,yaahc,ebroto
Roadmap for 2021

[Rendered](https://github.com/flip1995/rust-clippy/blob/roadmap/doc/roadmap-2021.md)

This is the first time Clippy gets its own roadmap. The reason for this roadmap is, that with the Rust language growing, also Clippy is growing. With this keeping track of and implementing bigger projects gets quite hard. This roadmap should help in exactly this regard.

After having the approval of this roadmap by the Clippy team, we want to know from the community:

- What do you think in general about this roadmap?
- Are there any pain points in Clippy, that should be included here?
- What of the points listed here has the highest priority for you?

We're looking forward to getting your feedback!

changelog: Add roadmap for Clippy 2021

r? `@rust-lang/clippy`
2021-01-12 16:33:47 +00:00
flip1995 547ce0db27
Change env var used for testing Clippy
This changes the variable used for testing Clippy in the internal test
suite:

```
CLIPPY_TESTS -> __CLIPPY_INTERNAL_TESTS
```

`CLIPPY_TESTS` is understandably used in environments of Clippy users,
so we shouldn't use it in our test suite.
2021-01-07 12:38:10 +01:00
flip1995 d141cdc947
Add prioritization chapter and remove unresolved questions 2021-01-04 11:39:14 +01:00
flip1995 c06793bbe7
Add Roadmap for 2021 2020-12-17 21:44:40 +01:00
Matthias Krüger 27dc565d28 cargo dev: rename ra-setup to ra_setup to be in line with the other commands 2020-12-13 18:52:46 +01:00
Philipp Hansch 4bd9ed9b88
Rewrite update-all-references bash scripts in Rust
This replaces the `update-all-references` scripts with a single

    cargo dev bless

command.

cc #5394
2020-12-12 15:09:57 +01:00
bors baf5f2da8b Auto merge of #6401 - ebroto:pin_to_a_nightly, r=ebroto
📌 Pin Clippy to a nightly 📌

changelog: Pin Clippy to a specific nightly version (No more master/custom toolchain required to compile Clippy)

Addresses partially #5561. As proposed there in [this comment](https://github.com/rust-lang/rust-clippy/issues/5561#issuecomment-623109095), this kicks off the process, to help us get acquainted with how the syncs should work, before working on improving the tooling.

Open questions:
* When performing a rustup, we will need to exclude the commits that were merged that same day, or else wait until that nightly is released. I did not update the documentation about this part, mainly because I'm not sure about how to do that.
* When should we perform the rustups now? My first idea is to do it at the same time we do the clippyups, to have a clear cadence and to avoid the two copies of the repo to diverge enough to make the process painful.
* Who does the rustups now? If we follow my previous idea and do both rustup and clippyup at the same time, it would be more work for `@flip1995` who currently does the clippyups. I would prefer to establish some kind of rotation to spead the work. Other ideas?
* I'm not sure if this affects the release process in any way.
* ???

`@rust-lang/clippy` thoughts?

r? `@flip1995`
2020-12-11 16:25:13 +00:00
Suyash458 8df11e431b add instructions to include msrv in lints 2020-12-11 11:00:25 +05:30
Eduardo Broto 613333acd5
Pin Clippy to a nightly 2020-12-10 09:57:29 +01:00
flip1995 e9afdf0740
Improve changlog update documentation 2020-11-19 11:23:59 +01:00
dp304 edfa13da4a Fix typo in adding_lints.md 2020-10-31 13:31:54 +01:00
bors 85959be606 Auto merge of #6193 - Ryan1729:add-more-LintStore-documentation, r=phansch
Add more infomation about LintStore registration

Backstory: I somehow missed the fact that I needed to register a lint pass in order for it to run, and I spent some time confused until I figured it out. So I wanted to make it clear that a missing `register_(early|late)_pass` call is a likely cause of a lint not running.

changelog: none
2020-10-20 09:38:38 +00:00
bors 74530adcba Auto merge of #6166 - achris:master, r=flip1995
Suggest a compatible shell for setup-toolchain.sh

setup-toolchain.sh uses "[[" which is a bash builtin, but the guide
suggests running it with sh.  On Ubuntu, /bin/sh points to dash and
running the script fails.

---

*Please keep the line below*
changelog: none
2020-10-19 13:17:07 +00:00
Ryan Wiedemann 67bc11bd04
Add more infomation about LintStore registration
Backstory: I somehow missed the fact that I needed to register a lint pass in order for it to run, and I spent some time confused until I figured it out. So I wanted to make it clear that a missing `register_(early|late)_pass` call is a likely cause of a lint not running.
2020-10-18 17:01:57 -06:00
Eduardo Broto 2da121d97f Fix remark linting on checkboxes 2020-10-14 23:26:48 +02:00
Chris Ayoup 8c28ba39b5 suggest a compatible shell for running setup-toolchain.sh
setup-toolchain.sh uses "[[" which is a bash builtin, but the guide
suggests running it with sh.  On Ubuntu, /bin/sh points to dash and
running the script as described fails.
2020-10-12 21:56:37 -04:00
Takayuki Nakata 377d1fab1f Remove the generated files by update-references.sh if they are empty 2020-10-11 22:57:22 +09:00
bors fcf22d90bb Auto merge of #6150 - flip1995:backport_doc_update, r=ebroto
Update backport documentation to the subtree workflow

changelog: none
2020-10-09 13:44:01 +00:00
bors ed2b457fbe Auto merge of #6148 - flip1995:release_doc, r=ebroto
Update release documentation

When updating the beta branch, we want to reset, instead of rebase. Otherwise we might produce again new commits on the beta branch, that aren't on the master branch.

changelog: none
2020-10-09 13:02:25 +00:00
bors e87c028a2a Auto merge of #6131 - Ambroisie:fix-doc-tools, r=flip1995
Rename tables to typecheck_result()

While working on #6130, I noticed that part of the documentation was updated to use `LateContext::typeck_results`, but the paragraph still referred to the old `tables` field of `LateContext`.

---

*Please keep the line below*
changelog: none
2020-10-09 12:41:08 +00:00
flip1995 7f846c930b
Update backport documentation to the subtree workflow 2020-10-09 14:16:59 +02:00
bors 2f6439ae6a Auto merge of #6136 - dtolnay:serve, r=flip1995
Clippy dev subcommand to build and serve website

This PR adds `clippy dev serve` which will pop open a browser with a local rendered 'ALL the Clippy Lints' website, and re-render as you edit stuff.

---

changelog: none
2020-10-09 08:58:19 +00:00
flip1995 c85cb76064
Update release documentation 2020-10-09 09:40:57 +02:00
Takayuki Nakata fd61686ad5 Add note that we follow a rustc no merge-commit policy 2020-10-08 23:13:06 +09:00
David Tolnay e6a71066c8
Clippy dev subcommand to build and serve website 2020-10-08 06:43:02 -07:00
Bruno BELANYI 326090dbb8
fixup! Rename tables to typecheck_result()
Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com>
2020-10-07 17:10:31 +02:00
Bruno BELANYI 9ef311b477 Rename tables to typecheck_result() 2020-10-07 11:59:20 +02:00
Takayuki Nakata b37e3cdd46 Update documentation about moving from Discord to Zulip 2020-09-17 00:10:24 +09:00
Eduardo Broto c86a7e5f38 Misc doc updates 2020-09-15 10:29:53 +02:00
Takayuki Nakata 9f827abeb0 Add reference to rustc-dev-guide about lint message 2020-08-13 09:02:49 +09:00
Camelid bd71b01a82 Make the docs clearer for new contributors
* Add an easy-to-see note at the top of `CONTRIBUTING.md` that points
  new contributors to the Basics docs
* Add a note about compiler errors as a result of internals changes
  that break Clippy
2020-08-07 16:15:44 -07:00
flip1995 3a4cc9f7f0
Address review comments 2020-07-24 23:17:52 +02:00
flip1995 17903f6d71
Mention lint naming guidelines earlier 2020-07-24 17:48:43 +02:00
flip1995 51f2a6f8b6
Add documentation for basic Clippy hacking 2020-07-22 16:46:32 +02:00
Valentin Lazureanu 5a20489c5c Rename TypeckTables to TypeckResults. 2020-07-17 08:47:04 +00:00