squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity
350 commits 1 branch 0 tags 1.1 GiB
Commit graph

350 commits

This branch
This branch
All branches
Author SHA1 Message Date
Georg Brandl
630bb76f96 new lint: type complexity (fixes #93) 
Still very naive, but it's a start.
 2015-08-22 08:57:11 +02:00
Georg Brandl
e92bf84a53 ptr_arg: fix panic when pattern type is not in tcx 2015-08-22 08:57:11 +02:00
Manish Goregaokar
e1a4248e68 Merge pull request #215 from birkenfeld/type_improvements 
Type improvements
 2015-08-22 12:13:56 +05:30
Georg Brandl
8a10440641 utils: add match_type() helper function 
which saves one level of matching when checking for type paths
 2015-08-21 19:24:38 +02:00
Georg Brandl
a437936d49 all: put often used DefPaths into utils as consts 
Also remove the "use xxx;" blocks to ensure import paths don't change.
They don't work anyway since stuff may still be re-exported at the old
location, while we need the "canonical" location for the type checks.

Plus, the test suite catches all these cases.
 2015-08-21 19:23:05 +02:00
Georg Brandl
707e95f2e5 types: use middle::ty types instead of ast types 
This gets rid of the match_ty_unwrap function.
 2015-08-21 19:21:19 +02:00
Georg Brandl
b2df15d65a ptr_arg improvements (fixes #214) 
* do not trigger on mutable references
* use "real" type from ty, not AST type
 2015-08-21 19:21:18 +02:00
llogiq
6ffe1ed337 Merge pull request #212 from Manishearth/eq_op_const 
Eq op const
 2015-08-21 12:30:53 +02:00
llogiq
a22b3cdcee const folding for eq_op 2015-08-21 12:26:03 +02:00
llogiq
4dcbad1b08 const folding for eq_op 2015-08-21 12:19:07 +02:00
llogiq
d3793865c4 Merge pull request #208 from Robzz/iss114 
Implementation of lossy cast lints (issue #114)
 2015-08-21 07:49:19 +02:00
R.Chavignat
ad0bc66402 Added support for isize/usize in the CastPass lint pass. 
Extracted the match that determines an integer types's size in a
utility function and implemented support for usize/isize.
Added a needed feature to the crate root.
Added some tests to cover those cases, and a test I previously forgot.
Silenced two errors signaled by dogfood.sh in unicode.rs.
 2015-08-21 03:03:37 +02:00
R.Chavignat
dbc9b7f46e Reworked the error messages for more heplfulness. 
Renamed the cast_possible_overflow lint to cast_possible_truncation,
and updated the error message, readme and crate root accordingly.
Added some more information to the message for the cast_precision_loss
lint.
Updated the test case to reflect changes.
 2015-08-20 22:44:40 +02:00
R.Chavignat
ab481e5cb1 Refactored the CastPass lints. 2015-08-20 21:37:37 +02:00
R.Chavignat
ff28dd324e Fixed a little oversight. 2015-08-20 14:50:26 +02:00
R.Chavignat
14528d433a Simplified reexported ast::* type paths. 
Also removed trailing whitespaces.
 2015-08-20 14:46:40 +02:00
R.Chavignat
b417f01ed8 Also test that the CastExpr's right arm is numeric. 2015-08-20 14:36:26 +02:00
R.Chavignat
93d9249f76 Moved allow(unknown_lints) to crate level. 2015-08-20 14:25:08 +02:00
R.Chavignat
1846581baa Added examples to lint descriptions. 2015-08-20 14:24:26 +02:00
Manish Goregaokar
c91857c62d Merge pull request #209 from Manishearth/where_credit_is_due 
give credit where credit is due
 2015-08-20 12:31:05 +05:30
llogiq
36ef03158f give credit where credit is due 2015-08-20 08:59:07 +02:00
R.Chavignat
993239d33a Initial implementation of lossy cast lints. 
Introduces 3 lints :
  cast_possible_overflow
  cast_precision_loss
  cast_sign_loss
Add a compile-test test case.
Fix errors spotted by dogfood script.
 2015-08-20 01:04:06 +02:00
llogiq
150840667e Merge pull request #204 from Manishearth/bit-mask 
Extend and correct the ineffective_bit_mask check
 2015-08-19 13:25:43 +02:00
llogiq
85f7f4c9b4 Merge pull request #205 from Manishearth/const 
Mul and Div for integers
 2015-08-19 13:24:59 +02:00
llogiq
973d5e5c6b Mul and Div for integers 2015-08-19 11:58:59 +02:00
llogiq
98d24b5b56 fixed #203 and #197 2015-08-19 09:39:03 +02:00
llogiq
bbc917fef0 Merge pull request #202 from birkenfeld/unit_cmp 
new lint: comparing unit types (fixes #201)
 2015-08-19 08:34:19 +02:00
Georg Brandl
8f4499f3ae new lint: comparing unit types (fixes #201) 2015-08-19 08:11:00 +02:00
Manish Goregaokar
7ddc402127 Merge pull request #200 from Manishearth/consts 
more small const improvements
 2015-08-18 18:41:30 +05:30
llogiq
9f67ba7f8d re-applied birkenfeld's improvements 2015-08-18 14:18:36 +02:00
llogiq
6e0c103133 more small const improvements 2015-08-18 12:26:01 +02:00
llogiq
6182445cf5 Merge pull request #198 from birkenfeld/const_enh 
consts: minor improvements
 2015-08-18 11:29:03 +02:00
Georg Brandl
49ad73f6e4 consts: minor improvements 2015-08-18 11:07:13 +02:00
llogiq
8a9e03dd9f Merge pull request #196 from birkenfeld/const_struct 
[rfc] consts: convert to using a struct with state
 2015-08-18 11:02:04 +02:00
Georg Brandl
7f52239cab consts: convert to using a struct with state 
Struct has the context reference (as an Option) and the
needed_resolution flag.
 2015-08-17 19:58:21 +02:00
llogiq
202e66708e Merge pull request #195 from birkenfeld/impl_const_not 
const eval: implement ! for integers
 2015-08-17 17:02:26 +02:00
Georg Brandl
a2dcbfea65 const eval: implement ! for integers 2015-08-17 16:45:56 +02:00
llogiq
26f17e8c4a Merge pull request #194 from Manishearth/consts_neg_zero 
added test and fixed negativity check in Partial{Eq, Ord} impl
 2015-08-17 16:29:02 +02:00
llogiq
a2ee637be6 added test and fixed negativity check in Partial{Eq, Ord} impl 2015-08-17 16:24:57 +02:00
llogiq
59d0ae8739 Merge pull request #193 from Manishearth/const_bitop 
Added bit operations to const folding
 2015-08-17 15:15:21 +02:00
llogiq
c47402416b Added bit operations to const folding 2015-08-17 15:11:36 +02:00
llogiq
d7ec53b52f Merge pull request #192 from Manishearth/const_cmp 
Const cmp
 2015-08-17 13:25:40 +02:00
llogiq
4394362836 dogfooding 2015-08-17 13:23:17 +02:00
llogiq
9f134f8e95 added PartialEq/PartialOrd to ConstantVariant, used to implement comparing binops 2015-08-17 13:18:14 +02:00
llogiq
5087913304 Merge pull request #191 from Manishearth/fix-165 
Closes #165
 2015-08-17 12:11:32 +02:00
llogiq
0e67c0134f make float_cmp check for zero 2015-08-17 12:08:45 +02:00
llogiq
e354fdc3e8 added regression test for #189 2015-08-17 12:08:45 +02:00
llogiq
fb715ce45d fix 189, fixed a few warnings, ==/!= for consts, refactored consts test 2015-08-17 12:08:45 +02:00
llogiq
d3bdc6d1bf Merge pull request #190 from Manishearth/fix-189 
Fix 189
 2015-08-17 11:49:05 +02:00
llogiq
f7677b03e1 added regression test for #189 2015-08-17 11:46:45 +02:00