squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity
15623 commits 1 branch 0 tags 1.1 GiB
Commit graph

15623 commits

This branch
This branch
All branches
Author SHA1 Message Date
Aleksey Kladov
bf4aaa4fb0 Underengineer cargo xtask install --client 2021-03-05 20:42:41 +03:00
bors[bot]
2b55cce49e
Merge #7880 
7880: Honor snippet capability when using the extract function assist r=lnicola a=Arthamys

This fixes issue #7793

Co-authored-by: san <san@alien.parts>
 2021-03-05 16:24:32 +00:00
san
769b3bca28 Honor snippet capability in extract function assist 2021-03-05 17:20:26 +01:00
bors[bot]
6c27c55041
Merge #7870 
7870: Use chalk_ir::AdtId r=Veykril a=Veykril

It's a bit unfortunate that we got two AdtId's now(technically 3 with the alias in the chalk module but that one won't allow pattern matching), one from hir_def and one from chalk_ir(hir_ty). But the hir_ty/chalk one doesn't leave hir so it shouldn't be that bad I suppose. Though if I see this right this will happen for almost all IDs.

I imagine most of the intermediate changes to using chalk ids will turn out not too nice until the refactor is over.

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
 2021-03-05 16:04:49 +00:00
bors[bot]
25a43e24c8
Merge #7879 
7879: Fix some warnings r=lnicola a=lnicola

bors r+

Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
 2021-03-05 14:12:19 +00:00
Laurențiu Nicola
42057896bc Fix some warnings 2021-03-05 15:59:50 +02:00
bors[bot]
9707acb59b
Merge #7876 
7876: Cleanup install command r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
 2021-03-05 08:52:07 +00:00
Aleksey Kladov
142f9a03fd Cleanup install command 2021-03-05 11:51:32 +03:00
Aleksey Kladov
97b1550dda Fix regression where the client was not installed 2021-03-05 11:12:40 +03:00
Lukas Wirth
50e01d2bc7 Use chalk_ir::AdtId 2021-03-04 19:38:02 +01:00
bors[bot]
16a76aa158
Merge #7868 
7868: Migrate to user-centric config name for `cargo check` stuff r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
 2021-03-04 12:39:36 +00:00
Aleksey Kladov
3d80e0a154 Migrate to user-centric config name for cargo check stuff 2021-03-04 15:38:53 +03:00
Edwin Cheng
cc8c40480a Print warning if proc-macro built by old rustc 2021-03-04 14:47:34 +08:00
Jay Somedon
0669abda4a Revise error message regarding metadata version 
Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
 2021-03-04 09:15:28 +08:00
Jay Somedon
a8f7326ee5 Update condition check code style 
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
 2021-03-04 09:11:43 +08:00
Jay Somedon
c92db2abf9 Update comment 
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
 2021-03-04 09:11:43 +08:00
Jay Somedon
55d73bc675 Fix multiple issues from code review 
* check metadata version
* use memmap
* use Result instead of unwrap

with Jay Somedon <jay.somedon@outlook.com>
 2021-03-04 09:11:33 +08:00
Jay Somedon
8fd7cd7406 Configure object crate's feature 
Signed-off-by: Jay Somedon <jay.somedon@outlook.com>
 2021-03-04 09:05:41 +08:00
Jay Somedon
6608acef71 Read version of rustc that compiled proc macro 
With Jay Somedon <jay.somedon@outlook.com>
 2021-03-04 09:05:23 +08:00
bors[bot]
7275750e42
Merge #7866 
7866: Complete `while let` r=Veykril a=Veykril

bors r+

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
 2021-03-03 22:05:38 +00:00
Lukas Wirth
02e9440e23 Complete while let 2021-03-03 23:04:11 +01:00
Domantas Jadenkus
5bb4aec05f preserve escape sequences when replacing string with char 2021-03-03 23:20:18 +02:00
Lukas Wirth
1914b7723f Don't complete super unless its valid in paths 2021-03-03 21:58:48 +01:00
bors[bot]
d0fa7abc50
Merge #7863 
7863: Prevent renaming SelfType and BuiltinType r=Veykril a=Veykril

bors r+

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
 2021-03-03 18:49:43 +00:00
Lukas Wirth
e194f2edc4 Prevent renaming SelfType and BuiltinType 2021-03-03 19:48:53 +01:00
Lukas Wirth
183ba483a9 Reorder functions in rename.rs 2021-03-03 19:48:35 +01:00
bors[bot]
607716d213
Merge #7862 
7862: Remove incorrect broken test r=jonas-schievink a=jonas-schievink

`Struct` cannot be named at all in that position, since `super` doesn't
resolve to the block scope

bors r+

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
 2021-03-03 18:11:56 +00:00
Jonas Schievink
1c057dc3c1 Remove incorrect broken test 
`Struct` cannot be named at all in that position, since `super` doesn't
resolve to the block scope
 2021-03-03 19:10:56 +01:00
bors[bot]
603481f534
Merge #7861 
7861: Special-case parenthesized and negated expressions in demorgan assist r=lnicola a=Jesse-Bakker

Fixes #7831 

Co-authored-by: Jesse Bakker <github@jessebakker.com>
 2021-03-03 13:29:56 +00:00
Jesse Bakker
1363d60111 Special-case parenthesized and negated expressions in demorgan assist 2021-03-03 13:18:24 +01:00
bors[bot]
2b22fc929a
Merge #7858 
7858: Clarify comparison rule r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
 2021-03-03 08:23:38 +00:00
Aleksey Kladov
e15621482c Clarify comparison rule 2021-03-03 11:23:05 +03:00
bors[bot]
3b507aa90f
Merge #7853 
7853: Update lexer r=kjeremy a=kjeremy



Co-authored-by: kjeremy <kjeremy@gmail.com>
 2021-03-02 20:34:24 +00:00
kjeremy
41d1b4cd26 Update lexer 2021-03-02 15:33:22 -05:00
bors[bot]
0f8ee46edc
Merge #7852 
7852: bump once_cell r=kjeremy a=kjeremy



Co-authored-by: kjeremy <kjeremy@gmail.com>
 2021-03-02 17:42:20 +00:00
kjeremy
58697afca4 bump once_cell 2021-03-02 12:41:20 -05:00
bors[bot]
0ce539ec96
Merge #7851 
7851: Compress tests r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
 2021-03-02 15:46:02 +00:00
Aleksey Kladov
8471da62e6 Compress tests 2021-03-02 18:35:52 +03:00
bors[bot]
04abf80b5f
Merge #7824 
7824: feat: add type ascription r=matklad a=conradludgate

Based on this conversation: https://twitter.com/rust_analyzer/status/1366092401278922757
Built off of `add_turbo_fish`, finds the current `let` statement, checks if it has type/turbofish already and checks if the rhs function is generic.

There's one case I couldn't figure out how to implement that would be nice:

```rust
#[test]
fn add_type_ascription_function_result() {
    check_assist(
        add_type_ascription,
        r#"
fn make<T>() -> Result<T, &'static str> {}
fn main() {
    let x = make()$0;
}
"#,
        r#"
fn make<T>() -> Result<T, &'static str> {}
fn main() {
    let x: Result<${0:_}, &'static str> = make();
}
"#,
    );
}
```

The `Function::ret_type` fn wasn't returning anything much useful so I'm not sure how to identity such scenarios just yet

Co-authored-by: Conrad Ludgate <conradludgate@gmail.com>
 2021-03-02 15:28:41 +00:00
Conrad Ludgate
2c3c728e0a
chore: remove redundant tests 2021-03-02 15:26:36 +00:00
Conrad Ludgate
9a49735d30
chore: remove deleted file path 2021-03-02 15:02:47 +00:00
Conrad Ludgate
b41e73ac12
chore: codegen 2021-03-02 14:55:37 +00:00
Conrad Ludgate
d4fad2be8d
refactor: re-use add_turbo_fish function 2021-03-02 14:30:11 +00:00
Conrad Ludgate
4a36129c7a
chore: fmt + docs 2021-03-02 14:30:10 +00:00
Conrad Ludgate
218390b9fb
chore: rename var 2021-03-02 14:30:10 +00:00
Conrad Ludgate
705712993f
feat: add type ascription assist 2021-03-02 14:30:10 +00:00
bors[bot]
f8152171bb
Merge #7850 
7850: Don't add space when joining line to opening quote r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
 2021-03-02 14:19:45 +00:00
Aleksey Kladov
e2fc9411f1 Don't add space when joining line to opening quote 2021-03-02 17:18:45 +03:00
bors[bot]
8e7c42d1be
Merge #7849 
7849: Fix xflags fallout r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
 2021-03-02 13:54:56 +00:00
Aleksey Kladov
84483f672f Fix xflags fallout 
https://github.com/rust-analyzer/rust-analyzer/pull/7847#issuecomment-788920830
 2021-03-02 16:50:03 +03:00