squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity
5809 commits 1 branch 0 tags 1.1 GiB
Commit graph

5809 commits

This branch
This branch
All branches
Author SHA1 Message Date
Michael Wright
131c8f6bf2 Add [rustfmt::skip] to doc_markdown tests 2019-03-07 08:03:15 +02:00
bors
00baf7a111 Auto merge of #3803 - felix91gr:master, r=oli-obk 
Cognitive Complexity (step 1 out of 3+): name changes

Following up on #3793

**Overall checklist:**

1. **Name changes**
2. MVP of functionality
3. Tests

After this PR, we will start working on the implementation itself.
 2019-03-06 13:41:31 +00:00
Félix Fischer
ddc718087f Renamed: Cyclomatic Complexity -> Cognitive Complexity 
* Ran automatic naming update

* Formalized rename of `cyclomatic_complexity` to `cognitive_complexity`
** Added the rename to `lib.rs`
** Added rename test

* Added warning for deprecated key `cyclomatic_complexity_threshold` and tests for it

* Added deprecation status for Clippy's builtin attribute

* Updated tests for new builtin attribute renaming
 2019-03-06 10:07:38 -03:00
bors
15d1731ce8 Auto merge of #3845 - euclio:unused-comments, r=phansch 
move lint documentation into macro invocations

This PR moves lint documentation inside `declare_clippy_lint!` macro invocations, to avoid triggering the `unused_doc_comments` lint once it's modified in rust-lang/rust#57882. This PR is necessary to unblock that work, since the large number of warnings generated in `clippy_lints` causes Travis to hit the log length limit.

This PR also updates the documentation and website generation script.

It would be nice to get a clippy update in the Rust repo once this is merged.

cc @phansch
 2019-03-06 06:48:26 +00:00
bors
400ee06789 Auto merge of #3846 - mikerite:fix-3839, r=phansch 
Ensure `expect_fun_call` bad suggestion is fixed

Closes #3839
 2019-03-06 05:54:48 +00:00
Michael Wright
464ed58861 Ensure expect_fun_call bad suggestion is fixed 
Closes #3839
 2019-03-06 07:00:05 +02:00
Andy Russell
a9de64a151
fix or ignore failing doc tests 2019-03-05 18:45:08 -05:00
Andy Russell
fe96ffeac9
move lint documentation into macro invocations 2019-03-05 18:45:08 -05:00
bors
a8f61e70a8 Auto merge of #3844 - phansch:const_fn_external_macro, r=oli-obk 
Fix two missing_const_for_fn false positives

Fixes #3841

* Fixes false positive in external macros
* Fixes false positive when implement trait methods
 2019-03-05 10:12:53 +00:00
Philipp Hansch
15cba2e956
Fix missing_const_for_fn for impl trait methods 2019-03-05 08:11:55 +01:00
Philipp Hansch
b87f5bc55a
Don't trigger missing_const_for_fn in external macros 
As reported in #3841. Only fixes the part where it triggers on the
`derive`.
 2019-03-04 22:56:33 +01:00
Philipp Hansch
3c67c629fd
Add rustc nightly docs to cheatsheet 2019-03-04 20:43:11 +01:00
Philipp Hansch
d1caaa47c0
s/you/we; One more checklist item 2019-03-04 20:39:28 +01:00
bors
caccf8bd4c Auto merge of #3838 - mati865:rustup, r=phansch 
Upgrade compiletest_rs to 0.3.19
 2019-03-03 15:09:00 +00:00
Mateusz Mikuła
da2cf8764a Upgrade compiletest_rs to 0.3.19 2019-03-03 16:02:59 +01:00
Philipp Hansch
8d2cbb94d4
Add the rustc guide to the cheatsheet 2019-03-03 15:03:25 +01:00
Philipp Hansch
23f3256e96
More text fixes after Test section was moved to top 2019-03-03 15:03:25 +01:00
Philipp Hansch
0da3521eb6
Reword 'Setup' a bit 2019-03-03 15:03:25 +01:00
Philipp Hansch
b03011480c
Note that stderr files don't have to be created manually 2019-03-03 15:03:25 +01:00
Philipp Hansch
81f47e1ffc
Author lint usage via playground 2019-03-03 15:03:25 +01:00
Philipp Hansch
680dc8a105
Run remark in doc directory, too. 2019-03-03 15:03:25 +01:00
Philipp Hansch
1eac53b06b
Cleanup 'Writing code' in CONTRIBUTING.md 
This is now all included in `doc/adding_lints.md`
 2019-03-03 15:03:25 +01:00
Philipp Hansch
68d04eda7b
Copy from CONTRIBUTING.md: author lint, rustfix tests, rustfmt 
And adapt the wording a bit so that it fits in the overall guide.
 2019-03-03 15:03:25 +01:00
Philipp Hansch
ca35e6750e
Mention Clippy utils 2019-03-03 15:03:25 +01:00
Philipp Hansch
81ad4427a4
Remind to run update-all-references.sh at the end 2019-03-03 15:03:25 +01:00
Philipp Hansch
9ff1340a69
Use positive if condition for readability 2019-03-03 15:03:25 +01:00
Philipp Hansch
2851f9f707
Expand on lint implementation section, wrap lines 2019-03-03 15:03:25 +01:00
Wilco Kusee
ef97c13f5e
Implicit return 
Co-Authored-By: phansch <dev@phansch.net>
 2019-03-03 15:03:25 +01:00
Wilco Kusee
c83b0298d7
Implicit return 
Co-Authored-By: phansch <dev@phansch.net>
 2019-03-03 15:03:25 +01:00
Philipp Hansch
12b2696634
Add lint writing documentation 
This adds a new documentation page that explains how to write Clippy
lints. It guides the reader through creating a `foo` function lint.
 2019-03-03 15:03:25 +01:00
bors
9d1792a426 Auto merge of #3834 - ljedrz:HirIdification_fix, r=phansch 
HirIdification fixes

Supersedes https://github.com/rust-lang/rust-clippy/pull/3828, enables https://github.com/rust-lang/rust/pull/58836.

As usual, requesting a branch.
 2019-03-03 12:26:15 +00:00
Philipp Hansch
68096cf181
fmt fixes 2019-03-03 13:05:39 +01:00
ljedrz
f3363b9cf2 align with rust-lang/rust/#58836 2019-03-01 19:10:14 +01:00
ljedrz
f2587703cc enable rust-lang/rust#58754 2019-03-01 19:10:14 +01:00
bors
8dfabdf11c Auto merge of #3823 - spastorino:place_base, r=flip1995 
Place::Local(x) is now Place::Base(PlaceBase::Local(x))

We need to merge this after the beta cut for this https://github.com/rust-lang/rust/pull/58631 to work.
/cc @oli-obk
 2019-03-01 16:03:15 +00:00
Santiago Pastorino
77a67c914d
Place::Local(x) is now Place::Base(PlaceBase::Local(x)) 2019-03-01 12:20:17 -03:00
bors
9f2055637e Auto merge of #3833 - mati865:rustup, r=oli-obk 
Fix build with the master

https://github.com/rust-lang/rust/pull/58689 broke compiletest.
 2019-03-01 12:51:11 +00:00
Mateusz Mikuła
df8a489793 Use temporary branch for compiletest 
https://github.com/rust-lang/rust/pull/58689 broke it
 2019-03-01 11:54:25 +01:00
bors
cfdf47e8b0 Auto merge of #3831 - martin-t:master, r=flip1995 
Use the same <title> as <h1> on gh-pages

I think this makes the page easier to find using firefox's URL bar - it (afaik) searches based on the page's URL and title so if somebody doesn't have it bookmarked but remembers that the page contained "ALL lints" or something similar it's easy to go to it directly without resorting to a search engine.
 2019-02-28 19:56:25 +00:00
bors
275a3864b8 Auto merge of #3830 - flip1995:unknown_attribute, r=oli-obk 
Error on unknown or deprecated attributes

The reason I decided to not make this a lint is, that unknown attributes are always a hard error in rustc and also in rustfmt, which cannot be turned off by an `allow`. This could have been done by introducing a category which would be forbid-by-default. But that would have introduced a new lint category+group for just one lint and also wouldn't be consistent with rustfmt and rustc.
 2019-02-28 19:20:06 +00:00
flip1995
c4eb780156
Add test for unknown Clippy attributes 2019-02-28 20:18:42 +01:00
Martin Taibr
3f7d0c8d75 Use the same <title> as <h1> on gh-pages 2019-02-28 19:17:10 +01:00
flip1995
1463d6f69f
Error an unknown or deprecated Clippy attribute 2019-02-28 16:44:42 +01:00
bors
f69ec96906 Auto merge of #3829 - mikerite:fix-double-parens-suggestions, r=flip1995 
Add `rustfmt::skip` to `double_parens` tests
 2019-02-28 10:09:00 +00:00
Michael Wright
6e6e39b4a8 Add rustfmt::skip to double_parens tests 2019-02-28 08:02:45 +02:00
bors
ff2798840c Auto merge of #3666 - detrumi:map-or-on-non-copy, r=flip1995 
Only suggest map_or for copy types

Fixes #2686
 2019-02-27 08:28:48 +00:00
bors
58c0dc1db6 Auto merge of #3826 - mikerite:rustfmt-outer-attr-tests, r=phansch 
Add `rustfmt::skip` to outer attr format tests
 2019-02-27 06:49:09 +00:00
bors
e46a8df833 Auto merge of #3827 - phansch:rustup, r=Manishearth 
Rustup rust-lang/rust#58321

Fixes the build after https://github.com/rust-lang/rust/issues/58321
 2019-02-27 06:28:08 +00:00
Philipp Hansch
982a99d2c4
Rustup https://github.com/rust-lang/rust/pull/58321 2019-02-27 07:20:49 +01:00
Michael Wright
11682b4cd2 Add rustfmt::skip to outer attr format tests 2019-02-27 07:41:07 +02:00