Yoshitomo Nakanishi
25d8b94cec
Add comments to clarify why RetCollector is needed
2021-04-01 00:05:42 +09:00
Yoshitomo Nakanishi
ccd7a60023
Refactor: Remove duplicated codes from excessive_for_each
2021-04-01 00:05:42 +09:00
Yoshitomo Nakanishi
90cbbb2da3
Avoid to suggest using label
2021-04-01 00:05:42 +09:00
Yoshitomo Nakanishi
5bb0f16552
Trigger the lint iff exposure's body is ExprKind::Block.
2021-04-01 00:05:42 +09:00
Yoshitomo Nakanishi
54a04711ed
Change a category of excessive_for_each: Style -> Restriction
2021-04-01 00:05:42 +09:00
Yoshitomo Nakanishi
30952530c5
Fix codes that fails dogfood
2021-04-01 00:05:42 +09:00
Yoshitomo Nakanishi
5029dc805f
New Lint: excessive_for_each
2021-04-01 00:05:42 +09:00
bors
2e33bf6347
Auto merge of #6938 - Y-Nak:refactor-types, r=flip1995
...
Refactor types
r? `@flip1995`
This is the last PR to close #6724 🎉
Also, this fixes #6936 .
changelog: `vec_box`: Fix FN in `const` or `static`
changelog: `linkedlist`: Fix FN in `const` or `static`
changelog: `option_option`: Fix FN in `const` or `static`
2021-03-31 14:35:48 +00:00
bors
0b76719638
Auto merge of #7007 - Y-Nak:result_unit_err, r=giraffate
...
result_unit_err: Fix typo
changelog: result_unit_err: fix typo in a diagnostic message
r? `@giraffate`
fixes https://github.com/rust-lang/rust-clippy/pull/6990#discussion_r603292920 .
2021-03-31 04:01:15 +00:00
Yoshitomo Nakanishi
45164de59f
result_unit_err: Fix typo
2021-03-31 11:18:48 +09:00
bors
4be72b0936
Auto merge of #7001 - ebobrow:non-octal-file-permissions, r=Manishearth
...
Add non_octal_unix_permissions lint
fixes #6934
changelog: add new lint that checks for non-octal values used to set unix file permissions
2021-03-30 23:23:50 +00:00
Elliot Bobrow
7fcd155712
Add non_octal_unix_permissions lint
2021-03-30 16:04:16 -07:00
bors
44bf60f62d
Auto merge of #7004 - Jarcho:manual_map_if_then_else, r=camsteffen
...
Fix `manual_map` at the end of an if chain
changelog: Fix `manual_map` suggestion at the end of an if chain
2021-03-30 14:03:54 +00:00
Jason Newcomb
fa689f865e
Fix manual_map at the end of an if chain
2021-03-30 09:58:23 -04:00
bors
0552852d9a
Auto merge of #7000 - Jarcho:clone_on_copy_fp, r=llogiq
...
Improve `clone_on_copy`
This also removes the `clone_on_copy_mut` test as the same thing is covered in the `clone_on_copy` test.
changelog: `copy_on_clone` lint on chained method calls taking self by value
changelog: `copy_on_clone` only lint when using the `Clone` trait
changelog: `copy_on_clone` correct suggestion when the cloned value is a macro call.
2021-03-30 05:25:28 +00:00
bors
1ddeaa6356
Auto merge of #6990 - Y-Nak:refactor-functions, r=giraffate
...
Organize functions into functions module
Ref: #6680
Rearrange lints in `functions`.
changelog: none
2021-03-30 03:59:45 +00:00
Yoshitomo Nakanishi
541c8b8f69
Improve documents in functions group
2021-03-30 11:45:54 +09:00
Jason Newcomb
d2657769a2
Improve clone_on_copy
...
Lint on `_.clone().method()` when method takes self by value
Set applicability correctly
Correct suggestion when the cloned value is a macro call. e.g. `m!(x).clone()`
Don't lint when not using the `Clone` trait
2021-03-29 16:10:37 -04:00
Yoshitomo Nakanishi
31afdfc12b
missing_panics_doc: Ignore usage of debug_assert family
2021-03-29 17:20:04 +09:00
bors
c07103b4a2
Auto merge of #6993 - Jarcho:expl_impl_clone, r=llogiq
...
Improve `expl_impl_clone_on_copy`
fixes : #1254
changelog: Check to see if the generic constraints are the same as if using derive for `expl_impl_clone_on_copy`
2021-03-28 23:30:56 +00:00
Jason Newcomb
879fa5c972
Improve expl_impl_clone_on_copy
...
Check to see if the generic constraints are the same as if using derive
2021-03-28 07:54:00 -04:00
Matthias Krüger
e006c77d61
redundant_pattern_matching: look inside Refs
...
look inside refs and detect if let &None = ...
Fixes https://github.com/rust-lang/rust-clippy/issues/5396
changelog: redundant_pattern_matching: look inside Refs to fix FNs with "if let &None = .. "
2021-03-28 00:04:44 +01:00
Yoshitomo Nakanishi
add3e5094f
Move result_unit_err to its own module
2021-03-27 22:49:55 +09:00
Yoshitomo Nakanishi
c37916501d
Move lints related to must_use to their own module
2021-03-27 22:49:55 +09:00
Yoshitomo Nakanishi
9782fc4285
move not_unsafe_ptr_arg_deref to its own module
2021-03-27 22:49:55 +09:00
Yoshitomo Nakanishi
7c028de05f
Move too_many_lines to its own module
2021-03-27 22:49:55 +09:00
Yoshitomo Nakanishi
febf34e2b4
Move too_many_arguments to its own module
2021-03-27 22:49:55 +09:00
bors
8e56a2b27f
Auto merge of #6979 - flip1995:msrv_doc_fix, r=giraffate
...
Add missing lints to MSRV config doc
r? `@giraffate`
changelog: Add missing lints to MSRV config doc
2021-03-27 13:27:51 +00:00
bors
dcee00d64b
Auto merge of #6980 - Jarcho:len_without_is_empty_sig, r=llogiq
...
`len_without_is_empty` improvements
fixes : #6958
fixes : #6972
changelog: Check the return type of `len`. Only integral types, or an `Option` or `Result` wrapping one.
changelog: Ensure the return type of `is_empty` matches. e.g. `Option<usize>` -> `Option<bool>`
2021-03-27 13:10:43 +00:00
Jason Newcomb
12985afbca
len_without_is_empty improvements
...
Check the return type of `len`. Only integral types, or an `Option` or `Result` wrapping one.
Ensure the return type of `is_empty` matches. e.g. `Option<usize>` -> `Option<bool>`
2021-03-27 09:04:44 -04:00
flip1995
5351bbfbf5
Add missing lints to MSRV config doc
2021-03-26 16:58:06 +01:00
bors
6f2a6fe84f
Auto merge of #6977 - flip1995:or_patterns_msrv, r=llogiq
...
Add MSRV options to `unnested_or_patterns`
changelog: [`unnested_or_patterns`] can now be configured with the `msrv` config/attribute.
Fixes #6953
2021-03-26 15:12:50 +00:00
flip1995
1a1adad81d
Add MSRV option to unnested_or_patterns lint
2021-03-26 14:36:09 +01:00
Yoshitomo Nakanishi
818f8320a3
Merge type_complexity pass into types pass
2021-03-26 20:22:07 +09:00
Yoshitomo Nakanishi
494bc8a30c
Fix FN that types lints don't work with const or static
2021-03-26 20:19:34 +09:00
Yoshitomo Nakanishi
dad39b6613
Move implicit_hasher to its own module
2021-03-26 20:18:37 +09:00
Yoshitomo Nakanishi
f231b59b9e
Move invalid_upcast_comparisons to its own module
2021-03-26 20:18:37 +09:00
Yoshitomo Nakanishi
caa49c85d6
Move absurd_extreme_comparisons to its own module
2021-03-26 20:18:37 +09:00
Jason Newcomb
0ff68bb151
Improve redundant_slicing
...
Fix bad suggestion when a reborrow might be required
Fix bad suggestion when the value being sliced is a macro call
Don't lint inside of a macro due to the previous context sensitive changes
2021-03-25 22:30:14 -04:00
flip1995
40e68e5956
Bump Clippy Version -> 0.1.53
2021-03-25 18:48:48 +01:00
flip1995
1f5f184105
Merge remote-tracking branch 'upstream/master' into rustup
2021-03-25 18:38:13 +01:00
bors
981ffa7c14
Auto merge of #6959 - ebobrow:iss-6927-fix, r=camsteffen
...
Check for `.to_string().into_bytes()` in string_lit_to_bytes
fixes #6927
changelog: Add a check for `into_bytes()` to string_lit_to_bytes lint
2021-03-25 03:01:35 +00:00
Elliot Bobrow
e9ebc27525
check for .to_string().into_bytes() in string_lit_to_bytes
...
apply changes from review
2021-03-24 17:31:20 -07:00
Jason Newcomb
6e88900f9e
Rename contains_adt to contains_adt_constructor
2021-03-24 16:23:02 -04:00
Jason Newcomb
99b8a67198
Fix false positive with new_ret_no_self when returning Self with different generic arguments
2021-03-24 16:22:28 -04:00
Takayuki Maeda
2f8d71b9dc
merge imports
2021-03-25 00:17:43 +09:00
Takayuki Maeda
3b8e85a5dc
fix false positive in manual_flatten
2021-03-25 00:15:21 +09:00
bors
919a1a40fe
Auto merge of #6957 - camsteffen:eq-ty-kind, r=flip1995
...
Factor out `SpanlessEq::eq_ty_kind`
changelog: none
2021-03-23 16:25:28 +00:00
Cameron Steffen
9132dbdf31
Factor out eq_ty_kind
2021-03-23 10:49:12 -05:00
bors
b80903b727
Auto merge of #6950 - Sciencentistguy:master, r=phansch
...
Ignore str::len() in or_fun_call lint.
changelog: Changed `or_fun_call` to ignore `str::len`, in the same way it ignores `slice::len` and `array::len`
Closes #6943
2021-03-22 20:29:13 +00:00
