squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity
438 commits 1 branch 0 tags 1.1 GiB
Commit graph

438 commits

This branch
This branch
All branches
Author SHA1 Message Date
Manish Goregaokar aa4a135e97 Merge branch 'master' of github.com:Manishearth/rust-clippy 2015-08-25 22:34:36 +05:30
Georg Brandl 6fa34cca29 methods: suggest correct replacement for to_string() (fixes #232) 2015-08-25 18:39:21 +02:00
Georg Brandl ffed5b0b23 loops: use a whitelist for the "x.iter() -> &x" lint (fixes #236) 2015-08-25 18:28:05 +02:00
llogiq bd22521af2 shadowing detection 2015-08-25 17:36:46 +02:00
Georg Brandl b13d318f48 all: remove unneeded deref and/or ref operations 2015-08-25 17:35:20 +02:00
Georg Brandl 88047a0953 collapsible_if: remove extraneous note output 
This was probably a debug addition.
 2015-08-25 17:35:20 +02:00
Manish Goregaokar 53d72faca4 Merge pull request #235 from birkenfeld/fix 
all: remove unneeded deref and/or ref operations
 2015-08-25 19:07:56 +05:30
Georg Brandl 92a3394065 all: remove unneeded deref and/or ref operations 2015-08-25 14:41:35 +02:00
llogiq 3fe85d457c Merge pull request #233 from birkenfeld/fix 
collapsible_if: remove extraneous note output
 2015-08-25 13:43:37 +02:00
llogiq 5225feceaa shadowing detection 2015-08-25 13:40:26 +02:00
Georg Brandl d5c808acd0 collapsible_if: remove extraneous note output 
This was probably a debug addition.
 2015-08-25 13:27:21 +02:00
llogiq 125f08d2c6 Merge pull request #231 from birkenfeld/to_string_hint 
methods: people might be using to_string() to make a copy; add a hint…
 2015-08-25 12:55:09 +02:00
Georg Brandl 81ef3da03c methods: people might be using to_string() to make a copy; add a hint for that 2015-08-25 12:46:29 +02:00
Georg Brandl 64cd1fc6ba eq_op: cut back to expressions that are guaranteed side effect free 
fixes #229
 2015-08-25 12:34:37 +02:00
Georg Brandl 56e8db476c new lint: inherent methods that should be trait impls (fixes #218) 2015-08-25 11:10:42 +02:00
llogiq 209e6981a3 shadowing detection 2015-08-24 16:59:02 +02:00
llogiq 802d56c46c Merge pull request #227 from Manishearth/readme 
improved README, added lint counter
 2015-08-24 16:54:45 +02:00
llogiq 380e41a914 improved README, added lint counter 2015-08-24 16:49:12 +02:00
llogiq 961f9d68a9 Merge pull request #226 from birkenfeld/fixes 
Two small fixes/refactorings
 2015-08-24 16:21:17 +02:00
llogiq 45533bb03e Merge pull request #220 from Robzz/cast_iusize_improvements 
Casts : architecture independent handling of *size types
 2015-08-24 10:49:01 +02:00
Georg Brandl cc8f33d915 ranges: remove unneeded as_str() 2015-08-23 16:34:23 +02:00
Georg Brandl c8a2e848ab utils: extract utility method for matching trait method calls from loops 2015-08-23 16:32:50 +02:00
R.Chavignat 3af2e3ba85 Refactored CastPass. 2015-08-23 06:26:31 +02:00
R.Chavignat e80f2470b7 Merge branch 'master' into cast_iusize_improvements 2015-08-23 00:08:16 +02:00
R.Chavignat 79ef13592e Completed the implementation of *size handling. 
Added some more cases to the test, and implemented a new lint,
cast_possible_wrap, triggered when casting from an unsigned type to a
signed type of the same size.
 2015-08-22 23:49:03 +02:00
R.Chavignat 807dab943b Updated test case for cast lints. 
Also improved readability and reworded the messages.
 2015-08-22 22:06:58 +02:00
llogiq 5a5b1ba96b Merge pull request #216 from birkenfeld/match_pass 
new lint: using &Ref patterns instead of matching on *expr (fixes #187)
 2015-08-22 19:06:48 +02:00
Manish Goregaokar 29c602c7ac Merge pull request #222 from birkenfeld/type_complexity 
types: check for macros in type complexity check
 2015-08-22 18:28:45 +05:30
Georg Brandl 7580da306e matches: special message for this case 
match &e { &Pat1 => {}, &Pat2 => {}, ... }

(inspired by dogfood fixes)
 2015-08-22 14:34:39 +02:00
Georg Brandl 8f1a237493 &-matches: dogfood fixes! 2015-08-22 14:34:39 +02:00
Georg Brandl 017dac2301 new lint: using &Ref patterns instead of matching on *expr (fixes #187) 2015-08-22 14:34:39 +02:00
Georg Brandl 5403e82681 matches: new module, move single_match lint there 2015-08-22 14:34:39 +02:00
Georg Brandl 1587256dc4 types: check for macros in type complexity check 2015-08-22 14:30:53 +02:00
Manish Goregaokar 371584a637 Merge pull request #221 from Manishearth/fix_const 
Fix doubleborrow of refcell in consts.rs
 2015-08-22 13:26:26 +05:30
Manish Goregaokar 1334f2ceae Fix doubleborrow of refcell in consts.rs 2015-08-22 13:02:50 +05:30
Manish Goregaokar f7fb696fee Merge pull request #219 from birkenfeld/type_complexity 
[RFC] new lint: type complexity (fixes #93)
 2015-08-22 12:32:58 +05:30
Georg Brandl 630bb76f96 new lint: type complexity (fixes #93) 
Still very naive, but it's a start.
 2015-08-22 08:57:11 +02:00
Georg Brandl e92bf84a53 ptr_arg: fix panic when pattern type is not in tcx 2015-08-22 08:57:11 +02:00
Manish Goregaokar e1a4248e68 Merge pull request #215 from birkenfeld/type_improvements 
Type improvements
 2015-08-22 12:13:56 +05:30
R.Chavignat f1255d5f5d Casts : work in progress handling *size separately 2015-08-22 02:46:22 +02:00
Georg Brandl 8a10440641 utils: add match_type() helper function 
which saves one level of matching when checking for type paths
 2015-08-21 19:24:38 +02:00
Georg Brandl a437936d49 all: put often used DefPaths into utils as consts 
Also remove the "use xxx;" blocks to ensure import paths don't change.
They don't work anyway since stuff may still be re-exported at the old
location, while we need the "canonical" location for the type checks.

Plus, the test suite catches all these cases.
 2015-08-21 19:23:05 +02:00
Georg Brandl 707e95f2e5 types: use middle::ty types instead of ast types 
This gets rid of the match_ty_unwrap function.
 2015-08-21 19:21:19 +02:00
Georg Brandl b2df15d65a ptr_arg improvements (fixes #214) 
* do not trigger on mutable references
* use "real" type from ty, not AST type
 2015-08-21 19:21:18 +02:00
llogiq 6ffe1ed337 Merge pull request #212 from Manishearth/eq_op_const 
Eq op const
 2015-08-21 12:30:53 +02:00
llogiq a22b3cdcee const folding for eq_op 2015-08-21 12:26:03 +02:00
llogiq 4dcbad1b08 const folding for eq_op 2015-08-21 12:19:07 +02:00
llogiq d3793865c4 Merge pull request #208 from Robzz/iss114 
Implementation of lossy cast lints (issue #114)
 2015-08-21 07:49:19 +02:00
R.Chavignat ad0bc66402 Added support for isize/usize in the CastPass lint pass. 
Extracted the match that determines an integer types's size in a
utility function and implemented support for usize/isize.
Added a needed feature to the crate root.
Added some tests to cover those cases, and a test I previously forgot.
Silenced two errors signaled by dogfood.sh in unicode.rs.
 2015-08-21 03:03:37 +02:00
R.Chavignat dbc9b7f46e Reworked the error messages for more heplfulness. 
Renamed the cast_possible_overflow lint to cast_possible_truncation,
and updated the error message, readme and crate root accordingly.
Added some more information to the message for the cast_precision_loss
lint.
Updated the test case to reflect changes.
 2015-08-20 22:44:40 +02:00