squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity
9208 commits 1 branch 0 tags 1.1 GiB
Commit graph

3471 commits

Author SHA1 Message Date
ThibsG 03bc7aed44 Add async test case for wrong_self_convention lint 2020-08-22 08:14:42 +02:00
bors b57ef14290 Auto merge of #5926 - giraffate:improve_lint_message_in_to_string_in_display, r=yaahc 
Improve lint message in `to_string_in_display`

This is a follow-up of https://github.com/rust-lang/rust-clippy/pull/5831.

changelog: none
 2020-08-22 04:51:38 +00:00
Michael Wright 11efd75aeb Fix false negative in option_as_ref_deref 2020-08-21 07:23:04 +02:00
bors 4104611913 Auto merge of #5928 - mikerite:fix-5924, r=ebroto 
Fix false positive in `PRECEDENCE` lint

Extend the lint to handle chains of methods combined with unary negation.

Closes #5924

changelog: Fix false negative in `PRECEDENCE` lint
 2020-08-20 22:09:27 +00:00
Michael Wright c236c0fb56 Fix false positive in PRECEDENCE lint 
Extend the lint to handle chains of methods combined with unary negation.

Closes #5924
 2020-08-20 06:34:48 +02:00
Takayuki Nakata 902b28275e Improve lint message in to_string_in_display 2020-08-19 22:31:34 +09:00
Eduardo Broto 6a12bae194 no from/to bits in const: add tests cases for f64 2020-08-18 22:19:30 +02:00
Eduardo Broto df4d42fc2d transmute: avoid suggesting from/to bits in const 2020-08-18 21:55:56 +02:00
flip1995 c680602005
Merge remote-tracking branch 'upstream/master' into rustup 2020-08-18 19:50:23 +02:00
bors 9360ca6dc2 Auto merge of #5908 - giraffate:fix_fp_for_same_item_push, r=flip1995 
Fix FP for `same_item_push`

Fixes https://github.com/rust-lang/rust-clippy/issues/5902

changelog: Fix FP for `same_item_push` where the pushed variable is mutated.
 2020-08-17 16:49:03 +00:00
David Wood f13d2bfd9b clippy: support QPath::LangItem 
This commit updates clippy with the introduction of `QPath::LangItem` so
that it still compiles.

Signed-off-by: David Wood <david@davidtw.co>
 2020-08-17 13:55:05 +01:00
Tomasz Miąsko 4f4abf4e06 Warn about explicit self-assignment 
Warn about assignments where left-hand side place expression is the same
as right-hand side value expression. For example, warn about assignment in:

```rust
pub struct Event {
    id: usize,
    x: i32,
    y: i32,
}

pub fn copy_position(a: &mut Event, b: &Event) {
    a.x = b.x;
    a.y = a.y;
}
```
 2020-08-16 23:31:36 +02:00
Dániel Buga fc1e07e0c1 Rename lint to use plural form 2020-08-16 22:16:39 +02:00
Dániel Buga b175642a85 Fix missed rename 2020-08-16 21:33:29 +02:00
Dániel Buga 75637c1eda Catch function calls in argument lists, add tests that tuples don't get linted 2020-08-16 20:27:54 +02:00
Dániel Buga a7cc5d4068 Also simplify if the closure body is an index expression 2020-08-16 20:27:54 +02:00
Dániel Buga a3ea65c2d9 Implement new lint 2020-08-16 20:27:22 +02:00
bors 3bd98895f1 Auto merge of #5725 - montrivo:should-impl-trait, r=flip1995 
should_impl_trait - ignore methods with lifetime params

Fixes: #5617

changelog: don't lint should_implement_trait when an `Iterator::next` case has explicit parameters
 2020-08-16 17:51:18 +00:00
bors 78857cc9d3 Auto merge of #5907 - wiomoc:feature/useless-vec-max-size, r=flip1995 
appreciative too_large_for_stack in useless `vec!`

Fixes: #5847
changelog: Add `too_large_for_stack ` configuration option for `USELESS_VEC`
 2020-08-16 17:30:12 +00:00
bors dff7e74b27 Auto merge of #5903 - jrqc:needless_return, r=ebroto,flip1995 
Needless return

Fixes #5858
changelog: fix false positive [`needless_return`]
 2020-08-16 17:08:45 +00:00
bors c8e05fc1c6 Auto merge of #5881 - wiomoc:feature/single-char-push_str, r=ebroto,flip1995 
Lint `push_str` with a single-character string literal

Fixes #5875
changelog:  `* [single_char_push_str]`
 2020-08-16 16:41:57 +00:00
bors e522ca3c8d Auto merge of #5831 - chansuke:to_string_in_display, r=flip1995 
Don't use `to_string` in impl Display

fixes #3876

this PR is derived from [Toxyxer's implementation](https://github.com/rust-lang/rust-clippy/pull/5574).
changelog: add [`to_string_in_display`] lint
 2020-08-16 16:21:37 +00:00
Eduardo Broto 1a140dcc1c Improve needless_doctest_main by using the parser 2020-08-16 00:25:54 +02:00
jrqc baa4cb1cdd early return removed 2020-08-16 00:24:27 +03:00
jrqc a7d5c2f967 Modifications according to the code review 2020-08-16 00:24:27 +03:00
jrqc 65d10c7abf Borrow checker added 2020-08-16 00:24:27 +03:00
Christoph Walcher ae56e988a2
Merge lint with single_char_pattern 2020-08-15 01:40:55 +02:00
Christoph Walcher 72d2c2eab4
Lint push_str with a single-character string literal 
Fixes #5875
 2020-08-15 01:40:55 +02:00
Takayuki Nakata f98ffa271d Fix FP for same_item_push 
Don't emit a lint when `pushed_item` was declared as mutable variable.
 2020-08-14 22:54:12 +09:00
chansuke 8e549978e5 Don't use to_string in impl Display 2020-08-14 21:38:11 +09:00
Christoph Walcher 8514b8407a
appreciative too_large_for_stack in useless vec! 
Fixes: #5847
 2020-08-14 14:29:16 +02:00
bors d5f5487252 Auto merge of #5899 - JarredAllen:rc-box-suggestion, r=yaahc 
Change Rc<Box<T>> recommendation to be Rc<T> instead of Box<T>

Fixes #5722

changelog: Suggest `Rc<Box<T>>` -> `Rc<T>` in [`redundant_allocation`] lint
 2020-08-13 13:31:55 +00:00
bors fc4fd91914 Auto merge of #5900 - ThibsG:ParensUselessConversion4750, r=phansch 
Fix: keep parenthesis for suggestion in `useless_conversion` lint

Note: this lint was previously named `identity_conversion`.

fixes: #4750

changelog: fix parenthesis for `useless_conversion` lint suggestion
 2020-08-13 05:27:29 +00:00
ThibsG 5634c8da02 Fix: keep parenthesis for suggestion in useless_conversion lint 2020-08-12 21:44:02 +02:00
JarredAllen 480ccc3dbe Change Rc<Box<T>> recommendation to be Rc<T> instead of Box<T> 2020-08-12 10:35:08 -07:00
bors 439bae62a4 Auto merge of #5884 - Ryan1729:patch-1, r=flip1995 
Add the other overloadable operations to suspicious_arithmetic_impl

In #2268 I idly mused that the other user-overloadable operations could be added to this lint. Knowing that the lint was arguably incomplete was gnawing at the back of my mind, so I figured that I might as well make this PR, particularly given the change needed was so small.

changelog: Start warning on suspicious implementations of the `BitAnd`, `BitOr`, `BitXor`, `Rem`, `Shl`, and `Shr` traits.
 2020-08-12 17:00:48 +00:00
Ryan1729 7bd7a46331 run tests/ui/update-references.sh to update 'suspicious_arithmetic_impl.rs' 2020-08-12 10:52:20 -06:00
Ryan1729 f4eeff99b6 add tests for Rem, BitAnd, BitOr, BitXor, Shl, and Shr 2020-08-12 10:33:16 -06:00
flip1995 027780ca2c Merge commit '09bd400243ed6f7059fedc0c1623aae3792521d6' into clippyup 2020-08-11 17:50:45 +02:00
Matthias Krüger be3e695b60 if_not_else: make lint adhere to lint message convention 2020-08-11 16:43:53 +02:00
Matthias Krüger 605e027fda if_let_some_result: make lint adhere to lint message convention 2020-08-11 16:40:45 +02:00
Matthias Krüger 89591a78b8 enum-variant-names: make lint adhere to lint message convention 2020-08-11 16:38:20 +02:00
Matthias Krüger db390f5e6a enum-clike-unportable-variant: tweak message a bit (Clike -> C-like) 2020-08-11 16:35:09 +02:00
Matthias Krüger 2de290d5c5 duration-subsec: make lint adhere to lint message convention 2020-08-11 16:31:02 +02:00
Matthias Krüger 423615693b pub-enum-variant-names: make lint adhere to lint message convention 2020-08-11 16:28:05 +02:00
Matthias Krüger 1f17c3b02b multiple_inherent_impl: make lint adhere to lint message convention 2020-08-11 15:28:51 +02:00
Matthias Krüger bdf4dc3abd implicit-saturating-sub: make lint adhere to lint message convention 2020-08-11 15:22:59 +02:00
Matthias Krüger f171f89aed int_plus_one: make lint adhere to lint message convention 2020-08-11 15:15:26 +02:00
Matthias Krüger 6af297f80e iter-next-slice: make lint adhere to lint message convention 2020-08-11 15:15:26 +02:00
Matthias Krüger 04867e004e mutex-atomic: make lint adhere to lint message convention 2020-08-11 15:15:26 +02:00