libserialize: Always use a decimal point when emitting a float value

JSON doesn't distinguish between integer and float. They are just
numbers. Also, in the current implementation, a fractional number
without the fractional part is encoded without a decimal point.

Thereforce, when the value is decoded, it is first rendered as Json,
either I64 or U64. This reduces type safety, because while the original
intention was to cast the value to float, it can also be casted to
integer.

As a workaround of this problem, this commit makes the encoder always
emit a decimal point even if it is not necessary. If the fractional part
of a float number is zero, ".0" is padded to the end of the result.

[breaking-change]
This commit is contained in:
Barosl Lee 2014-11-24 03:14:02 +09:00
parent f102123b65
commit fec0f16c98

View file

@ -386,7 +386,8 @@ fn spaces(wr: &mut io::Writer, mut n: uint) -> Result<(), io::IoError> {
fn fmt_number_or_null(v: f64) -> string::String {
match v.classify() {
FPNaN | FPInfinite => string::String::from_str("null"),
_ => f64::to_str_digits(v, 6u)
_ if v.fract() != 0f64 => f64::to_str_digits(v, 6u),
_ => f64::to_str_digits(v, 6u) + ".0",
}
}
@ -2504,8 +2505,8 @@ mod tests {
#[test]
fn test_write_f64() {
assert_eq!(F64(3.0).to_string().into_string(), "3");
assert_eq!(F64(3.0).to_pretty_str().into_string(), "3");
assert_eq!(F64(3.0).to_string().into_string(), "3.0");
assert_eq!(F64(3.0).to_pretty_str().into_string(), "3.0");
assert_eq!(F64(3.1).to_string().into_string(), "3.1");
assert_eq!(F64(3.1).to_pretty_str().into_string(), "3.1");