squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Merge #1663

Browse source 
1663: architecture.md: update path to parser tests r=matklad a=eupn



Co-authored-by: eupn <36292692+eupn@users.noreply.github.com>
This commit is contained in:
bors[bot] 2019-08-07 18:31:37 +00:00
parent d74af56248 3c09c8105d
commit fc40e42003
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
docs/dev/architecture.md
View file

@ -83,11 +83,11 @@ Rust syntax tree structure and parser. See
visiting the nodes (this is double plus cool, if you understand how visiting the nodes (this is double plus cool, if you understand how
`Visitor` works, you understand the design of syntax trees). `Visitor` works, you understand the design of syntax trees).
Tests for ra_syntax are mostly data-driven: `tests/data/parser` contains a bunch of `.rs` Tests for ra_syntax are mostly data-driven: `test_data/parser` contains subdirectories with a bunch of `.rs`
(test vectors) and `.txt` files with corresponding syntax trees. During testing, we check (test vectors) and `.txt` files with corresponding syntax trees. During testing, we check
`.rs` against `.txt`. If the `.txt` file is missing, it is created (this is how you update `.rs` against `.txt`. If the `.txt` file is missing, it is created (this is how you update
tests). Additionally, running `cargo gen-tests` will walk the grammar module and collect tests). Additionally, running `cargo gen-tests` will walk the grammar module and collect
all `//test test_name` comments into files inside `tests/data` directory. all `// test test_name` comments into files inside `test_data/parser/inline` directory.
See [#93](https://github.com/rust-analyzer/rust-analyzer/pull/93) for an example PR which See [#93](https://github.com/rust-analyzer/rust-analyzer/pull/93) for an example PR which
fixes a bug in the grammar. fixes a bug in the grammar.