squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Rollup merge of #81125 - jyn514:track-caller, r=lcnr

Browse source 
Add track_caller to .steal()

Before:

```
thread 'rustc' panicked at 'attempt to read from stolen value', /home/joshua/rustc/compiler/rustc_data_structures/src/steal.rs:43:15
```

After:

```
thread 'rustc' panicked at 'attempt to steal from stolen value', compiler/rustc_mir/src/transform/mod.rs:423:25
```

r? `@lcnr`
This commit is contained in:
Ashley Mannix 2021-01-18 21:53:35 +10:00 committed by GitHub
parent 0654e20195 394d7018b9
commit f82100eeed
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
compiler/rustc_data_structures/src/steal.rs
View file

@ -30,6 +30,7 @@ impl<T> Steal<T> {
Steal { value: RwLock::new(Some(value)) }
}
#[track_caller]
pub fn borrow(&self) -> MappedReadGuard<'_, T> {
ReadGuard::map(self.value.borrow(), |opt| match *opt {
None => panic!("attempted to read from stolen value"),
@ -37,10 +38,11 @@ impl<T> Steal<T> {
})
}
#[track_caller]
pub fn steal(&self) -> T {
let value_ref = &mut *self.value.try_write().expect("stealing value which is locked");
let value = value_ref.take();
value.expect("attempt to read from stolen value")
value.expect("attempt to steal from stolen value")
}
}