squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Converted TODO about MacroItems to FIXME as per edwin0cheng

Browse source
This commit is contained in:
veetaha 2020-05-10 21:06:12 +03:00
parent 71f2be968b
commit f5e2e02aa9
2 changed files with 5 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
crates/ra_syntax/src/ast/generated/nodes.rs
View file

@ -2461,12 +2461,8 @@ impl ConstArg {
pub fn eq_token(&self) -> Option<SyntaxToken> { support::token(&self.syntax, T![=]) }
pub fn block_expr(&self) -> Option<BlockExpr> { support::child(&self.syntax) }
}
/// Macro items is a node that holds all the items created by expanding a macro.
///
/// ```
/// foo!(); // expands into some items -v
/// // ❰ struct Foo; impl Bar for Foo; ❱
/// ```
/// FIXME: (@edwin0cheng) Remove it to use ItemList instead
/// https://github.com/rust-analyzer/rust-analyzer/pull/4083#discussion_r422666243
///
/// [Reference](https://doc.rust-lang.org/reference/macros.html)
#[derive(Debug, Clone, PartialEq, Eq, Hash)]

11
xtask/src/ast_src.rs
View file

@ -1990,14 +1990,9 @@ pub(crate) const AST_SRC: AstSrc = AstSrc {
/// [RFC](https://github.com/rust-lang/rfcs/blob/master/text/2000-const-generics.md#declaring-a-const-parameter)
struct ConstArg { Literal, T![=], BlockExpr }
// TODO: Idk what I am writing here, please don't believe these words.
// TODO: clarify @matklad @edwin0cheng
/// Macro items is a node that holds all the items created by expanding a macro.
///
/// ```
/// foo!(); // expands into some items -v
/// // ❰ struct Foo; impl Bar for Foo; ❱
/// ```
/// FIXME: (@edwin0cheng) Remove it to use ItemList instead
/// https://github.com/rust-analyzer/rust-analyzer/pull/4083#discussion_r422666243
///
/// [Reference](https://doc.rust-lang.org/reference/macros.html)
struct MacroItems: ModuleItemOwner { }