From 275dbec86d0e39f2d784eabac557a8bfcf967206 Mon Sep 17 00:00:00 2001 From: Oliver Scherer Date: Tue, 16 Apr 2019 11:04:42 +0200 Subject: [PATCH 1/4] Create PULL_REQUEST_TEMPLATE --- .github/PULL_REQUEST_TEMPLATE | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE new file mode 100644 index 00000000000..42865ffd2f8 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE @@ -0,0 +1,15 @@ + + +changelog: none From f33cbc152dc6fdd47cf1d5eb2343b53e0070c975 Mon Sep 17 00:00:00 2001 From: Oliver Scherer Date: Tue, 16 Apr 2019 13:30:46 +0200 Subject: [PATCH 2/4] Add new lint checklist --- .github/PULL_REQUEST_TEMPLATE | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE index 42865ffd2f8..85c74dbec3e 100644 --- a/.github/PULL_REQUEST_TEMPLATE +++ b/.github/PULL_REQUEST_TEMPLATE @@ -10,6 +10,15 @@ If your PR fixes an issue, you can add "fixes #issue_number" into this PR description. This way the issue will be automatically closed when your PR is merged. +If you added a new lint, here's a checklist for things that will be +checked during review or continuous integration. + +- [ ] Followed [lint naming conventions][lint_naming] +- [ ] Added passing UI tests (including committed `.stderr` file) +- [ ] `cargo test` passes locally +- [ ] Executed `util/dev update_lints` +- [ ] Added lint documentation + Delete this line and everything above before opening your PR --> changelog: none From d383a12debf1a44701c34fbe0e01cddbbbb3a32f Mon Sep 17 00:00:00 2001 From: Oliver Scherer Date: Tue, 16 Apr 2019 15:15:19 +0200 Subject: [PATCH 3/4] Update PULL_REQUEST_TEMPLATE --- .github/PULL_REQUEST_TEMPLATE | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE index 85c74dbec3e..5567b84b3f5 100644 --- a/.github/PULL_REQUEST_TEMPLATE +++ b/.github/PULL_REQUEST_TEMPLATE @@ -18,6 +18,10 @@ checked during review or continuous integration. - [ ] `cargo test` passes locally - [ ] Executed `util/dev update_lints` - [ ] Added lint documentation +- [ ] Run `cargo fmt` + +Note that you can skip the above if you are just opening a WIP PR in +order to get feedback. Delete this line and everything above before opening your PR --> From 3b0185be45e5642f6ed1cc306b6725284e970a72 Mon Sep 17 00:00:00 2001 From: Oliver Scherer Date: Tue, 16 Apr 2019 15:16:08 +0200 Subject: [PATCH 4/4] Update adding_lints.md --- doc/adding_lints.md | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/adding_lints.md b/doc/adding_lints.md index a45551dbf9c..d78e9c28e77 100644 --- a/doc/adding_lints.md +++ b/doc/adding_lints.md @@ -394,6 +394,7 @@ Before submitting your PR make sure you followed all of the basic requirements: - [ ] `cargo test` passes locally - [ ] Executed `util/dev update_lints` - [ ] Added lint documentation +- [ ] Run `cargo fmt` ### Cheatsheet