7237: Use T! for bool keywords r=matklad a=lnicola



Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
This commit is contained in:
bors[bot] 2021-01-10 15:53:39 +00:00 committed by GitHub
commit e1430d822e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 1 deletions

View file

@ -55,7 +55,7 @@ fn generic_arg(p: &mut Parser) {
expressions::literal(p);
m.complete(p, CONST_ARG);
}
TRUE_KW | FALSE_KW => {
T![true] | T![false] => {
expressions::literal(p);
m.complete(p, CONST_ARG);
}

View file

@ -643,6 +643,27 @@ assert!(x >= lo && x <= hi>);
**Rationale:** Less-then comparisons are more intuitive, they correspond spatially to [real line](https://en.wikipedia.org/wiki/Real_line).
## Token names
Use `T![foo]` instead of `SyntaxKind::FOO_KW`.
```rust
// GOOD
match p.current() {
T![true] | T![false] => true,
_ => false,
}
// BAD
match p.current() {
SyntaxKind::TRUE_KW | SyntaxKind::FALSE_KW => true,
_ => false,
}
```
**Rationale:** The macro uses the familiar Rust syntax, avoiding ambiguities like "is this a brace or bracket?".
## Documentation
For `.md` and `.adoc` files, prefer a sentence-per-line format, don't wrap lines.