squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

format macro argument parsing fix

Browse source 
When the character next to `{}` is "shifted" (when mapping a byte index
in the format string to span) we should avoid shifting the span end
index, so first map the index of `}` to span, then bump the span,
instead of first mapping the next byte index to a span (which causes
bumping the end span too much).

Regression test added.

Fixes #83344
This commit is contained in:
Ömer Sinan Ağacan 2021-03-21 17:29:21 +03:00
parent 9f6b5de7de
commit ce4e668e39
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
tests/ui/write_literal_2.stderr
View file

@ -75,8 +75,9 @@ LL | "1", "2", "3",
| |
help: try this help: try this
| |
LL | "some 1{} / {}", "2", "3", LL | "some 1/
| ^ -- LL | {} / {}", "2", "3",
|
error: literal with an empty format string error: literal with an empty format string
--> $DIR/write_literal_2.rs:25:14 --> $DIR/write_literal_2.rs:25:14