squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

check_unsafety: fix unused unsafe block duplication

Browse source 
The duplicate error message is later removed by error message
deduplication, but it still appears on beta and is still a bug
This commit is contained in:
Ariel Ben-Yehuda 2017-11-14 16:01:50 +02:00
parent b5a3ab2e81
commit c0f7cce96e
2 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/librustc_mir/transform/check_unsafety.rs
View file

@ -128,7 +128,6 @@ impl<'a, 'tcx> Visitor<'tcx> for UnsafetyChecker<'a, 'tcx> {
let UnsafetyCheckResult {
violations, unsafe_blocks
} = self.tcx.unsafety_check_result(def_id);
self.inherited_blocks.extend(unsafe_blocks.iter().cloned());
self.register_violations(&violations, &unsafe_blocks);
}
}

17
src/test/ui/issue-45107-unnecessary-unsafe-in-closure.stderr
View file

@ -36,15 +36,16 @@ error: unnecessary `unsafe` block
| |_________________^ unnecessary `unsafe` block
|
note: because it's nested under this `unsafe` block
--> $DIR/issue-45107-unnecessary-unsafe-in-closure.rs:17:13
--> $DIR/issue-45107-unnecessary-unsafe-in-closure.rs:15:5
|
17 | / unsafe {
15 | / unsafe {
16 | | let f = |v: &mut Vec<_>| {
17 | | unsafe {
18 | | v.set_len(24);
19 | | |w: &mut Vec<u32>| { unsafe {
20 | | w.set_len(32);
21 | | } };
22 | | }
| |_____________^
... |
29 | | f(&mut v);
30 | | }
| |_____^
error: unnecessary `unsafe` block
--> $DIR/issue-45107-unnecessary-unsafe-in-closure.rs:23:34
@ -67,5 +68,5 @@ note: because it's nested under this `unsafe` block
30 | | }
| |_____^
error: aborting due to 6 previous errors
error: aborting due to 3 previous errors