squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Make new_without_default ignore const fns; fixes #977

Browse source
This commit is contained in:
Manish Goregaokar 2016-06-03 20:15:07 +05:30
parent d7df882fa0
commit bf4ce86e9e
No known key found for this signature in database
GPG key ID: 3BBF4D3E2EF79F98
2 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
clippy_lints/src/new_without_default.rs
View file

@ -95,7 +95,11 @@ impl LateLintPass for NewWithoutDefault {
return;
}
if let FnKind::Method(name, _, _, _) = kind {
if let FnKind::Method(name, ref sig, _, _) = kind {
if sig.constness == hir::Constness::Const {
// can't be implemented by default
return;
}
if decl.inputs.is_empty() && name.as_str() == "new" &&
cx.access_levels.is_reachable(id) {
let self_ty = cx.tcx.lookup_item_type(cx.tcx.map.local_def_id(

7
tests/compile-fail/new_without_default.rs
View file

@ -1,4 +1,4 @@
#![feature(plugin)]
#![feature(plugin, const_fn)]
#![plugin(clippy)]
#![allow(dead_code)]
@ -70,4 +70,9 @@ impl Private {
fn new() -> Private { unimplemented!() } // We don't lint private items
}
struct Const;
impl Const {
pub const fn new() -> Const { Const } // const fns can't be implemented via Default
}
fn main() {}