squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Apply suggestions from code review

Browse source 
Use array slice instead of `Vec` in `find_macro_calls` as suggested by @ebroto

Co-authored-by: Eduardo Broto <ebroto@tutanota.com>
This commit is contained in:
dp304 2020-12-03 23:07:24 +01:00 committed by Eduardo Broto
parent e58c7dd168
commit bdad7900f4
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
clippy_lints/src/panic_in_result_fn.rs
View file

@ -53,7 +53,7 @@ impl<'tcx> LateLintPass<'tcx> for PanicInResultFn {
fn lint_impl_body<'tcx>(cx: &LateContext<'tcx>, impl_span: Span, body: &'tcx hir::Body<'tcx>) { fn lint_impl_body<'tcx>(cx: &LateContext<'tcx>, impl_span: Span, body: &'tcx hir::Body<'tcx>) {
let panics = find_macro_calls( let panics = find_macro_calls(
vec![ &[
"unimplemented", "unimplemented",
"unreachable", "unreachable",
"panic", "panic",

8
clippy_lints/src/utils/mod.rs
View file

@ -603,12 +603,12 @@ pub fn contains_return(expr: &hir::Expr<'_>) -> bool {
visitor.found visitor.found
} }
struct FindMacroCalls<'a> { struct FindMacroCalls<'a, 'b> {
names: Vec<&'a str>, names: &'a [&'b str],
result: Vec<Span>, result: Vec<Span>,
} }
impl<'a, 'tcx> Visitor<'tcx> for FindMacroCalls<'a> { impl<'a, 'b, 'tcx> Visitor<'tcx> for FindMacroCalls<'a, 'b> {
type Map = Map<'tcx>; type Map = Map<'tcx>;
fn visit_expr(&mut self, expr: &'tcx Expr<'_>) { fn visit_expr(&mut self, expr: &'tcx Expr<'_>) {
@ -625,7 +625,7 @@ impl<'a, 'tcx> Visitor<'tcx> for FindMacroCalls<'a> {
} }
/// Finds calls of the specified macros in a function body. /// Finds calls of the specified macros in a function body.
pub fn find_macro_calls(names: Vec<&str>, body: &'tcx Body<'tcx>) -> Vec<Span> { pub fn find_macro_calls(names: &[&str], body: &Body<'_>) -> Vec<Span> {
let mut fmc = FindMacroCalls { let mut fmc = FindMacroCalls {
names, names,
result: Vec::new(), result: Vec::new(),