squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

mk: Clean just one llvm build at a time. Closes #17852

Browse source 
When building for multiple targets, the initial 'make' invocation
always fails. The missing build stamp causes clean-llvm to be
invoked, but clean-llvm cleans *all* llvm builds. So what happens
is that 1) all llvm's are cleaned (a no-op), 2) llvm-${target1}
builds, 3) all llvm's are cleaned (deleting llvm-${target1}),
4) llvm-${target2} is built, 5) the remaining build for ${target1}
fails because llvm does not exist.

This makes the clean operation only clean the correct llvm build.
Should greatly reduce bot failures.
This commit is contained in:
Brian Anderson 2014-10-29 19:54:52 -07:00
parent 77f44d4a7b
commit b8e7c4fcb9
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
mk/llvm.mk
View file

@ -38,7 +38,7 @@ endif
# the stamp in the source dir. # the stamp in the source dir.
$$(LLVM_STAMP_$(1)): $(S)src/rustllvm/llvm-auto-clean-trigger $$(LLVM_STAMP_$(1)): $(S)src/rustllvm/llvm-auto-clean-trigger
@$$(call E, make: cleaning llvm) @$$(call E, make: cleaning llvm)
$(Q)$(MAKE) clean-llvm $(Q)$(MAKE) clean-llvm$(1)
@$$(call E, make: done cleaning llvm) @$$(call E, make: done cleaning llvm)
touch $$@ touch $$@