diff --git a/crates/ra_db/src/fixture.rs b/crates/ra_db/src/fixture.rs index f6b50c67cf2..482a2f3e651 100644 --- a/crates/ra_db/src/fixture.rs +++ b/crates/ra_db/src/fixture.rs @@ -267,8 +267,8 @@ impl From<&FixtureMeta> for ParsedMeta { ParsedMeta::Root { path: path.to_owned() } } FixtureMeta::File(f) => Self::File(FileMeta { - path: f.path.to_owned().into(), - krate: f.crate_name.to_owned().into(), + path: f.path.to_owned(), + krate: f.crate_name.to_owned(), deps: f.deps.to_owned(), cfg: f.cfg.to_owned(), edition: f diff --git a/crates/ra_hir_def/src/lang_item.rs b/crates/ra_hir_def/src/lang_item.rs index d962db3cc79..3516784b8d8 100644 --- a/crates/ra_hir_def/src/lang_item.rs +++ b/crates/ra_hir_def/src/lang_item.rs @@ -164,7 +164,7 @@ impl LangItems { T: Into + Copy, { if let Some(lang_item_name) = lang_attr(db, item) { - self.items.entry(lang_item_name.clone()).or_insert_with(|| constructor(item)); + self.items.entry(lang_item_name).or_insert_with(|| constructor(item)); } } } diff --git a/crates/ra_hir_ty/src/traits/builtin.rs b/crates/ra_hir_ty/src/traits/builtin.rs index ccab246bfa7..88a422d2cb4 100644 --- a/crates/ra_hir_ty/src/traits/builtin.rs +++ b/crates/ra_hir_ty/src/traits/builtin.rs @@ -290,8 +290,7 @@ fn trait_object_unsize_impl_datum( let self_trait_ref = TraitRef { trait_, substs: self_substs }; let where_clauses = vec![GenericPredicate::Implemented(self_trait_ref)]; - let impl_substs = - Substs::builder(2).push(self_ty).push(Ty::Dyn(target_bounds.clone().into())).build(); + let impl_substs = Substs::builder(2).push(self_ty).push(Ty::Dyn(target_bounds.into())).build(); let trait_ref = TraitRef { trait_: unsize_trait, substs: impl_substs }; diff --git a/crates/ra_ide/src/ssr.rs b/crates/ra_ide/src/ssr.rs index 1873d1d0d0a..130d3b4c3ba 100644 --- a/crates/ra_ide/src/ssr.rs +++ b/crates/ra_ide/src/ssr.rs @@ -196,10 +196,10 @@ fn find(pattern: &SsrPattern, code: &SyntaxNode) -> SsrMatches { ) -> Option { let match_ = check_opt_nodes(pattern.path(), code.path(), placeholders, match_)?; - let mut pattern_fields = - pattern.record_field_list().map(|x| x.fields().collect()).unwrap_or(vec![]); - let mut code_fields = - code.record_field_list().map(|x| x.fields().collect()).unwrap_or(vec![]); + let mut pattern_fields: Vec = + pattern.record_field_list().map(|x| x.fields().collect()).unwrap_or_default(); + let mut code_fields: Vec = + code.record_field_list().map(|x| x.fields().collect()).unwrap_or_default(); if pattern_fields.len() != code_fields.len() { return None;