From a494cc159874ce2b46f19abeda4e2e46b351cff2 Mon Sep 17 00:00:00 2001 From: Tim Chevalier Date: Thu, 7 Jun 2012 13:49:01 -0700 Subject: [PATCH] Comments only: annotate FIXMEs --- src/rustc/middle/astencode.rs | 1 - src/rustc/middle/borrowck/gather_loans.rs | 1 + src/rustc/middle/check_const.rs | 2 +- src/rustc/middle/const_eval.rs | 2 +- 4 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/rustc/middle/astencode.rs b/src/rustc/middle/astencode.rs index 6ebf0ed9ec6..bcf6c799739 100644 --- a/src/rustc/middle/astencode.rs +++ b/src/rustc/middle/astencode.rs @@ -236,7 +236,6 @@ fn visit_ids(item: ast::inlined_item, vfn: fn@(ast::node_id)) { vfn(self_id); vfn(parent_id.node); } - // not sure if this should be here? FIXME visit::fk_dtor(tps, self_id, parent_id) { vec::iter(tps) {|tp| vfn(tp.id)} vfn(id); diff --git a/src/rustc/middle/borrowck/gather_loans.rs b/src/rustc/middle/borrowck/gather_loans.rs index fe59d771042..ed261b09b73 100644 --- a/src/rustc/middle/borrowck/gather_loans.rs +++ b/src/rustc/middle/borrowck/gather_loans.rs @@ -90,6 +90,7 @@ fn req_loans_in_expr(ex: @ast::expr, // will ignore it, but we ought to be requiring it to // be immutable (whereas something like {f:int} would // be fine). + // (See #2493) alt opt_deref_kind(arg_ty.ty) { some(deref_ptr(region_ptr)) | diff --git a/src/rustc/middle/check_const.rs b/src/rustc/middle/check_const.rs index 6c2032c9c34..af4bf8ca910 100644 --- a/src/rustc/middle/check_const.rs +++ b/src/rustc/middle/check_const.rs @@ -122,7 +122,7 @@ fn check_expr(sess: session, def_map: resolve::def_map, } // Make sure a const item doesn't recursively refer to itself -// FIXME: Should use the dependency graph when it's available +// FIXME: Should use the dependency graph when it's available (#1356) fn check_item_recursion(sess: session, ast_map: ast_map::map, def_map: resolve::def_map, it: @item) { diff --git a/src/rustc/middle/const_eval.rs b/src/rustc/middle/const_eval.rs index 5942cc34c78..3fb75900faf 100644 --- a/src/rustc/middle/const_eval.rs +++ b/src/rustc/middle/const_eval.rs @@ -1,7 +1,7 @@ import syntax::ast::*; // FIXME this doesn't handle big integer/float literals correctly (nor does -// the rest of our literal handling) +// the rest of our literal handling - issue #33) enum const_val { const_float(f64), const_int(i64),