squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

use_self: Simplify spanning

Browse source
This commit is contained in:
Michael Wright 2018-07-18 07:57:50 +02:00
parent 5bb52c4869
commit a05c9b63ce
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
clippy_lints/src/use_self.rs
View file

@ -1,4 +1,4 @@
use crate::utils::{in_macro, span_lint_and_then};
use crate::utils::{in_macro, span_lint_and_sugg};
use rustc::hir::intravisit::{walk_path, walk_ty, NestedVisitorMap, Visitor};
use rustc::hir::*;
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
@ -51,9 +51,14 @@ impl LintPass for UseSelf {
const SEGMENTS_MSG: &str = "segments should be composed of at least 1 element";
fn span_use_self_lint(cx: &LateContext, path: &Path) {
span_lint_and_then(cx, USE_SELF, path.span, "unnecessary structure name repetition", |db| {
db.span_suggestion(path.span, "use the applicable keyword", "Self".to_owned());
});
span_lint_and_sugg(
cx,
USE_SELF,
path.span,
"unnecessary structure name repetition",
"use the applicable keyword",
"Self".to_owned(),
);
}
struct TraitImplTyVisitor<'a, 'tcx: 'a> {