Rollup merge of #85285 - GuillaumeGomez:eslint-check, r=jsha,Mark-Simulacrum

Add eslint checks to CI

It also allowed me to fix some potential issues that went unnoticed. Having this process automated will hopefully prevent us to add more errors. :)

cc `@Mark-Simulacrum` (for the add in the CI).
r? `@jsha`
This commit is contained in:
Guillaume Gomez 2021-05-30 21:06:43 +02:00 committed by GitHub
commit 9c873c1240
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions

View file

@ -22,6 +22,7 @@ ENV PATH="/node-v14.4.0-linux-x64/bin:${PATH}"
# Install es-check # Install es-check
# Pin its version to prevent unrelated CI failures due to future es-check versions. # Pin its version to prevent unrelated CI failures due to future es-check versions.
RUN npm install es-check@5.2.3 -g RUN npm install es-check@5.2.3 -g
RUN npm install eslint@7.20.0 -g
COPY scripts/sccache.sh /scripts/ COPY scripts/sccache.sh /scripts/
RUN sh /scripts/sccache.sh RUN sh /scripts/sccache.sh
@ -37,4 +38,5 @@ ENV SCRIPT python3 ../x.py --stage 2 test src/tools/expand-yaml-anchors && \
python3 ../x.py doc --stage 0 library/test && \ python3 ../x.py doc --stage 0 library/test && \
/scripts/validate-toolstate.sh && \ /scripts/validate-toolstate.sh && \
# Runs checks to ensure that there are no ES5 issues in our JS code. # Runs checks to ensure that there are no ES5 issues in our JS code.
es-check es5 ../src/librustdoc/html/static/*.js es-check es5 ../src/librustdoc/html/static/*.js && \
eslint ../src/librustdoc/html/static/*.js

View file

@ -1 +1,2 @@
/* global initSidebarItems */
initSidebarItems({}); initSidebarItems({});