From 991850bc3c2ff34fe8b3e63815067307d8d90db6 Mon Sep 17 00:00:00 2001 From: Aleksey Kladov Date: Wed, 1 Jul 2020 12:31:03 +0200 Subject: [PATCH] Unify magic env var name --- crates/ra_syntax/src/tests.rs | 2 +- docs/dev/README.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/ra_syntax/src/tests.rs b/crates/ra_syntax/src/tests.rs index f14f23628a0..7b4232497ef 100644 --- a/crates/ra_syntax/src/tests.rs +++ b/crates/ra_syntax/src/tests.rs @@ -274,7 +274,7 @@ fn assert_equal_text(expected: &str, actual: &str, path: &Path) { fs::write(path, actual).unwrap(); return; } - if env::var("UPDATE_EXPECTATIONS").is_ok() { + if env::var("UPDATE_EXPECT").is_ok() { println!("rewriting {}", pretty_path.display()); fs::write(path, actual).unwrap(); return; diff --git a/docs/dev/README.md b/docs/dev/README.md index f1139d2f420..f8746240047 100644 --- a/docs/dev/README.md +++ b/docs/dev/README.md @@ -361,10 +361,10 @@ There are two kinds of tests: The purpose of inline tests is not to achieve full coverage by test cases, but to explain to the reader of the code what each particular `if` and `match` is responsible for. If you are tempted to add a large inline test, it might be a good idea to leave only the simplest example in place, and move the test to a manual `parser/ok` test. -To update test data, run with `UPDATE_EXPECTATIONS` variable: +To update test data, run with `UPDATE_EXPECT` variable: ```bash -env UPDATE_EXPECTATIONS=1 cargo qt +env UPDATE_EXPECT=1 cargo qt ``` After adding a new inline test you need to run `cargo xtest codegen` and also update the test data as described above.