Rollup merge of #86327 - GuillaumeGomez:safe-intrinsics, r=lqd
Don't mark "safe" intrinsics as unsafe A good example of this is [intrinsics::abort](https://doc.rust-lang.org/nightly/core/intrinsics/fn.abort.html). Before: ![Screenshot from 2021-06-15 14-58-42](https://user-images.githubusercontent.com/3050060/122056942-65ddad00-cdea-11eb-829e-5f5e258387de.png) After: ![Screenshot from 2021-06-15 14-59-22](https://user-images.githubusercontent.com/3050060/122056956-6aa26100-cdea-11eb-94d8-e18b4956cfa4.png) cc ``@jyn514`` r? ``@lqd``
This commit is contained in:
commit
98d58420c1
2 changed files with 27 additions and 1 deletions
|
@ -26,6 +26,8 @@ use rustc_mir::const_eval::{is_const_fn, is_unstable_const_fn};
|
|||
use rustc_span::hygiene::{AstPass, MacroKind};
|
||||
use rustc_span::symbol::{kw, sym, Ident, Symbol};
|
||||
use rustc_span::{self, ExpnKind};
|
||||
use rustc_target::spec::abi::Abi;
|
||||
use rustc_typeck::check::intrinsic::intrinsic_operation_unsafety;
|
||||
use rustc_typeck::hir_ty_to_ty;
|
||||
|
||||
use std::collections::hash_map::Entry;
|
||||
|
@ -2132,7 +2134,11 @@ impl Clean<Item> for (&hir::ForeignItem<'_>, Option<Symbol>) {
|
|||
decl,
|
||||
generics,
|
||||
header: hir::FnHeader {
|
||||
unsafety: hir::Unsafety::Unsafe,
|
||||
unsafety: if abi == Abi::RustIntrinsic {
|
||||
intrinsic_operation_unsafety(item.ident.name)
|
||||
} else {
|
||||
hir::Unsafety::Unsafe
|
||||
},
|
||||
abi,
|
||||
constness: hir::Constness::NotConst,
|
||||
asyncness: hir::IsAsync::NotAsync,
|
||||
|
|
20
src/test/rustdoc/safe-intrinsic.rs
Normal file
20
src/test/rustdoc/safe-intrinsic.rs
Normal file
|
@ -0,0 +1,20 @@
|
|||
#![feature(intrinsics)]
|
||||
#![feature(no_core)]
|
||||
|
||||
#![no_core]
|
||||
#![crate_name = "foo"]
|
||||
|
||||
extern "rust-intrinsic" {
|
||||
// @has 'foo/fn.abort.html'
|
||||
// @has - '//pre[@class="rust fn"]' 'pub extern "rust-intrinsic" fn abort() -> !'
|
||||
pub fn abort() -> !;
|
||||
// @has 'foo/fn.unreachable.html'
|
||||
// @has - '//pre[@class="rust fn"]' 'pub unsafe extern "rust-intrinsic" fn unreachable() -> !'
|
||||
pub fn unreachable() -> !;
|
||||
}
|
||||
|
||||
extern "C" {
|
||||
// @has 'foo/fn.needs_drop.html'
|
||||
// @has - '//pre[@class="rust fn"]' 'pub unsafe extern "C" fn needs_drop() -> !'
|
||||
pub fn needs_drop() -> !;
|
||||
}
|
Loading…
Reference in a new issue