squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Merge #8733

Browse source 
8733: Add some cov marks for qualified_path completion r=Veykril a=Veykril

bors r+

Co-authored-by: Lukas Tobias Wirth <lukastw97@gmail.com>
This commit is contained in:
bors[bot] 2021-05-04 20:36:26 +00:00 committed by GitHub
parent 5b663f1b07 d26fb188c1
commit 957760a47f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
crates/ide_completion/src/completions/qualified_path.rs
View file

@ -59,6 +59,7 @@ pub(crate) fn complete_qualified_path(acc: &mut Completions, ctx: &CompletionCon
hir::ModuleDef::TypeAlias(a) => { hir::ModuleDef::TypeAlias(a) => {
let ty = a.ty(ctx.db); let ty = a.ty(ctx.db);
if let Some(Adt::Enum(e)) = ty.as_adt() { if let Some(Adt::Enum(e)) = ty.as_adt() {
cov_mark::hit!(completes_variant_through_alias);
add_enum_variants(ctx, acc, e); add_enum_variants(ctx, acc, e);
} }
ty ty
@ -68,6 +69,7 @@ pub(crate) fn complete_qualified_path(acc: &mut Completions, ctx: &CompletionCon
Some(it) => it, Some(it) => it,
None => return, None => return,
}; };
cov_mark::hit!(completes_primitive_assoc_const);
builtin.ty(ctx.db, module) builtin.ty(ctx.db, module)
} }
_ => unreachable!(), _ => unreachable!(),
@ -96,9 +98,8 @@ pub(crate) fn complete_qualified_path(acc: &mut Completions, ctx: &CompletionCon
if context_module.map_or(false, |m| !item.is_visible_from(ctx.db, m)) { if context_module.map_or(false, |m| !item.is_visible_from(ctx.db, m)) {
return None; return None;
} }
match item { if let hir::AssocItem::TypeAlias(ty) = item {
hir::AssocItem::Function(_) | hir::AssocItem::Const(_) => {} acc.add_type_alias(ctx, ty)
hir::AssocItem::TypeAlias(ty) => acc.add_type_alias(ctx, ty),
} }
None::<()> None::<()>
}); });
@ -745,7 +746,7 @@ fn f() {}
} }
#[test] #[test]
fn completes_self_enum() { fn completes_variant_through_self() {
check( check(
r#" r#"
enum Foo { enum Foo {
@ -769,6 +770,7 @@ impl Foo {
#[test] #[test]
fn completes_primitive_assoc_const() { fn completes_primitive_assoc_const() {
cov_mark::check!(completes_primitive_assoc_const);
check( check(
r#" r#"
//- /lib.rs crate:lib deps:core //- /lib.rs crate:lib deps:core
@ -792,7 +794,8 @@ impl u8 {
} }
#[test] #[test]
fn completes_through_alias() { fn completes_variant_through_alias() {
cov_mark::check!(completes_variant_through_alias);
check( check(
r#" r#"
enum Foo { enum Foo {