squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Auto merge of #5286 - matthiaskrgr:delay_vec_creation, r=flip1995

Browse source 
check_pat: delay creation of the "normal" vec until we reach the branch where it is actually needed

changelog: none
This commit is contained in:
bors 2020-03-09 17:09:38 +00:00
commit 92e25bb7e1
1 changed files with 13 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
clippy_lints/src/misc_early.rs
View file

@ -318,18 +318,6 @@ impl EarlyLintPass for MiscEarlyLints {
return;
}
if wilds > 0 {
let mut normal = vec![];
for field in pfields {
match field.pat.kind {
PatKind::Wild => {},
_ => {
if let Ok(n) = cx.sess().source_map().span_to_snippet(field.span) {
normal.push(n);
}
},
}
}
for field in pfields {
if let PatKind::Wild = field.pat.kind {
wilds -= 1;
@ -341,6 +329,19 @@ impl EarlyLintPass for MiscEarlyLints {
"You matched a field with a wildcard pattern. Consider using `..` instead",
);
} else {
let mut normal = vec![];
for field in pfields {
match field.pat.kind {
PatKind::Wild => {},
_ => {
if let Ok(n) = cx.sess().source_map().span_to_snippet(field.span) {
normal.push(n);
}
},
}
}
span_lint_and_help(
cx,
UNNEEDED_FIELD_PATTERN,