squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Add suggestion to use raw identifiers when fixing snake-case lints

Browse source
This commit is contained in:
Skynoodle 2021-01-01 18:34:20 +00:00
parent b919aa4c0f
commit 91f436b456
1 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
compiler/rustc_lint/src/nonstandard_style.rs
View file

@ -275,10 +275,24 @@ impl NonSnakeCase {
// We have a valid span in almost all cases, but we don't have one when linting a crate
// name provided via the command line.
if !ident.span.is_dummy() {
let sc_ident = Ident::from_str_and_span(&sc, ident.span);
let (message, suggestion) = if sc_ident.is_reserved() {
// We shouldn't suggest a reserved identifier to fix non-snake-case identifiers.
// Instead, recommend renaming the identifier entirely or, if permitted,
// escaping it to create a raw identifier.
if sc_ident.name.can_be_raw() {
("rename the identifier or convert it to a snake case raw identifier", sc_ident.to_string())
} else {
("rename the identifier", String::new())
}
} else {
("convert the identifier to snake case", sc)
};
err.span_suggestion(
ident.span,
"convert the identifier to snake case",
sc,
message,
suggestion,
Applicability::MaybeIncorrect,
);
} else {