squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Extend spans to include !.

Browse source
This commit is contained in:
xiongmao86 2020-01-04 11:27:24 +08:00
parent bf9e6ca9f6
commit 8d333a3cbb
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
clippy_lints/src/methods/mod.rs
View file

@ -3275,7 +3275,7 @@ fn lint_filetype_is_file(cx: &LateContext<'_, '_>, expr: &hir::Expr<'_>, args: &
then {
let lint_msg = "`!FileType::is_file()` does not deny all readable file types";
let help_msg = "use `FileType::is_dir()` instead";
span_help_and_lint(cx, FILETYPE_IS_FILE, expr.span, lint_msg, help_msg);
span_help_and_lint(cx, FILETYPE_IS_FILE, parent.span, lint_msg, help_msg);
} else {
let lint_msg = "`FileType::is_file()` does not cover all readable file types";
let help_msg = "use `!FileType::is_dir()` instead";

4
tests/ui/filetype_is_file.stderr
View file

@ -8,10 +8,10 @@ LL | if fs::metadata("foo.txt")?.file_type().is_file() {
= help: use `!FileType::is_dir()` instead
error: `!FileType::is_file()` does not deny all readable file types
--> $DIR/filetype_is_file.rs:13:9
--> $DIR/filetype_is_file.rs:13:8
|
LL | if !fs::metadata("foo.txt")?.file_type().is_file() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: use `FileType::is_dir()` instead