Make moves in arguments explicit in libsyntax and rustc

This commit is contained in:
Tim Chevalier 2012-09-12 11:15:39 -07:00
parent 320331fe35
commit 86e02554fd
7 changed files with 27 additions and 26 deletions

View file

@ -365,19 +365,19 @@ fn ser_variant(cx: ext_ctxt,
let arg_blk = let arg_blk =
cx.blk( cx.blk(
span, span,
ser_ty(cx, tps, tys[i], cx.clone(s), v)); ser_ty(cx, tps, tys[i], cx.clone(s), move v));
cx.stmt(argfn(cx.clone(s), i, arg_blk)) cx.stmt(argfn(cx.clone(s), i, arg_blk))
}; };
let body_blk = cx.blk(span, stmts); let body_blk = cx.blk(span, stmts);
let body = cx.blk(span, ~[cx.stmt(bodyfn(s, body_blk))]); let body = cx.blk(span, ~[cx.stmt(bodyfn(move s, body_blk))]);
{pats: ~[pat], guard: None, body: body} {pats: ~[pat], guard: None, body: body}
} }
fn ser_lambda(cx: ext_ctxt, tps: ser_tps_map, ty: @ast::ty, fn ser_lambda(cx: ext_ctxt, tps: ser_tps_map, ty: @ast::ty,
-s: @ast::expr, -v: @ast::expr) -> @ast::expr { -s: @ast::expr, -v: @ast::expr) -> @ast::expr {
cx.lambda(cx.blk(ty.span, ser_ty(cx, tps, ty, s, v))) cx.lambda(cx.blk(ty.span, ser_ty(cx, tps, ty, move s, move v)))
} }
fn is_vec_or_str(ty: @ast::ty) -> bool { fn is_vec_or_str(ty: @ast::ty) -> bool {
@ -415,7 +415,7 @@ fn ser_ty(cx: ext_ctxt, tps: ser_tps_map,
// For unique evecs/estrs, just pass through to underlying vec or str // For unique evecs/estrs, just pass through to underlying vec or str
ast::ty_uniq(mt) if is_vec_or_str(mt.ty) => { ast::ty_uniq(mt) if is_vec_or_str(mt.ty) => {
ser_ty(cx, tps, mt.ty, s, v) ser_ty(cx, tps, mt.ty, move s, move v)
} }
ast::ty_uniq(mt) => { ast::ty_uniq(mt) => {
@ -439,7 +439,7 @@ fn ser_ty(cx: ext_ctxt, tps: ser_tps_map,
let f = cx.lit_str(fld.span, cx.parse_sess().interner.get( let f = cx.lit_str(fld.span, cx.parse_sess().interner.get(
fld.node.ident)); fld.node.ident));
let i = cx.lit_uint(fld.span, fidx); let i = cx.lit_uint(fld.span, fidx);
let l = ser_lambda(cx, tps, fld.node.mt.ty, cx.clone(s), vf); let l = ser_lambda(cx, tps, fld.node.mt.ty, cx.clone(s), move vf);
#ast[stmt]{$(s).emit_rec_field($(f), $(i), $(l));} #ast[stmt]{$(s).emit_rec_field($(f), $(i), $(l));}
}; };
let fld_lambda = cx.lambda(cx.blk(ty.span, fld_stmts)); let fld_lambda = cx.lambda(cx.blk(ty.span, fld_stmts));
@ -463,7 +463,7 @@ fn ser_ty(cx: ext_ctxt, tps: ser_tps_map,
let arms = ~[ let arms = ~[
ser_variant( ser_variant(
cx, tps, tys, ty.span, s, cx, tps, tys, ty.span, move s,
// Generate pattern (v1, v2, v3) // Generate pattern (v1, v2, v3)
|pats| ast::pat_tup(pats), |pats| ast::pat_tup(pats),
@ -482,20 +482,19 @@ fn ser_ty(cx: ext_ctxt, tps: ser_tps_map,
#ast{ $(s).emit_tup_elt($(idx), $(body)) } #ast{ $(s).emit_tup_elt($(idx), $(body)) }
}) })
]; ];
~[cx.alt_stmt(arms, ty.span, v)] ~[cx.alt_stmt(arms, ty.span, move v)]
} }
ast::ty_path(path, _) => { ast::ty_path(path, _) => {
if vec::len(path.idents) == 1u && if path.idents.len() == 1 && path.types.is_empty() {
vec::is_empty(path.types) {
let ident = path.idents[0]; let ident = path.idents[0];
match tps.find(ident) { match tps.find(ident) {
Some(f) => f(v), Some(f) => f(v),
None => ser_path(cx, tps, path, s, v) None => ser_path(cx, tps, path, move s, move v)
} }
} else { } else {
ser_path(cx, tps, path, s, v) ser_path(cx, tps, path, move s, move v)
} }
} }
@ -634,7 +633,7 @@ fn deser_path(cx: ext_ctxt, tps: deser_tps_map, path: @ast::path,
fn deser_lambda(cx: ext_ctxt, tps: deser_tps_map, ty: @ast::ty, fn deser_lambda(cx: ext_ctxt, tps: deser_tps_map, ty: @ast::ty,
-d: @ast::expr) -> @ast::expr { -d: @ast::expr) -> @ast::expr {
cx.lambda(cx.expr_blk(deser_ty(cx, tps, ty, d))) cx.lambda(cx.expr_blk(deser_ty(cx, tps, ty, move d)))
} }
fn deser_ty(cx: ext_ctxt, tps: deser_tps_map, fn deser_ty(cx: ext_ctxt, tps: deser_tps_map,
@ -658,7 +657,7 @@ fn deser_ty(cx: ext_ctxt, tps: deser_tps_map,
// For unique evecs/estrs, just pass through to underlying vec or str // For unique evecs/estrs, just pass through to underlying vec or str
ast::ty_uniq(mt) if is_vec_or_str(mt.ty) => { ast::ty_uniq(mt) if is_vec_or_str(mt.ty) => {
deser_ty(cx, tps, mt.ty, d) deser_ty(cx, tps, mt.ty, move d)
} }
ast::ty_uniq(mt) => { ast::ty_uniq(mt) => {
@ -719,10 +718,10 @@ fn deser_ty(cx: ext_ctxt, tps: deser_tps_map,
match tps.find(ident) { match tps.find(ident) {
Some(f) => f(), Some(f) => f(),
None => deser_path(cx, tps, path, d) None => deser_path(cx, tps, path, move d)
} }
} else { } else {
deser_path(cx, tps, path, d) deser_path(cx, tps, path, move d)
} }
} }
@ -822,8 +821,9 @@ fn ty_fns(cx: ext_ctxt, name: ast::ident,
let span = ty.span; let span = ty.span;
~[ ~[
mk_ser_fn(cx, span, name, tps, |a,b,c,d| ser_ty(a, b, ty, c, d)), mk_ser_fn(cx, span, name, tps, |a,b,c,d| ser_ty(a, b, ty, move c,
mk_deser_fn(cx, span, name, tps, |a,b,c| deser_ty(a, b, ty, c)) move d)),
mk_deser_fn(cx, span, name, tps, |a,b,c| deser_ty(a, b, ty, move c))
] ]
} }
@ -881,7 +881,7 @@ fn ser_enum(cx: ext_ctxt, tps: ser_tps_map, e_name: ast::ident,
fail ~"struct variants unimplemented for auto serialize" fail ~"struct variants unimplemented for auto serialize"
} }
}; };
let lam = cx.lambda(cx.blk(e_span, ~[cx.alt_stmt(arms, e_span, v)])); let lam = cx.lambda(cx.blk(e_span, ~[cx.alt_stmt(arms, e_span, move v)]));
let e_name = cx.lit_str(e_span, @cx.str_of(e_name)); let e_name = cx.lit_str(e_span, @cx.str_of(e_name));
~[#ast[stmt]{ $(s).emit_enum($(e_name), $(lam)) }] ~[#ast[stmt]{ $(s).emit_enum($(e_name), $(lam)) }]
} }
@ -954,8 +954,9 @@ fn enum_fns(cx: ext_ctxt, e_name: ast::ident, e_span: span,
-> ~[@ast::item] { -> ~[@ast::item] {
~[ ~[
mk_ser_fn(cx, e_span, e_name, tps, mk_ser_fn(cx, e_span, e_name, tps,
|a,b,c,d| ser_enum(a, b, e_name, e_span, variants, c, d)), |a,b,c,d| ser_enum(a, b, e_name, e_span, variants, move c,
move d)),
mk_deser_fn(cx, e_span, e_name, tps, mk_deser_fn(cx, e_span, e_name, tps,
|a,b,c| deser_enum(a, b, e_name, e_span, variants, c)) |a,b,c| deser_enum(a, b, e_name, e_span, variants, move c))
] ]
} }

View file

@ -96,7 +96,7 @@ mod jit {
code: ptr, code: ptr,
env: ptr::null() env: ptr::null()
}; };
let func: fn(~[~str]) = unsafe::transmute(closure); let func: fn(~[~str]) = unsafe::transmute(move closure);
func(~[sess.opts.binary]); func(~[sess.opts.binary]);
} }

View file

@ -228,7 +228,7 @@ fn monitor(+f: fn~(diagnostic::emitter)) {
let p = comm::Port(); let p = comm::Port();
let ch = comm::Chan(p); let ch = comm::Chan(p);
match do task::try { match do task::try |move f| {
// The 'diagnostics emitter'. Every error, warning, etc. should // The 'diagnostics emitter'. Every error, warning, etc. should
// go through this function. // go through this function.

View file

@ -1046,7 +1046,7 @@ fn new_block(cx: fn_ctxt, parent: Option<block>, +kind: block_kind,
let llbb: BasicBlockRef = str::as_c_str(cx.ccx.sess.str_of(s), |buf| { let llbb: BasicBlockRef = str::as_c_str(cx.ccx.sess.str_of(s), |buf| {
llvm::LLVMAppendBasicBlock(cx.llfn, buf) llvm::LLVMAppendBasicBlock(cx.llfn, buf)
}); });
let bcx = mk_block(llbb, parent, kind, is_lpad, opt_node_info, cx); let bcx = mk_block(llbb, parent, move kind, is_lpad, opt_node_info, cx);
do option::iter(parent) |cx| { do option::iter(parent) |cx| {
if cx.unreachable { Unreachable(bcx); } if cx.unreachable { Unreachable(bcx); }
}; };

View file

@ -527,7 +527,7 @@ enum block = @block_;
fn mk_block(llbb: BasicBlockRef, parent: Option<block>, -kind: block_kind, fn mk_block(llbb: BasicBlockRef, parent: Option<block>, -kind: block_kind,
is_lpad: bool, node_info: Option<node_info>, fcx: fn_ctxt) is_lpad: bool, node_info: Option<node_info>, fcx: fn_ctxt)
-> block { -> block {
block(@block_(llbb, parent, kind, is_lpad, node_info, fcx)) block(@block_(llbb, parent, move kind, is_lpad, node_info, fcx))
} }
// First two args are retptr, env // First two args are retptr, env

View file

@ -131,7 +131,7 @@ enum debug_metadata {
fn cast_safely<T: Copy, U>(val: T) -> U unsafe { fn cast_safely<T: Copy, U>(val: T) -> U unsafe {
let val2 = val; let val2 = val;
return unsafe::transmute(val2); return unsafe::transmute(move val2);
} }
fn md_from_metadata<T>(val: debug_metadata) -> T unsafe { fn md_from_metadata<T>(val: debug_metadata) -> T unsafe {

View file

@ -383,7 +383,7 @@ type t = *t_opaque;
pure fn get(t: t) -> t_box unsafe { pure fn get(t: t) -> t_box unsafe {
let t2 = unsafe::reinterpret_cast::<t, t_box>(&t); let t2 = unsafe::reinterpret_cast::<t, t_box>(&t);
let t3 = t2; let t3 = t2;
unsafe::forget(t2); unsafe::forget(move t2);
t3 t3
} }