From 1fd0676fa3c859ec9f0e83fc7266189ea62b4635 Mon Sep 17 00:00:00 2001 From: llogiq Date: Thu, 18 Feb 2016 20:12:33 +0100 Subject: [PATCH] improve str_add_assign lint description --- src/strings.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/strings.rs b/src/strings.rs index 14c2e877919..a7dca02c967 100644 --- a/src/strings.rs +++ b/src/strings.rs @@ -13,9 +13,9 @@ use utils::STRING_PATH; /// **What it does:** This lint matches code of the form `x = x + y` (without `let`!). /// -/// **Why is this bad?** Because this expression needs another copy as opposed to `x.push_str(y)` (in practice LLVM will usually elide it, though). Despite [llogiq](https://github.com/llogiq)'s reservations, this lint also is `allow` by default, as some people opine that it's more readable. +/// **Why is this bad?** It's not really bad, but some people think that the `.push_str(_)` method is more readable. /// -/// **Known problems:** None. Well apart from the lint being `allow` by default. :smile: +/// **Known problems:** None. /// /// **Example:** ///