Lint foo = bar; bar = foo
sequences
This commit is contained in:
parent
98eb623043
commit
72ef26272d
|
@ -8,7 +8,7 @@ A collection of lints to catch common mistakes and improve your Rust code.
|
|||
[Jump to usage instructions](#usage)
|
||||
|
||||
##Lints
|
||||
There are 125 lints included in this crate:
|
||||
There are 126 lints included in this crate:
|
||||
|
||||
name | default | meaning
|
||||
---------------------------------------------------------------------------------------------------------------------|---------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
|
||||
|
@ -114,6 +114,7 @@ name
|
|||
[string_to_string](https://github.com/Manishearth/rust-clippy/wiki#string_to_string) | warn | calling `String::to_string` which is inefficient
|
||||
[suspicious_assignment_formatting](https://github.com/Manishearth/rust-clippy/wiki#suspicious_assignment_formatting) | warn | suspicious formatting of `*=`, `-=` or `!=`
|
||||
[suspicious_else_formatting](https://github.com/Manishearth/rust-clippy/wiki#suspicious_else_formatting) | warn | suspicious formatting of `else if`
|
||||
[suspicious_swap](https://github.com/Manishearth/rust-clippy/wiki#suspicious_swap) | warn | `foo = bar; bar = foo` sequence
|
||||
[temporary_assignment](https://github.com/Manishearth/rust-clippy/wiki#temporary_assignment) | warn | assignments to temporaries
|
||||
[toplevel_ref_arg](https://github.com/Manishearth/rust-clippy/wiki#toplevel_ref_arg) | warn | An entire binding was declared as `ref`, in a function argument (`fn foo(ref x: Bar)`), or a `let` statement (`let ref x = foo()`). In such cases, it is preferred to take references with `&`.
|
||||
[trivial_regex](https://github.com/Manishearth/rust-clippy/wiki#trivial_regex) | warn | finds trivial regular expressions in `Regex::new(_)` invocations
|
||||
|
|
|
@ -86,6 +86,7 @@ pub mod regex;
|
|||
pub mod returns;
|
||||
pub mod shadow;
|
||||
pub mod strings;
|
||||
pub mod swap;
|
||||
pub mod temporary_assignment;
|
||||
pub mod transmute;
|
||||
pub mod types;
|
||||
|
@ -167,6 +168,7 @@ pub fn plugin_registrar(reg: &mut Registry) {
|
|||
reg.register_late_lint_pass(box copies::CopyAndPaste);
|
||||
reg.register_late_lint_pass(box format::FormatMacLint);
|
||||
reg.register_early_lint_pass(box formatting::Formatting);
|
||||
reg.register_late_lint_pass(box swap::Swap);
|
||||
|
||||
reg.register_lint_group("clippy_pedantic", vec![
|
||||
enum_glob_use::ENUM_GLOB_USE,
|
||||
|
@ -285,6 +287,7 @@ pub fn plugin_registrar(reg: &mut Registry) {
|
|||
returns::LET_AND_RETURN,
|
||||
returns::NEEDLESS_RETURN,
|
||||
strings::STRING_LIT_AS_BYTES,
|
||||
swap::SUSPICIOUS_SWAP,
|
||||
temporary_assignment::TEMPORARY_ASSIGNMENT,
|
||||
transmute::USELESS_TRANSMUTE,
|
||||
types::ABSURD_EXTREME_COMPARISONS,
|
||||
|
|
66
src/swap.rs
Normal file
66
src/swap.rs
Normal file
|
@ -0,0 +1,66 @@
|
|||
use rustc::lint::*;
|
||||
use rustc_front::hir::*;
|
||||
use utils::{differing_macro_contexts, snippet_opt, span_lint_and_then, SpanlessEq};
|
||||
use syntax::codemap::mk_sp;
|
||||
|
||||
/// **What it does:** This lints `foo = bar; bar = foo` sequences.
|
||||
///
|
||||
/// **Why is this bad?** This looks like a failed attempt to swap.
|
||||
///
|
||||
/// **Known problems:** None.
|
||||
///
|
||||
/// **Example:**
|
||||
/// ```rust,ignore
|
||||
/// a = b;
|
||||
/// b = a;
|
||||
/// ```
|
||||
declare_lint! {
|
||||
pub SUSPICIOUS_SWAP,
|
||||
Warn,
|
||||
"`foo = bar; bar = foo` sequence"
|
||||
}
|
||||
|
||||
#[derive(Copy,Clone)]
|
||||
pub struct Swap;
|
||||
|
||||
impl LintPass for Swap {
|
||||
fn get_lints(&self) -> LintArray {
|
||||
lint_array![SUSPICIOUS_SWAP]
|
||||
}
|
||||
}
|
||||
|
||||
impl LateLintPass for Swap {
|
||||
fn check_block(&mut self, cx: &LateContext, block: &Block) {
|
||||
for w in block.stmts.windows(2) {
|
||||
if_let_chain!{[
|
||||
let StmtSemi(ref first, _) = w[0].node,
|
||||
let StmtSemi(ref second, _) = w[1].node,
|
||||
!differing_macro_contexts(first.span, second.span),
|
||||
let ExprAssign(ref lhs0, ref rhs0) = first.node,
|
||||
let ExprAssign(ref lhs1, ref rhs1) = second.node,
|
||||
SpanlessEq::new(cx).ignore_fn().eq_expr(lhs0, rhs1),
|
||||
SpanlessEq::new(cx).ignore_fn().eq_expr(lhs1, rhs0)
|
||||
], {
|
||||
let (what, lhs, rhs) = if let (Some(first), Some(second)) = (snippet_opt(cx, lhs0.span), snippet_opt(cx, rhs0.span)) {
|
||||
(format!(" `{}` and `{}`", first, second), first, second)
|
||||
} else {
|
||||
("".to_owned(), "".to_owned(), "".to_owned())
|
||||
};
|
||||
|
||||
let span = mk_sp(first.span.lo, second.span.hi);
|
||||
|
||||
span_lint_and_then(cx,
|
||||
SUSPICIOUS_SWAP,
|
||||
span,
|
||||
&format!("this looks like you are trying to swap{}", what),
|
||||
|db| {
|
||||
if !what.is_empty() {
|
||||
db.span_suggestion(span, "try",
|
||||
format!("std::mem::swap({}, {})", lhs, rhs));
|
||||
db.fileline_note(span, "or maybe you should use `std::mem::replace`?");
|
||||
}
|
||||
});
|
||||
}}
|
||||
}
|
||||
}
|
||||
}
|
17
tests/compile-fail/swap.rs
Executable file
17
tests/compile-fail/swap.rs
Executable file
|
@ -0,0 +1,17 @@
|
|||
#![feature(plugin)]
|
||||
#![plugin(clippy)]
|
||||
|
||||
#![deny(clippy)]
|
||||
#![allow(unused_assignments)]
|
||||
|
||||
fn main() {
|
||||
let mut a = 42;
|
||||
let mut b = 1337;
|
||||
|
||||
a = b;
|
||||
b = a;
|
||||
//~^^ ERROR this looks like you are trying to swap `a` and `b`
|
||||
//~| HELP try
|
||||
//~| SUGGESTION std::mem::swap(a, b);
|
||||
//~| NOTE or maybe you should use `std::mem::replace`?
|
||||
}
|
Loading…
Reference in a new issue