Add error for comma after base struct field

`let x = { ..default(), } // This comma is an error`
This commit is contained in:
Badel2 2017-10-10 04:11:22 +02:00
parent 0217315bf2
commit 72cfd20941
3 changed files with 56 additions and 0 deletions

View file

@ -2314,6 +2314,7 @@ impl<'a> Parser<'a> {
while self.token != token::CloseDelim(token::Brace) {
if self.eat(&token::DotDot) {
let exp_span = self.prev_span;
match self.parse_expr() {
Ok(e) => {
base = Some(e);
@ -2323,6 +2324,16 @@ impl<'a> Parser<'a> {
self.recover_stmt();
}
}
if self.token == token::Comma {
let mut err = self.sess.span_diagnostic.mut_span_err(
exp_span.to(self.prev_span),
"cannot use a comma after the base struct",
);
err.span_suggestion_short(self.span, "remove this comma", "".to_owned());
err.note("the base struct must always be the last field");
err.emit();
self.recover_stmt();
}
break;
}

View file

@ -0,0 +1,27 @@
// Copyright 2017 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.
// compile-flags: -Z parse-only
// issue #41834
fn main() {
let foo = Foo {
one: 111,
..Foo::default(),
//~^ ERROR cannot use a comma after struct expansion
};
let foo = Foo {
..Foo::default(),
//~^ ERROR cannot use a comma after struct expansion
one: 111,
};
}

View file

@ -0,0 +1,18 @@
error: cannot use a comma after the base struct
--> $DIR/struct-field-init-syntax.rs:18:9
|
18 | ..Foo::default(),
| ^^^^^^^^^^^^^^^^- help: remove this comma
|
= note: the base struct must always be the last field
error: cannot use a comma after the base struct
--> $DIR/struct-field-init-syntax.rs:23:9
|
23 | ..Foo::default(),
| ^^^^^^^^^^^^^^^^- help: remove this comma
|
= note: the base struct must always be the last field
error: aborting due to 2 previous errors