squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Rollup merge of #22341 - fhahn:issue-22291-PLEASE-FAIL, r=alexcrichton

Browse source 
This is a patch for #22291.

PLEASE_BENCH=1 adds --bench to the arguments passed to the executable to be tested. At the moment, compiletest does not accept a --bench argument, because it is not needed for any test in src/test/, even the tests in src/test/bench do not use #[bench].

I have updated the makefile to only add the --bench flag for crate tests. I do not think that changing compiletest add --bench to the run arguments of all compile tests makes sense, because it would mess up tests which check command line arguments. Also the bench option can be added as comment in a compile test as well.
This commit is contained in:
Manish Goregaokar 2015-02-16 11:27:42 +05:30
parent b0d2c6a714 ff1181da15
commit 6cab5bba75
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
mk/tests.mk
View file

@ -38,16 +38,11 @@ ifdef CHECK_IGNORED
TESTARGS += --ignored
endif
# Arguments to the cfail/rfail/rpass/bench tests
ifdef CFG_VALGRIND
CTEST_RUNTOOL = --runtool "$(CFG_VALGRIND)"
endif
ifdef PLEASE_BENCH
TESTARGS += --bench
endif
# Arguments to the perf tests
ifdef CFG_PERF_TOOL
CTEST_PERF_RUNTOOL = --runtool "$(CFG_PERF_TOOL)"
@ -55,6 +50,11 @@ endif
CTEST_TESTARGS := $(TESTARGS)
# --bench is only relevant for crate tests, not for the compile tests
ifdef PLEASE_BENCH
TESTARGS += --bench
endif
ifdef VERBOSE
CTEST_TESTARGS += --verbose
endif