squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Simplify approx const truncation check

Browse source
This commit is contained in:
Michael Wright 2019-10-29 08:34:05 +02:00
parent e2104d1e2e
commit 5ce8990885
1 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
clippy_lints/src/approx_const.rs
View file

@ -97,14 +97,11 @@ fn check_known_consts(cx: &LateContext<'_, '_>, e: &Expr, s: symbol::Symbol, mod
fn is_approx_const(constant: f64, value: &str, min_digits: usize) -> bool {
if value.len() <= min_digits {
false
} else if constant.to_string().starts_with(value) {
// The value is a truncated constant
true
} else {
let round_const = format!("{:.*}", value.len() - 2, constant);
let mut trunc_const = constant.to_string();
if trunc_const.len() > value.len() {
trunc_const.truncate(value.len());
}
(value == round_const) || (value == trunc_const)
value == round_const
}
}