squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

Rollup merge of #47505 - alexcrichton:fix-bat-spawn-regression, r=estebank

Browse source 
rustc: Spawn `cmd /c` for `.bat` scripts

This fixes an accidental regression #46335 where the behavior of
`Path::ends_with` is different from `str::ends_with` (paths operate over
components, strs operate over chars).
This commit is contained in:
kennytm 2018-01-18 01:57:30 +08:00 committed by GitHub
commit 54299e2eb7
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/librustc_trans/back/link.rs
View file

@ -69,13 +69,14 @@ pub fn get_linker(sess: &Session) -> (PathBuf, Command, Vec<(OsString, OsString)
// was tagged as #42791) and some more info can be found on #44443 for
// emscripten itself.
let cmd = |linker: &Path| {
if cfg!(windows) && linker.ends_with(".bat") {
let mut cmd = Command::new("cmd");
cmd.arg("/c").arg(linker);
cmd
} else {
Command::new(linker)
if let Some(linker) = linker.to_str() {
if cfg!(windows) && linker.ends_with(".bat") {
let mut cmd = Command::new("cmd");
cmd.arg("/c").arg(linker);
return cmd
}
}
Command::new(linker)
};
if let Some(ref linker) = sess.opts.cg.linker {