squiid/rust
1
0
Fork 0
Code Issues Pull requests Projects Activity

ItemTree: Lower fields despite invalid type

Browse source
This commit is contained in:
Jonas Schievink 2020-07-01 19:24:39 +02:00
parent ad1a0e626b
commit 4ef1d533bd
2 changed files with 25 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
crates/ra_hir_def/src/item_tree/lower.rs
View file

@ -211,7 +211,7 @@ impl Ctx {
fn lower_record_field(&mut self, field: &ast::RecordFieldDef) -> Option<Field> {
let name = field.name()?.as_name();
let visibility = self.lower_visibility(field);
let type_ref = self.lower_type_ref(&field.ascribed_type()?);
let type_ref = self.lower_type_ref_opt(field.ascribed_type());
let res = Field { name, type_ref, visibility };
Some(res)
}

24
crates/ra_hir_ty/src/tests.rs
View file

@ -507,6 +507,30 @@ fn no_such_field_with_feature_flag_diagnostics_on_struct_fields() {
assert_snapshot!(diagnostics, @r###""###);
}
#[test]
fn no_such_field_with_type_macro() {
let diagnostics = TestDB::with_files(
r"
macro_rules! Type {
() => { u32 };
}
struct Foo {
bar: Type![],
}
impl Foo {
fn new() -> Self {
Foo { bar: 0 }
}
}
",
)
.diagnostics()
.0;
assert_snapshot!(diagnostics, @r###""###);
}
#[test]
fn missing_record_pat_field_diagnostic() {
let diagnostics = TestDB::with_files(